From: Chen-Yu Tsai <wens@csie.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Sean Paul <seanpaul@chromium.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2 13/13] ARM: dts: sun9i: Add missing unit address
Date: Fri, 15 Mar 2019 18:22:44 +0800 [thread overview]
Message-ID: <CAGb2v66Zb-HshqB3+QVMMgtkTJYpt8Z4rYS8BmEjeRJH1w0irg@mail.gmail.com> (raw)
In-Reply-To: <20190315091636.b2skesvxtgqauanl@flea>
On Fri, Mar 15, 2019 at 5:16 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Fri, Mar 15, 2019 at 05:09:22PM +0800, Chen-Yu Tsai wrote:
> > On Fri, Mar 15, 2019 at 5:02 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > >
> > > On Fri, Mar 15, 2019 at 10:39:24AM +0800, Chen-Yu Tsai wrote:
> > > > On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > >
> > > > > The soc node in the A80 DTSI has a ranges property, but no matching unit
> > > > > address, which results in a DTC warning. Add the unit address to remove
> > > > > that warning.
> > > > >
> > > > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > > > > ---
> > > > > arch/arm/boot/dts/sun9i-a80.dtsi | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi
> > > > > index 9b15f272e5f5..7a495c84ab65 100644
> > > > > --- a/arch/arm/boot/dts/sun9i-a80.dtsi
> > > > > +++ b/arch/arm/boot/dts/sun9i-a80.dtsi
> > > > > @@ -289,7 +289,7 @@
> > > > > status = "disabled";
> > > > > };
> > > > >
> > > > > - soc {
> > > > > + soc@20000 {
> > > >
> > > > I thought we didn't like the soc node having an address?
> > >
> > > In general, yes, but in general we also don't have a ranges property.
> > >
> > > > Maybe we just bite the bullet and use 64-bit addresses and sizes for
> > > > the A80?
> > >
> > > I'd rather not, the current layout of the DT is pretty nice.
> > >
> > > But now I'm thinking, do you remember why we need to do that mapping
> > > in the first place? It's a 32bits SoCs, so why do we need to care
> > > about 64 bits addresses?
> >
> > It supports LPAE, addressing up to 8GB of RAM. Not that I've seen a
> > board sporting that much RAM though. Theobroma Systems might have
> > had such a board though, as their product page says "up to 8GB RAM".
>
> Ah, right. What should we do about this patch then?
I'm OK with it I suppose. AFAICT only sysfs paths and overlays (which should
use labels instead) are affected.
ChenYu
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-15 10:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
2019-03-14 20:16 ` [PATCH v2 01/13] drm/sun4i: backend: Simplify the get_id logic Maxime Ripard
2019-03-15 2:43 ` Chen-Yu Tsai
2019-03-15 8:38 ` Maxime Ripard
2019-03-14 20:16 ` [PATCH v2 02/13] drm/sun4i: mixer: " Maxime Ripard
2019-03-15 2:44 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 03/13] ARM: dts: sun8i: a83t: Add cross links for the mixers Maxime Ripard
2019-03-15 2:53 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 04/13] arm64: dts: allwinner: a64: " Maxime Ripard
2019-03-15 2:54 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 05/13] ARM: dts: sun5i: Fix display pipeline endpoint warnings in DTC Maxime Ripard
2019-03-15 2:29 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 06/13] ARM: dts: sun5i: Fix Display Engine DTC warnings Maxime Ripard
2019-03-15 2:30 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 07/13] ARM: dts: sun6i: " Maxime Ripard
2019-03-15 2:29 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 08/13] ARM: dts: sun8i: a23/a33: " Maxime Ripard
2019-03-15 2:28 ` Chen-Yu Tsai
2019-03-15 8:57 ` Maxime Ripard
2019-03-14 20:16 ` [PATCH v2 09/13] ARM: dts: sun8i: v3s: " Maxime Ripard
2019-03-15 2:32 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 10/13] ARM: dts: sun8i: a83t: " Maxime Ripard
2019-03-15 2:34 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 11/13] ARM: dts: sun8i: r40: " Maxime Ripard
2019-03-15 2:35 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 12/13] ARM: dts: sun9i: " Maxime Ripard
2019-03-15 2:35 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 13/13] ARM: dts: sun9i: Add missing unit address Maxime Ripard
2019-03-15 2:39 ` Chen-Yu Tsai
2019-03-15 9:02 ` Maxime Ripard
2019-03-15 9:09 ` Chen-Yu Tsai
2019-03-15 9:16 ` Maxime Ripard
2019-03-15 10:22 ` Chen-Yu Tsai [this message]
2019-03-15 11:58 ` Maxime Ripard
2019-03-15 9:08 ` [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v66Zb-HshqB3+QVMMgtkTJYpt8Z4rYS8BmEjeRJH1w0irg@mail.gmail.com \
--to=wens@csie.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maxime.ripard@bootlin.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).