[PATCH 0/3] drm/panel: simple: Add support for Evervision VGG804821

[PATCH 0/3] drm/panel: simple: Add support for Evervision VGG804821

[Marco Felsch]

This small series adds the support for the Evervision VGG804821 panels.
The patches are rebased ontop of the current drm_misc/drm-misc-next.

Marco Felsch (3):
  dt-bindings: add vendor prefix for Evervision Electronics
  dt-bindings: drm/panel: simple: add Evervision VGG804821
  drm/panel: simple: Add Evervision VGG804821 pannel support

 .../display/panel/evervision,vgg804821.txt    | 12 ++++++++
 .../devicetree/bindings/vendor-prefixes.txt   |  1 +
 drivers/gpu/drm/panel/panel-simple.c          | 30 +++++++++++++++++++
 3 files changed, 43 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt

-- 
2.19.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/3] dt-bindings: add vendor prefix for Evervision Electronics

[Marco Felsch]

Evervision Electronics is a panel manufacturer from Taipei.
http://www.evervisionlcd.com/index.php?lang=en

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index a2f4451cf3f9..bfdb538fd892 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -127,6 +127,7 @@ ettus	NI Ettus Research
 eukrea  Eukréa Electromatique
 everest	Everest Semiconductor Co. Ltd.
 everspin	Everspin Technologies, Inc.
+evervision	Evervision Electronics Co. Ltd.
 exar	Exar Corporation
 excito	Excito
 ezchip	EZchip Semiconductor
-- 
2.19.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/3] dt-bindings: drm/panel: simple: add Evervision VGG804821

[Marco Felsch]

Add support for the Evervision VG804821 800x480 5.0" LCD TFT parallel
panel to DRM simple panel driver.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 .../bindings/display/panel/evervision,vgg804821.txt  | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt

diff --git a/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
new file mode 100644
index 000000000000..82d22e191ac3
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
@@ -0,0 +1,12 @@
+Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
+
+Required properties:
+- compatible: should be "evervision,vgg804821"
+- power-supply: See simple-panel.txt
+
+Optional properties:
+- backlight: See simple-panel.txt
+- enable-gpios: See simple-panel.txt
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
2.19.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 3/3] drm/panel: simple: Add Evervision VGG804821 pannel support

[Marco Felsch]

Add support the Evervision VGG804821 800x480 5.0" WVGA TFT panel.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 9c69e739a524..82047490a86f 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1160,6 +1160,33 @@ static const struct panel_desc edt_etm0700g0bdh6 = {
 	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
 };
 
+static const struct display_timing evervision_vgg804821_timing = {
+	.pixelclock = { 27600000, 33300000, 50000000 },
+	.hactive = { 800, 800, 800 },
+	.hfront_porch = { 40, 66, 70 },
+	.hback_porch = { 40, 67, 70 },
+	.hsync_len = { 40, 67, 70 },
+	.vactive = { 480, 480, 480 },
+	.vfront_porch = { 6, 10, 10 },
+	.vback_porch = { 7, 11, 11 },
+	.vsync_len = { 7, 11, 11 },
+	.flags = DISPLAY_FLAGS_HSYNC_HIGH | DISPLAY_FLAGS_VSYNC_HIGH |
+		 DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
+		 DISPLAY_FLAGS_SYNC_NEGEDGE,
+};
+
+static const struct panel_desc evervision_vgg804821 = {
+	.timings = &evervision_vgg804821_timing,
+	.num_timings = 1,
+	.bpc = 8,
+	.size = {
+		.width = 108,
+		.height = 64,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
+};
+
 static const struct drm_display_mode foxlink_fl500wvr00_a0t_mode = {
 	.clock = 32260,
 	.hdisplay = 800,
@@ -2586,6 +2613,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "edt,etm0700g0edh6",
 		.data = &edt_etm0700g0bdh6,
+	}, {
+		.compatible = "evervision,vgg804821",
+		.data = &evervision_vgg804821,
 	}, {
 		.compatible = "foxlink,fl500wvr00-a0t",
 		.data = &foxlink_fl500wvr00_a0t,
-- 
2.19.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/3] dt-bindings: drm/panel: simple: add Evervision VGG804821

[Sam Ravnborg]

Hi Marco.

On Thu, Jan 03, 2019 at 07:26:57PM +0100, Marco Felsch wrote:
> Add support for the Evervision VG804821 800x480 5.0" LCD TFT parallel
> panel to DRM simple panel driver.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  .../bindings/display/panel/evervision,vgg804821.txt  | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> new file mode 100644
> index 000000000000..82d22e191ac3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> @@ -0,0 +1,12 @@
> +Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
> +
> +Required properties:
> +- compatible: should be "evervision,vgg804821"
> +- power-supply: See simple-panel.txt
> +
> +Optional properties:
> +- backlight: See simple-panel.txt
> +- enable-gpios: See simple-panel.txt
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.

Other bindings just have the compatible listed and the above two lines and
do not repeat the required/optional properties.
If there is not special reason to add these they I suggest to simplify the binding.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] drm/panel: simple: Add Evervision VGG804821 pannel support

[Sam Ravnborg]

Hi Marco.

In $subject pannel => panel

Other than that, bonus points for specifying
all of .flags, .bus_format and .bus_flags

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/3] dt-bindings: drm/panel: simple: add Evervision VGG804821

[Rob Herring]

On Fri, Jan 04, 2019 at 05:38:31PM +0100, Sam Ravnborg wrote:
> Hi Marco.
> 
> On Thu, Jan 03, 2019 at 07:26:57PM +0100, Marco Felsch wrote:
> > Add support for the Evervision VG804821 800x480 5.0" LCD TFT parallel
> > panel to DRM simple panel driver.
> > 
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> >  .../bindings/display/panel/evervision,vgg804821.txt  | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> > new file mode 100644
> > index 000000000000..82d22e191ac3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> > @@ -0,0 +1,12 @@
> > +Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
> > +
> > +Required properties:
> > +- compatible: should be "evervision,vgg804821"
> > +- power-supply: See simple-panel.txt
> > +
> > +Optional properties:
> > +- backlight: See simple-panel.txt
> > +- enable-gpios: See simple-panel.txt
> > +
> > +This binding is compatible with the simple-panel binding, which is specified
> > +in simple-panel.txt in this directory.
> 
> Other bindings just have the compatible listed and the above two lines and
> do not repeat the required/optional properties.
> If there is not special reason to add these they I suggest to simplify the binding.

It is not sufficient to just refer to simple-panel.txt. For example, 
that doesn't convey if a panel has a single supply or multiple and the 
author just ignored supplies. Or what if a panel doesn't have a 
backlight or enable line?

Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/3] dt-bindings: add vendor prefix for Evervision Electronics

[Rob Herring]

On Thu,  3 Jan 2019 19:26:56 +0100, Marco Felsch wrote:
> Evervision Electronics is a panel manufacturer from Taipei.
> http://www.evervisionlcd.com/index.php?lang=en
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/3] dt-bindings: drm/panel: simple: add Evervision VGG804821

[Rob Herring]

On Thu,  3 Jan 2019 19:26:57 +0100, Marco Felsch wrote:
> Add support for the Evervision VG804821 800x480 5.0" LCD TFT parallel
> panel to DRM simple panel driver.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  .../bindings/display/panel/evervision,vgg804821.txt  | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/3] dt-bindings: drm/panel: simple: add Evervision VGG804821

[Sam Ravnborg]

Hi Rob.

> > > +++ b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> > > @@ -0,0 +1,12 @@
> > > +Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
> > > +
> > > +Required properties:
> > > +- compatible: should be "evervision,vgg804821"
> > > +- power-supply: See simple-panel.txt
> > > +
> > > +Optional properties:
> > > +- backlight: See simple-panel.txt
> > > +- enable-gpios: See simple-panel.txt
> > > +
> > > +This binding is compatible with the simple-panel binding, which is specified
> > > +in simple-panel.txt in this directory.
> > 
> > Other bindings just have the compatible listed and the above two lines and
> > do not repeat the required/optional properties.
> > If there is not special reason to add these they I suggest to simplify the binding.
> 
> It is not sufficient to just refer to simple-panel.txt. For example, 
> that doesn't convey if a panel has a single supply or multiple and the 
> author just ignored supplies. Or what if a panel doesn't have a 
> backlight or enable line?

Thanks, noted.
I have a few bindings awaiting to be sent that will need a small update.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] drm/panel: simple: Add Evervision VGG804821 pannel support

[Marco Felsch]

Hi Sam,

On 19-01-04 17:40, Sam Ravnborg wrote:
> Hi Marco.
> 
> In $subject pannel => panel

Thanks for covering that, Thierry can you fix this inline?

Regards,
Marco

> 
> Other than that, bonus points for specifying
> all of .flags, .bus_format and .bus_flags
> 
> 	Sam
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] drm/panel: simple: Add Evervision VGG804821 pannel support

[Marco Felsch]

Hi Thierry,

gentle ping.

On 19-01-14 11:28, Marco Felsch wrote:
> Hi Sam,
> 
> On 19-01-04 17:40, Sam Ravnborg wrote:
> > Hi Marco.
> > 
> > In $subject pannel => panel
> 
> Thanks for covering that, Thierry can you fix this inline?

Is that doable for you?

Regards,

	Marco

> Regards,
> Marco
> 
> > 
> > Other than that, bonus points for specifying
> > all of .flags, .bus_format and .bus_flags
> > 
> > 	Sam
> > 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] drm/panel: simple: Add Evervision VGG804821 pannel support

[Sam Ravnborg]

Hi Marco

On Mon, Apr 15, 2019 at 05:46:48PM +0200, Marco Felsch wrote:
> Hi Thierry,
> 
> gentle ping.
> 
> On 19-01-14 11:28, Marco Felsch wrote:
> > Hi Sam,
> > 
> > On 19-01-04 17:40, Sam Ravnborg wrote:
> > > Hi Marco.
> > > 
> > > In $subject pannel => panel
> > 
> > Thanks for covering that, Thierry can you fix this inline?
> 
> Is that doable for you?

If you resend I will apply. I deleted the original patch-set.
This will allow me to try my first commit to drm-misc :-)

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] drm/panel: simple: Add Evervision VGG804821 pannel support

[Marco Felsch]

Hi Sam,

thanks for your fast response =)

On 19-04-15 18:10, Sam Ravnborg wrote:
> Hi Marco
> 
> On Mon, Apr 15, 2019 at 05:46:48PM +0200, Marco Felsch wrote:
> > Hi Thierry,
> > 
> > gentle ping.
> > 
> > On 19-01-14 11:28, Marco Felsch wrote:
> > > Hi Sam,
> > > 
> > > On 19-01-04 17:40, Sam Ravnborg wrote:
> > > > Hi Marco.
> > > > 
> > > > In $subject pannel => panel
> > > 
> > > Thanks for covering that, Thierry can you fix this inline?
> > 
> > Is that doable for you?
> 
> If you resend I will apply. I deleted the original patch-set.
> This will allow me to try my first commit to drm-misc :-)

Okay, let me resend it as v2 with your integrated comment.

Regards,

	Marco

> 
> 	Sam
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel