* [PATCH v2 1/3] dt-bindings: add vendor prefix for logic technologies limited
@ 2019-10-27 14:26 Marcel Ziswiler
2019-10-27 14:26 ` [PATCH v2 2/3] drm/panel: simple: add display timings for logic technologies displays Marcel Ziswiler
2019-10-27 14:26 ` [PATCH v2 3/3] dt-bindings: display: panel: add bindings " Marcel Ziswiler
0 siblings, 2 replies; 10+ messages in thread
From: Marcel Ziswiler @ 2019-10-27 14:26 UTC (permalink / raw)
To: dri-devel
Cc: devicetree, info, j.bauer, linux-arm-kernel, linux-kernel,
Marcel Ziswiler, Philippe Schenker, Rob Herring, Heiko Stuebner,
Icenowy Zheng, Laurent Pinchart, Mark Rutland, Maxime Ripard,
Rob Herring, Shawn Guo
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Add vendor prefix for Logic Technologies Limited [1] which is a Chinese
display manufacturer e.g. distributed by German Endrich Bauelemente
Vertriebs GmbH [2].
[1] https://logictechno.com/contact-us/
[2] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Reviewed-by: Philippe Schenker <philippe.schenker@toradex.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes in v2:
- Added Philippe's reviewed-by.
- Added Rob's acked-by.
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 9a8495e39c5b..94aea715d4e2 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -543,6 +543,8 @@ patternProperties:
description: Linear Technology Corporation
"^logicpd,.*":
description: Logic PD, Inc.
+ "^logictechno,.*":
+ description: Logic Technologies Limited
"^longcheer,.*":
description: Longcheer Technology (Shanghai) Co., Ltd.
"^lsi,.*":
--
2.21.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 2/3] drm/panel: simple: add display timings for logic technologies displays
2019-10-27 14:26 [PATCH v2 1/3] dt-bindings: add vendor prefix for logic technologies limited Marcel Ziswiler
@ 2019-10-27 14:26 ` Marcel Ziswiler
2019-10-27 14:26 ` [PATCH v2 3/3] dt-bindings: display: panel: add bindings " Marcel Ziswiler
1 sibling, 0 replies; 10+ messages in thread
From: Marcel Ziswiler @ 2019-10-27 14:26 UTC (permalink / raw)
To: dri-devel
Cc: devicetree, Marcel Ziswiler, j.bauer, linux-kernel,
Philippe Schenker, info, Thierry Reding, David Airlie,
Daniel Vetter, Sam Ravnborg, linux-arm-kernel
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Add display timings for the following 3 display panels manufactured by
Logic Technologies Limited:
- LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display
7" Parallel [1]
- LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7"
Parallel [2]
- LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display
10.1" LVDS [3]
Those panels may also be distributed by Endrich Bauelemente Vertriebs
GmbH [4].
[1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
[2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
[3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
[4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Reviewed-by: Philippe Schenker <philippe.schenker@toradex.com>
---
Changes in v2:
- Added Philippe's reviewed-by.
drivers/gpu/drm/panel/panel-simple.c | 65 ++++++++++++++++++++++++++++
1 file changed, 65 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 5d487686d25c..546770116096 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2047,6 +2047,62 @@ static const struct panel_desc lg_lp129qe = {
},
};
+static const struct display_timing logictechno_lt161010_2nh_timing = {
+ .pixelclock = { 26400000, 33300000, 46800000 },
+ .hactive = { 800, 800, 800 },
+ .hfront_porch = { 16, 210, 354 },
+ .hback_porch = { 46, 46, 46 },
+ .hsync_len = { 1, 20, 40 },
+ .vactive = { 480, 480, 480 },
+ .vfront_porch = { 7, 22, 147 },
+ .vback_porch = { 23, 23, 23 },
+ .vsync_len = { 1, 10, 20 },
+ .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+ DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
+ DISPLAY_FLAGS_SYNC_POSEDGE,
+};
+
+static const struct panel_desc logictechno_lt161010_2nh = {
+ .timings = &logictechno_lt161010_2nh_timing,
+ .num_timings = 1,
+ .size = {
+ .width = 154,
+ .height = 86,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH |
+ DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE |
+ DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE,
+};
+
+static const struct display_timing logictechno_lt170410_2whc_timing = {
+ .pixelclock = { 68900000, 71100000, 7340000 },
+ .hactive = { 1280, 1280, 1280 },
+ .hfront_porch = { 23, 60, 71 },
+ .hback_porch = { 23, 60, 71 },
+ .hsync_len = { 15, 40, 47 },
+ .vactive = { 800, 800, 800 },
+ .vfront_porch = { 5, 7, 10 },
+ .vback_porch = { 5, 7, 10 },
+ .vsync_len = { 6, 9, 12 },
+ .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+ DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
+ DISPLAY_FLAGS_SYNC_POSEDGE,
+};
+
+static const struct panel_desc logictechno_lt170410_2whc = {
+ .timings = &logictechno_lt170410_2whc_timing,
+ .num_timings = 1,
+ .size = {
+ .width = 217,
+ .height = 136,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH |
+ DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE |
+ DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE,
+};
+
static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
.clock = 30400,
.hdisplay = 800,
@@ -3287,6 +3343,15 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "lg,lp129qe",
.data = &lg_lp129qe,
+ }, {
+ .compatible = "logictechno,lt161010-2nhc",
+ .data = &logictechno_lt161010_2nh,
+ }, {
+ .compatible = "logictechno,lt161010-2nhr",
+ .data = &logictechno_lt161010_2nh,
+ }, {
+ .compatible = "logictechno,lt170410-2whc",
+ .data = &logictechno_lt170410_2whc,
}, {
.compatible = "mitsubishi,aa070mc01-ca1",
.data = &mitsubishi_aa070mc01,
--
2.21.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays
2019-10-27 14:26 [PATCH v2 1/3] dt-bindings: add vendor prefix for logic technologies limited Marcel Ziswiler
2019-10-27 14:26 ` [PATCH v2 2/3] drm/panel: simple: add display timings for logic technologies displays Marcel Ziswiler
@ 2019-10-27 14:26 ` Marcel Ziswiler
2019-10-30 14:28 ` Rob Herring
2019-10-30 14:29 ` Rob Herring
1 sibling, 2 replies; 10+ messages in thread
From: Marcel Ziswiler @ 2019-10-27 14:26 UTC (permalink / raw)
To: dri-devel
Cc: devicetree, info, j.bauer, linux-arm-kernel, linux-kernel,
Marcel Ziswiler, Daniel Vetter, David Airlie, Mark Rutland,
Rob Herring, Sam Ravnborg, Thierry Reding
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Add bindings for the following 3 previously added display panels
manufactured by Logic Technologies Limited:
- LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display
7" Parallel [1]
- LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7"
Parallel [2]
- LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display
10.1" LVDS [3]
Those panels may also be distributed by Endrich Bauelemente Vertriebs
GmbH [4].
[1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
[2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
[3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
[4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
Changes in v2:
- New patch adding display panel bindings as well as suggested by Rob.
.../panel/logictechno,lt161010-2nhc.yaml | 44 +++++++++++++++++++
.../panel/logictechno,lt161010-2nhr.yaml | 44 +++++++++++++++++++
.../panel/logictechno,lt170410-2whc.yaml | 44 +++++++++++++++++++
3 files changed, 132 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml b/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
new file mode 100644
index 000000000000..0dfe94d38a47
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/logictechno,lt161010-2nhc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Logic Technologies LT161010-2NHC 7" WVGA TFT Cap Touch Module
+
+maintainers:
+ - Marcel Ziswiler <marcel.ziswiler@toradex.com>
+ - Thierry Reding <treding@nvidia.com>
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ const: logictechno,lt161010-2nhc
+
+ power-supply: true
+ enable-gpios: true
+ backlight: true
+ port: true
+
+required:
+ - compatible
+
+additionalProperties: false
+
+examples:
+ - |
+ panel_rgb: panel {
+ compatible = "logictechno,lt161010-2nhc";
+ backlight = <&backlight>;
+ power-supply = <®_3v3>;
+
+ port {
+ panel_in_rgb: endpoint {
+ remote-endpoint = <&controller_out_rgb>;
+ };
+ };
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml b/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
new file mode 100644
index 000000000000..ffc97529b068
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/logictechno,lt161010-2nhr.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Logic Technologies LT161010-2NHR 7" WVGA TFT Resistive Touch Module
+
+maintainers:
+ - Marcel Ziswiler <marcel.ziswiler@toradex.com>
+ - Thierry Reding <treding@nvidia.com>
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ const: logictechno,lt161010-2nhr
+
+ power-supply: true
+ enable-gpios: true
+ backlight: true
+ port: true
+
+required:
+ - compatible
+
+additionalProperties: false
+
+examples:
+ - |
+ panel_rgb: panel {
+ compatible = "logictechno,lt161010-2nhr";
+ backlight = <&backlight>;
+ power-supply = <®_3v3>;
+
+ port {
+ panel_in_rgb: endpoint {
+ remote-endpoint = <&controller_out_rgb>;
+ };
+ };
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml b/Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml
new file mode 100644
index 000000000000..3606f7fe0dd0
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/logictechno,lt170410-2whc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Logic Technologies LT170410-2WHC 10.1" 1280x800 IPS TFT Cap Touch Module
+
+maintainers:
+ - Marcel Ziswiler <marcel.ziswiler@toradex.com>
+ - Thierry Reding <treding@nvidia.com>
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ const: logictechno,lt170410-2whc
+
+ power-supply: true
+ enable-gpios: true
+ backlight: true
+ port: true
+
+required:
+ - compatible
+
+additionalProperties: false
+
+examples:
+ - |
+ lvds_panel: panel {
+ compatible = "logictechno,lt170410-2whc";
+ backlight = <&backlight>;
+ power-supply = <®_3v3>;
+
+ port {
+ panel_in_lvds: endpoint {
+ remote-endpoint = <&controller_out_lvds>;
+ };
+ };
+ };
+
+...
--
2.21.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays
2019-10-27 14:26 ` [PATCH v2 3/3] dt-bindings: display: panel: add bindings " Marcel Ziswiler
@ 2019-10-30 14:28 ` Rob Herring
2019-10-30 14:28 ` Rob Herring
2020-01-19 21:25 ` Marcel Ziswiler
2019-10-30 14:29 ` Rob Herring
1 sibling, 2 replies; 10+ messages in thread
From: Rob Herring @ 2019-10-30 14:28 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: dri-devel, devicetree, info, j.bauer, linux-arm-kernel,
linux-kernel, Marcel Ziswiler, Daniel Vetter, David Airlie,
Mark Rutland, Sam Ravnborg, Thierry Reding
On Sun, Oct 27, 2019 at 03:26:09PM +0100, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Add bindings for the following 3 previously added display panels
> manufactured by Logic Technologies Limited:
>
> - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display
> 7" Parallel [1]
> - LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7"
> Parallel [2]
> - LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display
> 10.1" LVDS [3]
>
> Those panels may also be distributed by Endrich Bauelemente Vertriebs
> GmbH [4].
>
> [1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
> [2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
> [3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
> [4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> Changes in v2:
> - New patch adding display panel bindings as well as suggested by Rob.
>
> .../panel/logictechno,lt161010-2nhc.yaml | 44 +++++++++++++++++++
> .../panel/logictechno,lt161010-2nhr.yaml | 44 +++++++++++++++++++
> .../panel/logictechno,lt170410-2whc.yaml | 44 +++++++++++++++++++
> 3 files changed, 132 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
> create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
> create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml
I would just put these into 1 document as the compatible is the only
difference. Either way:
Reviewed-by: Rob Herring <robh@kernel.org>
Rob
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays
2019-10-30 14:28 ` Rob Herring
@ 2019-10-30 14:28 ` Rob Herring
2020-01-19 21:25 ` Marcel Ziswiler
1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring @ 2019-10-30 14:28 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: Mark Rutland, devicetree, Marcel Ziswiler, j.bauer, linux-kernel,
dri-devel, David Airlie, info, Thierry Reding, Sam Ravnborg,
linux-arm-kernel
On Sun, Oct 27, 2019 at 03:26:09PM +0100, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Add bindings for the following 3 previously added display panels
> manufactured by Logic Technologies Limited:
>
> - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display
> 7" Parallel [1]
> - LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7"
> Parallel [2]
> - LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display
> 10.1" LVDS [3]
>
> Those panels may also be distributed by Endrich Bauelemente Vertriebs
> GmbH [4].
>
> [1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
> [2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
> [3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
> [4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> Changes in v2:
> - New patch adding display panel bindings as well as suggested by Rob.
>
> .../panel/logictechno,lt161010-2nhc.yaml | 44 +++++++++++++++++++
> .../panel/logictechno,lt161010-2nhr.yaml | 44 +++++++++++++++++++
> .../panel/logictechno,lt170410-2whc.yaml | 44 +++++++++++++++++++
> 3 files changed, 132 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
> create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
> create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml
I would just put these into 1 document as the compatible is the only
difference. Either way:
Reviewed-by: Rob Herring <robh@kernel.org>
Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays
2019-10-27 14:26 ` [PATCH v2 3/3] dt-bindings: display: panel: add bindings " Marcel Ziswiler
2019-10-30 14:28 ` Rob Herring
@ 2019-10-30 14:29 ` Rob Herring
2019-10-30 14:29 ` Rob Herring
2020-01-19 21:27 ` Marcel Ziswiler
1 sibling, 2 replies; 10+ messages in thread
From: Rob Herring @ 2019-10-30 14:29 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: dri-devel, devicetree, info, j.bauer, linux-arm-kernel,
linux-kernel, Marcel Ziswiler, Daniel Vetter, David Airlie,
Mark Rutland, Sam Ravnborg, Thierry Reding
On Sun, Oct 27, 2019 at 03:26:09PM +0100, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Add bindings for the following 3 previously added display panels
> manufactured by Logic Technologies Limited:
>
> - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display
> 7" Parallel [1]
> - LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7"
> Parallel [2]
> - LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display
> 10.1" LVDS [3]
>
> Those panels may also be distributed by Endrich Bauelemente Vertriebs
> GmbH [4].
>
> [1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
> [2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
> [3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
> [4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> Changes in v2:
> - New patch adding display panel bindings as well as suggested by Rob.
>
> .../panel/logictechno,lt161010-2nhc.yaml | 44 +++++++++++++++++++
> .../panel/logictechno,lt161010-2nhr.yaml | 44 +++++++++++++++++++
> .../panel/logictechno,lt170410-2whc.yaml | 44 +++++++++++++++++++
> 3 files changed, 132 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
> create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
> create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml b/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
> new file mode 100644
> index 000000000000..0dfe94d38a47
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: GPL-2.0
Except the license for new bindings should be:
(GPL-2.0-only OR BSD-2-Clause)
Rob
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays
2019-10-30 14:29 ` Rob Herring
@ 2019-10-30 14:29 ` Rob Herring
2020-01-19 21:27 ` Marcel Ziswiler
1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring @ 2019-10-30 14:29 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: Mark Rutland, devicetree, Marcel Ziswiler, j.bauer, linux-kernel,
dri-devel, David Airlie, info, Thierry Reding, Sam Ravnborg,
linux-arm-kernel
On Sun, Oct 27, 2019 at 03:26:09PM +0100, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Add bindings for the following 3 previously added display panels
> manufactured by Logic Technologies Limited:
>
> - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display
> 7" Parallel [1]
> - LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7"
> Parallel [2]
> - LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display
> 10.1" LVDS [3]
>
> Those panels may also be distributed by Endrich Bauelemente Vertriebs
> GmbH [4].
>
> [1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
> [2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
> [3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
> [4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> Changes in v2:
> - New patch adding display panel bindings as well as suggested by Rob.
>
> .../panel/logictechno,lt161010-2nhc.yaml | 44 +++++++++++++++++++
> .../panel/logictechno,lt161010-2nhr.yaml | 44 +++++++++++++++++++
> .../panel/logictechno,lt170410-2whc.yaml | 44 +++++++++++++++++++
> 3 files changed, 132 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
> create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
> create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml b/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
> new file mode 100644
> index 000000000000..0dfe94d38a47
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: GPL-2.0
Except the license for new bindings should be:
(GPL-2.0-only OR BSD-2-Clause)
Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays
2019-10-30 14:28 ` Rob Herring
2019-10-30 14:28 ` Rob Herring
@ 2020-01-19 21:25 ` Marcel Ziswiler
2020-01-19 21:38 ` Sam Ravnborg
1 sibling, 1 reply; 10+ messages in thread
From: Marcel Ziswiler @ 2020-01-19 21:25 UTC (permalink / raw)
To: robh
Cc: mark.rutland, devicetree, airlied, j.bauer, linux-kernel,
dri-devel, info, thierry.reding, sam, linux-arm-kernel
Sorry, just noticed that this has not gone through yet.
On Wed, 2019-10-30 at 09:28 -0500, Rob Herring wrote:
> On Sun, Oct 27, 2019 at 03:26:09PM +0100, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > Add bindings for the following 3 previously added display panels
> > manufactured by Logic Technologies Limited:
> >
> > - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch
> > Display
> > 7" Parallel [1]
> > - LT161010-2NHR e.g. as found in the Toradex Resistive Touch
> > Display 7"
> > Parallel [2]
> > - LT170410-2WHC e.g. as found in the Toradex Capacitive Touch
> > Display
> > 10.1" LVDS [3]
> >
> > Those panels may also be distributed by Endrich Bauelemente
> > Vertriebs
> > GmbH [4].
> >
> > [1]
> > https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
> > [2]
> > https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
> > [3]
> > https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
> > [4]
> > https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
> >
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > ---
> >
> > Changes in v2:
> > - New patch adding display panel bindings as well as suggested by
> > Rob.
> >
> > .../panel/logictechno,lt161010-2nhc.yaml | 44
> > +++++++++++++++++++
> > .../panel/logictechno,lt161010-2nhr.yaml | 44
> > +++++++++++++++++++
> > .../panel/logictechno,lt170410-2whc.yaml | 44
> > +++++++++++++++++++
> > 3 files changed, 132 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/display/panel/logictechno,lt16101
> > 0-2nhc.yaml
> > create mode 100644
> > Documentation/devicetree/bindings/display/panel/logictechno,lt16101
> > 0-2nhr.yaml
> > create mode 100644
> > Documentation/devicetree/bindings/display/panel/logictechno,lt17041
> > 0-2whc.yaml
>
> I would just put these into 1 document as the compatible is the only
> difference.
No, not quite just the compatible are different as the first and last
panel feature capacitive touch while the middle one is resistive and
the first two panels are parallel RGB ones while the last one is an
LVDS panel.
> Either way:
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays
2019-10-30 14:29 ` Rob Herring
2019-10-30 14:29 ` Rob Herring
@ 2020-01-19 21:27 ` Marcel Ziswiler
1 sibling, 0 replies; 10+ messages in thread
From: Marcel Ziswiler @ 2020-01-19 21:27 UTC (permalink / raw)
To: robh
Cc: mark.rutland, devicetree, airlied, j.bauer, linux-kernel,
dri-devel, info, thierry.reding, sam, linux-arm-kernel
On Wed, 2019-10-30 at 09:29 -0500, Rob Herring wrote:
> On Sun, Oct 27, 2019 at 03:26:09PM +0100, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > Add bindings for the following 3 previously added display panels
> > manufactured by Logic Technologies Limited:
> >
> > - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch
> > Display
> > 7" Parallel [1]
> > - LT161010-2NHR e.g. as found in the Toradex Resistive Touch
> > Display 7"
> > Parallel [2]
> > - LT170410-2WHC e.g. as found in the Toradex Capacitive Touch
> > Display
> > 10.1" LVDS [3]
> >
> > Those panels may also be distributed by Endrich Bauelemente
> > Vertriebs
> > GmbH [4].
> >
> > [1]
> > https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
> > [2]
> > https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
> > [3]
> > https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
> > [4]
> > https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
> >
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > ---
> >
> > Changes in v2:
> > - New patch adding display panel bindings as well as suggested by
> > Rob.
> >
> > .../panel/logictechno,lt161010-2nhc.yaml | 44
> > +++++++++++++++++++
> > .../panel/logictechno,lt161010-2nhr.yaml | 44
> > +++++++++++++++++++
> > .../panel/logictechno,lt170410-2whc.yaml | 44
> > +++++++++++++++++++
> > 3 files changed, 132 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/display/panel/logictechno,lt16101
> > 0-2nhc.yaml
> > create mode 100644
> > Documentation/devicetree/bindings/display/panel/logictechno,lt16101
> > 0-2nhr.yaml
> > create mode 100644
> > Documentation/devicetree/bindings/display/panel/logictechno,lt17041
> > 0-2whc.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/panel/logictechno,lt161
> > 010-2nhc.yaml
> > b/Documentation/devicetree/bindings/display/panel/logictechno,lt161
> > 010-2nhc.yaml
> > new file mode 100644
> > index 000000000000..0dfe94d38a47
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/display/panel/logictechno,lt161
> > 010-2nhc.yaml
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: GPL-2.0
>
> Except the license for new bindings should be:
>
> (GPL-2.0-only OR BSD-2-Clause)
OK, will send a v3 shortly.
> Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays
2020-01-19 21:25 ` Marcel Ziswiler
@ 2020-01-19 21:38 ` Sam Ravnborg
0 siblings, 0 replies; 10+ messages in thread
From: Sam Ravnborg @ 2020-01-19 21:38 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: mark.rutland, devicetree, airlied, j.bauer, linux-kernel,
dri-devel, info, thierry.reding, linux-arm-kernel
Hi Marcel.
On Sun, Jan 19, 2020 at 09:25:02PM +0000, Marcel Ziswiler wrote:
> Sorry, just noticed that this has not gone through yet.
>
> On Wed, 2019-10-30 at 09:28 -0500, Rob Herring wrote:
> > On Sun, Oct 27, 2019 at 03:26:09PM +0100, Marcel Ziswiler wrote:
> > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > >
> > > Add bindings for the following 3 previously added display panels
> > > manufactured by Logic Technologies Limited:
> > >
> > > - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch
> > > Display
> > > 7" Parallel [1]
> > > - LT161010-2NHR e.g. as found in the Toradex Resistive Touch
> > > Display 7"
> > > Parallel [2]
> > > - LT170410-2WHC e.g. as found in the Toradex Capacitive Touch
> > > Display
> > > 10.1" LVDS [3]
> > >
> > > Those panels may also be distributed by Endrich Bauelemente
> > > Vertriebs
> > > GmbH [4].
> > >
> > > [1]
> > > https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
> > > [2]
> > > https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
> > > [3]
> > > https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
> > > [4]
> > > https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
> > >
> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > >
> > > ---
> > >
> > > Changes in v2:
> > > - New patch adding display panel bindings as well as suggested by
> > > Rob.
> > >
> > > .../panel/logictechno,lt161010-2nhc.yaml | 44
> > > +++++++++++++++++++
> > > .../panel/logictechno,lt161010-2nhr.yaml | 44
> > > +++++++++++++++++++
> > > .../panel/logictechno,lt170410-2whc.yaml | 44
> > > +++++++++++++++++++
> > > 3 files changed, 132 insertions(+)
> > > create mode 100644
> > > Documentation/devicetree/bindings/display/panel/logictechno,lt16101
> > > 0-2nhc.yaml
> > > create mode 100644
> > > Documentation/devicetree/bindings/display/panel/logictechno,lt16101
> > > 0-2nhr.yaml
> > > create mode 100644
> > > Documentation/devicetree/bindings/display/panel/logictechno,lt17041
> > > 0-2whc.yaml
> >
> > I would just put these into 1 document as the compatible is the only
> > difference.
>
> No, not quite just the compatible are different as the first and last
> panel feature capacitive touch while the middle one is resistive and
> the first two panels are parallel RGB ones while the last one is an
> LVDS panel.
We have recently introduced panel-simple.yaml.
This is for dumb panels - where some of your panels could be candidates.
Please see the file in drm-misc-next, which is also where we will apply
you patch in the end.
So base the patch on drm-misc-next so we do not get conflicts when applying.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-01-20 8:59 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-27 14:26 [PATCH v2 1/3] dt-bindings: add vendor prefix for logic technologies limited Marcel Ziswiler
2019-10-27 14:26 ` [PATCH v2 2/3] drm/panel: simple: add display timings for logic technologies displays Marcel Ziswiler
2019-10-27 14:26 ` [PATCH v2 3/3] dt-bindings: display: panel: add bindings " Marcel Ziswiler
2019-10-30 14:28 ` Rob Herring
2019-10-30 14:28 ` Rob Herring
2020-01-19 21:25 ` Marcel Ziswiler
2020-01-19 21:38 ` Sam Ravnborg
2019-10-30 14:29 ` Rob Herring
2019-10-30 14:29 ` Rob Herring
2020-01-19 21:27 ` Marcel Ziswiler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).