dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: zhengbin <zhengbin13@huawei.com>
To: <alexander.deucher@amd.com>, <christian.koenig@amd.com>,
	<David1.Zhou@amd.com>, <airlied@linux.ie>, <daniel@ffwll.ch>,
	<amd-gfx@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>
Cc: zhengbin13@huawei.com
Subject: [PATCH 3/6] drm/radeon: remove set but not used variable 'dig_connector'
Date: Fri, 15 Nov 2019 20:12:57 +0800	[thread overview]
Message-ID: <1573819980-54523-4-git-send-email-zhengbin13@huawei.com> (raw)
Message-ID: <20191115121257.r_SNeCF-sXhZ500RMe8wV4jtROJUooZK2tm_-VEjfmU@z> (raw)
In-Reply-To: <1573819980-54523-1-git-send-email-zhengbin13@huawei.com>

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/radeon/atombios_dp.c: In function radeon_dp_get_panel_mode:
drivers/gpu/drm/radeon/atombios_dp.c:415:36: warning: variable dig_connector set but not used [-Wunused-but-set-variable]

It is not used since commit 379dfc25e257 ("drm/radeon/dp:
switch to the common i2c over aux code")

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/radeon/atombios_dp.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/radeon/atombios_dp.c b/drivers/gpu/drm/radeon/atombios_dp.c
index 6f38375..911735f 100644
--- a/drivers/gpu/drm/radeon/atombios_dp.c
+++ b/drivers/gpu/drm/radeon/atombios_dp.c
@@ -412,7 +412,6 @@ int radeon_dp_get_panel_mode(struct drm_encoder *encoder,
 	struct drm_device *dev = encoder->dev;
 	struct radeon_device *rdev = dev->dev_private;
 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
-	struct radeon_connector_atom_dig *dig_connector;
 	int panel_mode = DP_PANEL_MODE_EXTERNAL_DP_MODE;
 	u16 dp_bridge = radeon_connector_encoder_get_dp_bridge_encoder_id(connector);
 	u8 tmp;
@@ -423,8 +422,6 @@ int radeon_dp_get_panel_mode(struct drm_encoder *encoder,
 	if (!radeon_connector->con_priv)
 		return panel_mode;

-	dig_connector = radeon_connector->con_priv;
-
 	if (dp_bridge != ENCODER_OBJECT_ID_NONE) {
 		/* DP bridge chips */
 		if (drm_dp_dpcd_readb(&radeon_connector->ddc_bus->aux,
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-11-17 11:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 12:12 [PATCH 0/6] drm/radeon: remove some set but not used variables zhengbin
2019-11-15 12:12 ` zhengbin
     [not found] ` <1573819980-54523-1-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2019-11-15 12:12   ` [PATCH 1/6] drm/radeon: remove set but not used variable 'size', 'relocs_chunk' zhengbin
2019-11-15 12:12     ` zhengbin
2019-11-15 12:12   ` [PATCH 2/6] drm/radeon: remove set but not used variable 'backbias_response_time' zhengbin
2019-11-15 12:12     ` zhengbin
2019-11-15 12:12   ` zhengbin [this message]
2019-11-15 12:12     ` [PATCH 3/6] drm/radeon: remove set but not used variable 'dig_connector' zhengbin
2019-11-15 12:12   ` [PATCH 4/6] drm/radeon: remove set but not used variable 'radeon_connector' zhengbin
2019-11-15 12:12     ` zhengbin
2019-11-15 12:12   ` [PATCH 5/6] drm/radeon: remove set but not used variable 'blocks' zhengbin
2019-11-15 12:12     ` zhengbin
2019-11-15 12:13   ` [PATCH 6/6] drm/radeon: remove set but not used variable 'tv_pll_cntl1' zhengbin
2019-11-15 12:13     ` zhengbin
2019-11-18 17:14   ` [PATCH 0/6] drm/radeon: remove some set but not used variables Alex Deucher
2019-11-18 17:14     ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1573819980-54523-4-git-send-email-zhengbin13@huawei.com \
    --to=zhengbin13@huawei.com \
    --cc=David1.Zhou@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).