* [PATCH] drm/amdkfd: remove set but not used variable 'top_dev'
@ 2019-11-14 3:20 zhengbin
2019-11-14 3:20 ` zhengbin
[not found] ` <1573701625-120559-1-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
0 siblings, 2 replies; 4+ messages in thread
From: zhengbin @ 2019-11-14 3:20 UTC (permalink / raw)
To: Felix.Kuehling-5C7GfCeVMHo, alexander.deucher-5C7GfCeVMHo,
christian.koenig-5C7GfCeVMHo, David1.Zhou-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: zhengbin13-hv44wF8Li93QT0dZR+AlfA
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/amdkfd/kfd_iommu.c: In function kfd_iommu_device_init:
drivers/gpu/drm/amd/amdkfd/kfd_iommu.c:65:30: warning: variable top_dev set but not used [-Wunused-but-set-variable]
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 1ae99eab34f9 ("drm/amdkfd: Initialize HSA_CAP_ATS_PRESENT capability in topology codes")
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_iommu.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c b/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
index 193e283..8d87151 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
@@ -62,9 +62,6 @@ int kfd_iommu_device_init(struct kfd_dev *kfd)
struct amd_iommu_device_info iommu_info;
unsigned int pasid_limit;
int err;
- struct kfd_topology_device *top_dev;
-
- top_dev = kfd_topology_device_by_id(kfd->id);
if (!kfd->device_info->needs_iommu_device)
return 0;
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/amdkfd: remove set but not used variable 'top_dev'
2019-11-14 3:20 [PATCH] drm/amdkfd: remove set but not used variable 'top_dev' zhengbin
@ 2019-11-14 3:20 ` zhengbin
[not found] ` <1573701625-120559-1-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
1 sibling, 0 replies; 4+ messages in thread
From: zhengbin @ 2019-11-14 3:20 UTC (permalink / raw)
To: Felix.Kuehling, alexander.deucher, christian.koenig, David1.Zhou,
airlied, daniel, amd-gfx, dri-devel
Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/amdkfd/kfd_iommu.c: In function kfd_iommu_device_init:
drivers/gpu/drm/amd/amdkfd/kfd_iommu.c:65:30: warning: variable top_dev set but not used [-Wunused-but-set-variable]
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 1ae99eab34f9 ("drm/amdkfd: Initialize HSA_CAP_ATS_PRESENT capability in topology codes")
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_iommu.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c b/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
index 193e283..8d87151 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
@@ -62,9 +62,6 @@ int kfd_iommu_device_init(struct kfd_dev *kfd)
struct amd_iommu_device_info iommu_info;
unsigned int pasid_limit;
int err;
- struct kfd_topology_device *top_dev;
-
- top_dev = kfd_topology_device_by_id(kfd->id);
if (!kfd->device_info->needs_iommu_device)
return 0;
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdkfd: remove set but not used variable 'top_dev'
[not found] ` <1573701625-120559-1-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
@ 2019-11-15 22:02 ` Felix Kuehling
2019-11-15 22:02 ` Felix Kuehling
0 siblings, 1 reply; 4+ messages in thread
From: Felix Kuehling @ 2019-11-15 22:02 UTC (permalink / raw)
To: zhengbin, alexander.deucher-5C7GfCeVMHo,
christian.koenig-5C7GfCeVMHo, David1.Zhou-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 2019-11-13 10:20 p.m., zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/amd/amdkfd/kfd_iommu.c: In function kfd_iommu_device_init:
> drivers/gpu/drm/amd/amdkfd/kfd_iommu.c:65:30: warning: variable top_dev set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 1ae99eab34f9 ("drm/amdkfd: Initialize HSA_CAP_ATS_PRESENT capability in topology codes")
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
The patch is
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
I'm applying it to amd-staging-drm-next.
Thanks,
Felix
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_iommu.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c b/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
> index 193e283..8d87151 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
> @@ -62,9 +62,6 @@ int kfd_iommu_device_init(struct kfd_dev *kfd)
> struct amd_iommu_device_info iommu_info;
> unsigned int pasid_limit;
> int err;
> - struct kfd_topology_device *top_dev;
> -
> - top_dev = kfd_topology_device_by_id(kfd->id);
>
> if (!kfd->device_info->needs_iommu_device)
> return 0;
> --
> 2.7.4
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdkfd: remove set but not used variable 'top_dev'
2019-11-15 22:02 ` Felix Kuehling
@ 2019-11-15 22:02 ` Felix Kuehling
0 siblings, 0 replies; 4+ messages in thread
From: Felix Kuehling @ 2019-11-15 22:02 UTC (permalink / raw)
To: zhengbin, alexander.deucher, christian.koenig, David1.Zhou,
airlied, daniel, amd-gfx, dri-devel
On 2019-11-13 10:20 p.m., zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/amd/amdkfd/kfd_iommu.c: In function kfd_iommu_device_init:
> drivers/gpu/drm/amd/amdkfd/kfd_iommu.c:65:30: warning: variable top_dev set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 1ae99eab34f9 ("drm/amdkfd: Initialize HSA_CAP_ATS_PRESENT capability in topology codes")
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
The patch is
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
I'm applying it to amd-staging-drm-next.
Thanks,
Felix
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_iommu.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c b/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
> index 193e283..8d87151 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
> @@ -62,9 +62,6 @@ int kfd_iommu_device_init(struct kfd_dev *kfd)
> struct amd_iommu_device_info iommu_info;
> unsigned int pasid_limit;
> int err;
> - struct kfd_topology_device *top_dev;
> -
> - top_dev = kfd_topology_device_by_id(kfd->id);
>
> if (!kfd->device_info->needs_iommu_device)
> return 0;
> --
> 2.7.4
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-15 22:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 3:20 [PATCH] drm/amdkfd: remove set but not used variable 'top_dev' zhengbin
2019-11-14 3:20 ` zhengbin
[not found] ` <1573701625-120559-1-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2019-11-15 22:02 ` Felix Kuehling
2019-11-15 22:02 ` Felix Kuehling
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).