* [PATCH] drm/v3d: add missed pm_runtime_disable
@ 2019-11-18 2:47 Chuhong Yuan
2019-11-18 2:47 ` Chuhong Yuan
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-11-18 2:47 UTC (permalink / raw)
Cc: Eric Anholt, David Airlie, Daniel Vetter, dri-devel,
linux-kernel, Chuhong Yuan
The driver forgets to call pm_runtime_disable in probe failure
and remove.
Add the missed calls to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/gpu/drm/v3d/v3d_drv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
index 3506ae2723ae..e109bb8cd67d 100644
--- a/drivers/gpu/drm/v3d/v3d_drv.c
+++ b/drivers/gpu/drm/v3d/v3d_drv.c
@@ -333,6 +333,7 @@ static int v3d_platform_drm_probe(struct platform_device *pdev)
dev_destroy:
drm_dev_put(drm);
dma_free:
+ pm_runtime_disable(dev);
dma_free_wc(dev, 4096, v3d->mmu_scratch, v3d->mmu_scratch_paddr);
dev_free:
kfree(v3d);
@@ -350,6 +351,8 @@ static int v3d_platform_drm_remove(struct platform_device *pdev)
drm_dev_put(drm);
+ pm_runtime_disable(v3d->dev);
+
dma_free_wc(v3d->dev, 4096, v3d->mmu_scratch, v3d->mmu_scratch_paddr);
return 0;
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] drm/v3d: add missed pm_runtime_disable
2019-11-18 2:47 [PATCH] drm/v3d: add missed pm_runtime_disable Chuhong Yuan
@ 2019-11-18 2:47 ` Chuhong Yuan
0 siblings, 0 replies; 2+ messages in thread
From: Chuhong Yuan @ 2019-11-18 2:47 UTC (permalink / raw)
Cc: David Airlie, Chuhong Yuan, linux-kernel, dri-devel
The driver forgets to call pm_runtime_disable in probe failure
and remove.
Add the missed calls to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/gpu/drm/v3d/v3d_drv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
index 3506ae2723ae..e109bb8cd67d 100644
--- a/drivers/gpu/drm/v3d/v3d_drv.c
+++ b/drivers/gpu/drm/v3d/v3d_drv.c
@@ -333,6 +333,7 @@ static int v3d_platform_drm_probe(struct platform_device *pdev)
dev_destroy:
drm_dev_put(drm);
dma_free:
+ pm_runtime_disable(dev);
dma_free_wc(dev, 4096, v3d->mmu_scratch, v3d->mmu_scratch_paddr);
dev_free:
kfree(v3d);
@@ -350,6 +351,8 @@ static int v3d_platform_drm_remove(struct platform_device *pdev)
drm_dev_put(drm);
+ pm_runtime_disable(v3d->dev);
+
dma_free_wc(v3d->dev, 4096, v3d->mmu_scratch, v3d->mmu_scratch_paddr);
return 0;
--
2.24.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-18 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 2:47 [PATCH] drm/v3d: add missed pm_runtime_disable Chuhong Yuan
2019-11-18 2:47 ` Chuhong Yuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).