From: Sean Paul <sean@poorly.run> To: Jani Nikula <jani.nikula@linux.intel.com> Cc: Wambui Karuga <wambui.karugax@gmail.com>, maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, hjc@rock-chips.com, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] add new DRM_DEV_WARN macro Date: Mon, 18 Nov 2019 14:24:50 -0500 [thread overview] Message-ID: <20191118192450.GA135013@art_vandelay> (raw) In-Reply-To: <8736ep1hm2.fsf@intel.com> On Fri, Nov 15, 2019 at 01:52:53PM +0200, Jani Nikula wrote: > On Thu, 14 Nov 2019, Wambui Karuga <wambui.karugax@gmail.com> wrote: > > This adds a new DRM_DEV_WARN helper macro for warnings log output that include > > device pointers. It also includes the use of the DRM_DEV_WARN macro in > > drm/rockchip to replace dev_warn. > > I'm trying to solicit new struct drm_device based logging macros, and > starting to convert to those. [1] > This sounds good to me, I'd much prefer the non-caps versions of these functions. So let's wait for those to bubble up and then convert rockchip to drm_dev_* Sean > BR, > Jani. > > > [1] http://patchwork.freedesktop.org/patch/msgid/63d1e72b99e9c13ee5b1b362a653ff9c21e19124.1572258936.git.jani.nikula@intel.com > > > > > > > > Wambui Karuga (2): > > drm/print: add DRM_DEV_WARN macro > > drm/rockchip: use DRM_DEV_WARN macro in debug output > > > > drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++- > > include/drm/drm_print.h | 9 +++++++++ > > 2 files changed, 11 insertions(+), 1 deletion(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Sean Paul, Software Engineer, Google / Chromium OS
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <sean@poorly.run> To: Jani Nikula <jani.nikula@linux.intel.com> Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, sean@poorly.run, linux-arm-kernel@lists.infradead.org, Wambui Karuga <wambui.karugax@gmail.com> Subject: Re: [PATCH 0/2] add new DRM_DEV_WARN macro Date: Mon, 18 Nov 2019 14:24:50 -0500 [thread overview] Message-ID: <20191118192450.GA135013@art_vandelay> (raw) Message-ID: <20191118192450.3fK8HY0ndSUx8cInheUsV9XhHjnPKcQDHWvnNsjZx2g@z> (raw) In-Reply-To: <8736ep1hm2.fsf@intel.com> On Fri, Nov 15, 2019 at 01:52:53PM +0200, Jani Nikula wrote: > On Thu, 14 Nov 2019, Wambui Karuga <wambui.karugax@gmail.com> wrote: > > This adds a new DRM_DEV_WARN helper macro for warnings log output that include > > device pointers. It also includes the use of the DRM_DEV_WARN macro in > > drm/rockchip to replace dev_warn. > > I'm trying to solicit new struct drm_device based logging macros, and > starting to convert to those. [1] > This sounds good to me, I'd much prefer the non-caps versions of these functions. So let's wait for those to bubble up and then convert rockchip to drm_dev_* Sean > BR, > Jani. > > > [1] http://patchwork.freedesktop.org/patch/msgid/63d1e72b99e9c13ee5b1b362a653ff9c21e19124.1572258936.git.jani.nikula@intel.com > > > > > > > > Wambui Karuga (2): > > drm/print: add DRM_DEV_WARN macro > > drm/rockchip: use DRM_DEV_WARN macro in debug output > > > > drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++- > > include/drm/drm_print.h | 9 +++++++++ > > 2 files changed, 11 insertions(+), 1 deletion(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-18 19:24 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-14 13:24 [PATCH 0/2] add new DRM_DEV_WARN macro Wambui Karuga 2019-11-14 13:24 ` Wambui Karuga 2019-11-15 11:52 ` Jani Nikula 2019-11-18 19:24 ` Sean Paul [this message] 2019-11-18 19:24 ` Sean Paul 2019-11-18 20:03 ` Daniel Vetter 2019-11-18 21:12 ` Sean Paul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191118192450.GA135013@art_vandelay \ --to=sean@poorly.run \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=hjc@rock-chips.com \ --cc=jani.nikula@linux.intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=wambui.karugax@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).