From: Rob Herring <robh@kernel.org>
To: allen <allen.chen@ite.com.tw>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Pi-Hsun Shih <pihsun@chromium.org>,
Jau-Chih Tseng <Jau-Chih.Tseng@ite.com.tw>,
David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 3/4] dt-bindings: Add binding for IT6505.
Date: Fri, 22 Nov 2019 17:57:31 -0600 [thread overview]
Message-ID: <20191122235731.GB7738@bogus> (raw)
In-Reply-To: <1573811564-320-4-git-send-email-allen.chen@ite.com.tw>
On Fri, Nov 15, 2019 at 05:52:19PM +0800, allen wrote:
> From: Allen Chen <allen.chen@ite.com.tw>
>
> Add a DT binding documentation for IT6505.
>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> ---
> .../bindings/display/bridge/ite,it6505.txt | 28 ++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
Please make this a DT schema. See
Documentation/devicetree/writing-schema.rst.
> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
> new file mode 100644
> index 00000000..72da0c4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
> @@ -0,0 +1,28 @@
> +iTE it6505 DP bridge bindings
> +
> +Required properties:
> + - compatible: "ite,it6505"
> + - reg: i2c address of the bridge
> + - ovdd-supply: I/O voltage
> + - pwr18-supply: Core voltage
> + - interrupts: interrupt specifier of INT pin
> + - reset-gpios: gpio specifier of RESET pin
> + - hpd-gpios:
> + Hotplug detect GPIO.
> + Indicates which GPIO should be used for hotplug detection
Indentation is not consistent.
> + - port@[x]: SoC specific port nodes with endpoint definitions as defined
> + in Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
You need to define what each port is. With the schema, that will be
'port@0' and 'port@1' properties.
> +
> +Example:
> + dp-bridge@5c {
> + compatible = "ite,it6505";
> + interrupts = <152 IRQ_TYPE_EDGE_RISING 152 0>;
> + reg = <0x5c>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&it6505_pins>;
> + ovdd-supply = <&mt6358_vsim1_reg>;
> + pwr18-supply = <&it6505_pp18_reg>;
> + reset-gpios = <&pio 179 1>;
> + hpd-gpios = <&pio 9 0>;
> + extcon = <&usbc_extcon>;
Not documented plus it's deprecated.
You're missing ports here and they are required.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: allen <allen.chen@ite.com.tw>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Jau-Chih Tseng <Jau-Chih.Tseng@ite.com.tw>,
David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Pi-Hsun Shih <pihsun@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 3/4] dt-bindings: Add binding for IT6505.
Date: Fri, 22 Nov 2019 17:57:31 -0600 [thread overview]
Message-ID: <20191122235731.GB7738@bogus> (raw)
Message-ID: <20191122235731.BJ6QkOSKCBWSlMIYk3SqcMTjimqUYYSqSyPQpglbH70@z> (raw)
In-Reply-To: <1573811564-320-4-git-send-email-allen.chen@ite.com.tw>
On Fri, Nov 15, 2019 at 05:52:19PM +0800, allen wrote:
> From: Allen Chen <allen.chen@ite.com.tw>
>
> Add a DT binding documentation for IT6505.
>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> ---
> .../bindings/display/bridge/ite,it6505.txt | 28 ++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
Please make this a DT schema. See
Documentation/devicetree/writing-schema.rst.
> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
> new file mode 100644
> index 00000000..72da0c4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.txt
> @@ -0,0 +1,28 @@
> +iTE it6505 DP bridge bindings
> +
> +Required properties:
> + - compatible: "ite,it6505"
> + - reg: i2c address of the bridge
> + - ovdd-supply: I/O voltage
> + - pwr18-supply: Core voltage
> + - interrupts: interrupt specifier of INT pin
> + - reset-gpios: gpio specifier of RESET pin
> + - hpd-gpios:
> + Hotplug detect GPIO.
> + Indicates which GPIO should be used for hotplug detection
Indentation is not consistent.
> + - port@[x]: SoC specific port nodes with endpoint definitions as defined
> + in Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
You need to define what each port is. With the schema, that will be
'port@0' and 'port@1' properties.
> +
> +Example:
> + dp-bridge@5c {
> + compatible = "ite,it6505";
> + interrupts = <152 IRQ_TYPE_EDGE_RISING 152 0>;
> + reg = <0x5c>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&it6505_pins>;
> + ovdd-supply = <&mt6358_vsim1_reg>;
> + pwr18-supply = <&it6505_pp18_reg>;
> + reset-gpios = <&pio 179 1>;
> + hpd-gpios = <&pio 9 0>;
> + extcon = <&usbc_extcon>;
Not documented plus it's deprecated.
You're missing ports here and they are required.
Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-22 23:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 9:52 [PATCH v4 0/4] IT6505 cover letter allen
2019-11-15 9:52 ` allen
2019-11-15 9:52 ` [PATCH v4 2/4] Revert "drm/tegra: Move drm_dp_link helpers to Tegra DRM" allen
2019-11-15 9:52 ` allen
2019-11-15 9:52 ` [PATCH v4 3/4] dt-bindings: Add binding for IT6505 allen
2019-11-15 9:52 ` allen
2019-11-22 23:57 ` Rob Herring [this message]
2019-11-22 23:57 ` Rob Herring
2019-11-15 9:52 ` [PATCH v4 4/4] drm/bridge: add it6505 driver allen
2019-11-15 9:52 ` allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122235731.GB7738@bogus \
--to=robh@kernel.org \
--cc=Jau-Chih.Tseng@ite.com.tw \
--cc=airlied@linux.ie \
--cc=allen.chen@ite.com.tw \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pihsun@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).