dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 1/3] dt-bindings: Add vendor prefix for Satoz
@ 2020-01-06 15:18 Miquel Raynal
  2020-01-06 15:18 ` [PATCH v4 2/3] dt-bindings: display: Add Satoz panel Miquel Raynal
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Miquel Raynal @ 2020-01-06 15:18 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg
  Cc: David Airlie, dri-devel, Maxime Chevallier, Paul Kocialkowski,
	Thomas Petazzoni, Miquel Raynal

Satoz is a Chinese TFT manufacturer.
Website: http://www.sat-sz.com/English/index.html

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Rob Herring <robh@kernel.org>
---

Changes since v3:
* None.

Changes since v2:
* None.

Changes since v1:
* Added Rob's Ack.

 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 967e78c5ec0a..4894c5314b49 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -819,6 +819,8 @@ patternProperties:
     description: Sancloud Ltd
   "^sandisk,.*":
     description: Sandisk Corporation
+  "^satoz,.*":
+    description: Satoz International Co., Ltd
   "^sbs,.*":
     description: Smart Battery System
   "^schindler,.*":
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v4 2/3] dt-bindings: display: Add Satoz panel
  2020-01-06 15:18 [PATCH v4 1/3] dt-bindings: Add vendor prefix for Satoz Miquel Raynal
@ 2020-01-06 15:18 ` Miquel Raynal
  2020-01-06 15:18 ` [PATCH v4 3/3] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support Miquel Raynal
  2020-01-08 21:03 ` [PATCH v4 1/3] dt-bindings: Add vendor prefix for Satoz Sam Ravnborg
  2 siblings, 0 replies; 5+ messages in thread
From: Miquel Raynal @ 2020-01-06 15:18 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg
  Cc: David Airlie, dri-devel, Maxime Chevallier, Paul Kocialkowski,
	Thomas Petazzoni, Miquel Raynal

Satoz is a Chinese TFT manufacturer.
Website: http://www.sat-sz.com/English/index.html

Add (simple) bindings for its SAT050AT40H12R2 5.0 inch LCD panel.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---

Changes since v3:
* Added the missing ".yaml" suffix in the $id.
* Removed the unnecessary "contains" assertion about the compatible.
* Added a precision : there is no public specification for this panel
  (known for the moment).
* Bindings checked with "make dt_binding_check"

Changes since v2:
* None.

Changes since v1:
* New patch

 .../display/panel/satoz,sat050at40h12r2.yaml  | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml b/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml
new file mode 100644
index 000000000000..1ad6cafc1cc1
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml
@@ -0,0 +1,26 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/satoz,sat050at40h12r2.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Satoz SAT050AT40H12R2 panel
+
+maintainers:
+  - Thierry Reding <thierry.reding@gmail.com>
+
+description: |+
+  LCD 5.0 inch 800x480 RGB panel (no public specification).
+
+  This binding is compatible with the simple-panel binding, which is specified
+  in simple-panel.txt in this directory.
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: satoz,sat050at40h12r2
+
+required:
+  - compatible
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v4 3/3] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support
  2020-01-06 15:18 [PATCH v4 1/3] dt-bindings: Add vendor prefix for Satoz Miquel Raynal
  2020-01-06 15:18 ` [PATCH v4 2/3] dt-bindings: display: Add Satoz panel Miquel Raynal
@ 2020-01-06 15:18 ` Miquel Raynal
  2020-01-08 21:03 ` [PATCH v4 1/3] dt-bindings: Add vendor prefix for Satoz Sam Ravnborg
  2 siblings, 0 replies; 5+ messages in thread
From: Miquel Raynal @ 2020-01-06 15:18 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg
  Cc: David Airlie, dri-devel, Maxime Chevallier, Paul Kocialkowski,
	Thomas Petazzoni, Miquel Raynal

Add support for the Satoz SAT050AT40H12R2 panel.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---

Changes since v3:
* Added connector type.

Changes since v2:
* Dropped two uneeded lines which would fail the build.

Changes since v1:
* Switched to display_timing's instead of display_mode.

 drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index aaa08beac13c..1aa6622abc49 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2577,6 +2577,30 @@ static const struct panel_desc samsung_ltn140at29_301 = {
 	},
 };
 
+static const struct display_timing satoz_sat050at40h12r2_timing = {
+	.pixelclock = {33300000, 33300000, 50000000},
+	.hactive = {800, 800, 800},
+	.hfront_porch = {16, 210, 354},
+	.hback_porch = {46, 46, 46},
+	.hsync_len = {1, 1, 40},
+	.vactive = {480, 480, 480},
+	.vfront_porch = {7, 22, 147},
+	.vback_porch = {23, 23, 23},
+	.vsync_len = {1, 1, 20},
+};
+
+static const struct panel_desc satoz_sat050at40h12r2 = {
+	.timings = &satoz_sat050at40h12r2_timing,
+	.num_timings = 1,
+	.bpc = 8,
+	.size = {
+		.width = 108,
+		.height = 65,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
 static const struct drm_display_mode sharp_ld_d5116z01b_mode = {
 	.clock = 168480,
 	.hdisplay = 1920,
@@ -3377,6 +3401,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "samsung,ltn140at29-301",
 		.data = &samsung_ltn140at29_301,
+	}, {
+		.compatible = "satoz,sat050at40h12r2",
+		.data = &satoz_sat050at40h12r2,
 	}, {
 		.compatible = "sharp,ld-d5116z01b",
 		.data = &sharp_ld_d5116z01b,
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v4 1/3] dt-bindings: Add vendor prefix for Satoz
  2020-01-06 15:18 [PATCH v4 1/3] dt-bindings: Add vendor prefix for Satoz Miquel Raynal
  2020-01-06 15:18 ` [PATCH v4 2/3] dt-bindings: display: Add Satoz panel Miquel Raynal
  2020-01-06 15:18 ` [PATCH v4 3/3] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support Miquel Raynal
@ 2020-01-08 21:03 ` Sam Ravnborg
  2020-01-09 18:40   ` Miquel Raynal
  2 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2020-01-08 21:03 UTC (permalink / raw)
  To: Miquel Raynal
  Cc: Thomas Petazzoni, David Airlie, dri-devel, Maxime Chevallier,
	Paul Kocialkowski, Thierry Reding

Hi Miquel.

On Mon, Jan 06, 2020 at 04:18:25PM +0100, Miquel Raynal wrote:
> Satoz is a Chinese TFT manufacturer.
> Website: http://www.sat-sz.com/English/index.html
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Acked-by: Rob Herring <robh@kernel.org>

I have applied this.
Can you please re-do patch 2/3 so the compatible is added to
panel-simple.yaml - which I just pushed to drm-misc-next.

Then we have a two-line entry rather than a whole file
as you also asked for.

	Sam

> ---
> 
> Changes since v3:
> * None.
> 
> Changes since v2:
> * None.
> 
> Changes since v1:
> * Added Rob's Ack.
> 
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 967e78c5ec0a..4894c5314b49 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -819,6 +819,8 @@ patternProperties:
>      description: Sancloud Ltd
>    "^sandisk,.*":
>      description: Sandisk Corporation
> +  "^satoz,.*":
> +    description: Satoz International Co., Ltd
>    "^sbs,.*":
>      description: Smart Battery System
>    "^schindler,.*":
> -- 
> 2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v4 1/3] dt-bindings: Add vendor prefix for Satoz
  2020-01-08 21:03 ` [PATCH v4 1/3] dt-bindings: Add vendor prefix for Satoz Sam Ravnborg
@ 2020-01-09 18:40   ` Miquel Raynal
  0 siblings, 0 replies; 5+ messages in thread
From: Miquel Raynal @ 2020-01-09 18:40 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: Thomas Petazzoni, David Airlie, dri-devel, Maxime Chevallier,
	Paul Kocialkowski, Thierry Reding

Hi Sam,

Sam Ravnborg <sam@ravnborg.org> wrote on Wed, 8 Jan 2020 22:03:56 +0100:

> Hi Miquel.
> 
> On Mon, Jan 06, 2020 at 04:18:25PM +0100, Miquel Raynal wrote:
> > Satoz is a Chinese TFT manufacturer.
> > Website: http://www.sat-sz.com/English/index.html
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > Acked-by: Rob Herring <robh@kernel.org>  
> 
> I have applied this.
> Can you please re-do patch 2/3 so the compatible is added to
> panel-simple.yaml - which I just pushed to drm-misc-next.
> 
> Then we have a two-line entry rather than a whole file
> as you also asked for.

Great! I think it's much better like this. Let's drop patch 2/3, I'm
re-sending 2/3 (updated) and 3/3 (no changes).

Thanks,
Miquèl
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-01-12 12:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-06 15:18 [PATCH v4 1/3] dt-bindings: Add vendor prefix for Satoz Miquel Raynal
2020-01-06 15:18 ` [PATCH v4 2/3] dt-bindings: display: Add Satoz panel Miquel Raynal
2020-01-06 15:18 ` [PATCH v4 3/3] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support Miquel Raynal
2020-01-08 21:03 ` [PATCH v4 1/3] dt-bindings: Add vendor prefix for Satoz Sam Ravnborg
2020-01-09 18:40   ` Miquel Raynal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).