* [PATCH] video: fbdev: nvidia: clean up indentation issues and comment block
@ 2020-01-13 14:46 ` Colin King
2020-01-15 16:19 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-01-13 14:46 UTC (permalink / raw)
To: Antonino Daplas, Bartlomiej Zolnierkiewicz, linux-fbdev, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a hunk of code that is incorrectly indented, clean up the
indentation and a comment block. Also remove block braces around a
one line statement on an if condition and add missing spaces after
if keywords.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/video/fbdev/nvidia/nvidia.c | 41 ++++++++++++++---------------
1 file changed, 20 insertions(+), 21 deletions(-)
diff --git a/drivers/video/fbdev/nvidia/nvidia.c b/drivers/video/fbdev/nvidia/nvidia.c
index c583c018304d..c24de9107958 100644
--- a/drivers/video/fbdev/nvidia/nvidia.c
+++ b/drivers/video/fbdev/nvidia/nvidia.c
@@ -168,27 +168,26 @@ static int nvidia_panel_tweak(struct nvidia_par *par,
{
int tweak = 0;
- if (par->paneltweak) {
- tweak = par->paneltweak;
- } else {
- /* begin flat panel hacks */
- /* This is unfortunate, but some chips need this register
- tweaked or else you get artifacts where adjacent pixels are
- swapped. There are no hard rules for what to set here so all
- we can do is experiment and apply hacks. */
-
- if(((par->Chipset & 0xffff) == 0x0328) && (state->bpp == 32)) {
- /* At least one NV34 laptop needs this workaround. */
- tweak = -1;
- }
-
- if((par->Chipset & 0xfff0) == 0x0310) {
- tweak = 1;
- }
- /* end flat panel hacks */
- }
-
- return tweak;
+ if (par->paneltweak) {
+ tweak = par->paneltweak;
+ } else {
+ /* Begin flat panel hacks.
+ * This is unfortunate, but some chips need this register
+ * tweaked or else you get artifacts where adjacent pixels are
+ * swapped. There are no hard rules for what to set here so all
+ * we can do is experiment and apply hacks.
+ */
+ if (((par->Chipset & 0xffff) == 0x0328) && (state->bpp == 32)) {
+ /* At least one NV34 laptop needs this workaround. */
+ tweak = -1;
+ }
+
+ if ((par->Chipset & 0xfff0) == 0x0310)
+ tweak = 1;
+ /* end flat panel hacks */
+ }
+
+ return tweak;
}
static void nvidia_screen_off(struct nvidia_par *par, int on)
--
2.24.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: nvidia: clean up indentation issues and comment block
2020-01-13 14:46 ` [PATCH] video: fbdev: nvidia: clean up indentation issues and comment block Colin King
@ 2020-01-15 16:19 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-15 16:19 UTC (permalink / raw)
To: Colin King; +Cc: linux-fbdev, kernel-janitors, dri-devel, linux-kernel
On 1/13/20 3:46 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a hunk of code that is incorrectly indented, clean up the
> indentation and a comment block. Also remove block braces around a
> one line statement on an if condition and add missing spaces after
> if keywords.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch queued for v5.6, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/nvidia/nvidia.c | 41 ++++++++++++++---------------
> 1 file changed, 20 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/video/fbdev/nvidia/nvidia.c b/drivers/video/fbdev/nvidia/nvidia.c
> index c583c018304d..c24de9107958 100644
> --- a/drivers/video/fbdev/nvidia/nvidia.c
> +++ b/drivers/video/fbdev/nvidia/nvidia.c
> @@ -168,27 +168,26 @@ static int nvidia_panel_tweak(struct nvidia_par *par,
> {
> int tweak = 0;
>
> - if (par->paneltweak) {
> - tweak = par->paneltweak;
> - } else {
> - /* begin flat panel hacks */
> - /* This is unfortunate, but some chips need this register
> - tweaked or else you get artifacts where adjacent pixels are
> - swapped. There are no hard rules for what to set here so all
> - we can do is experiment and apply hacks. */
> -
> - if(((par->Chipset & 0xffff) == 0x0328) && (state->bpp == 32)) {
> - /* At least one NV34 laptop needs this workaround. */
> - tweak = -1;
> - }
> -
> - if((par->Chipset & 0xfff0) == 0x0310) {
> - tweak = 1;
> - }
> - /* end flat panel hacks */
> - }
> -
> - return tweak;
> + if (par->paneltweak) {
> + tweak = par->paneltweak;
> + } else {
> + /* Begin flat panel hacks.
> + * This is unfortunate, but some chips need this register
> + * tweaked or else you get artifacts where adjacent pixels are
> + * swapped. There are no hard rules for what to set here so all
> + * we can do is experiment and apply hacks.
> + */
> + if (((par->Chipset & 0xffff) == 0x0328) && (state->bpp == 32)) {
> + /* At least one NV34 laptop needs this workaround. */
> + tweak = -1;
> + }
> +
> + if ((par->Chipset & 0xfff0) == 0x0310)
> + tweak = 1;
> + /* end flat panel hacks */
> + }
> +
> + return tweak;
> }
>
> static void nvidia_screen_off(struct nvidia_par *par, int on)
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-15 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200113144633eucas1p191c367b401a4c984fbf593794534aa7a@eucas1p1.samsung.com>
2020-01-13 14:46 ` [PATCH] video: fbdev: nvidia: clean up indentation issues and comment block Colin King
2020-01-15 16:19 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).