[PATCH] drm/bridge: tfp410: add pclk limits

[PATCH] drm/bridge: tfp410: add pclk limits

[Tomi Valkeinen]

Add pixel clock limits to the driver as per TFP410 datasheet: min 25MHz,
max 165MHz.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 drivers/gpu/drm/bridge/ti-tfp410.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
index 6f6d6d1e60ae..f378a8f79bcb 100644
--- a/drivers/gpu/drm/bridge/ti-tfp410.c
+++ b/drivers/gpu/drm/bridge/ti-tfp410.c
@@ -167,10 +167,20 @@ static void tfp410_disable(struct drm_bridge *bridge)
 	gpiod_set_value_cansleep(dvi->powerdown, 1);
 }
 
+static enum drm_mode_status tfp410_mode_valid(struct drm_bridge *bridge,
+					      const struct drm_display_mode *mode)
+{
+	if (mode->clock < 25000 || mode->clock > 165000)
+		return MODE_BAD;
+
+	return MODE_OK;
+}
+
 static const struct drm_bridge_funcs tfp410_bridge_funcs = {
 	.attach		= tfp410_attach,
 	.enable		= tfp410_enable,
 	.disable	= tfp410_disable,
+	.mode_valid	= tfp410_mode_valid,
 };
 
 static void tfp410_hpd_work_func(struct work_struct *work)
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: tfp410: add pclk limits

[Andrzej Hajda]

On 13.01.2020 14:45, Tomi Valkeinen wrote:
> Add pixel clock limits to the driver as per TFP410 datasheet: min 25MHz,
> max 165MHz.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

 --
Regards
Andrzej

> ---
>  drivers/gpu/drm/bridge/ti-tfp410.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
> index 6f6d6d1e60ae..f378a8f79bcb 100644
> --- a/drivers/gpu/drm/bridge/ti-tfp410.c
> +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
> @@ -167,10 +167,20 @@ static void tfp410_disable(struct drm_bridge *bridge)
>  	gpiod_set_value_cansleep(dvi->powerdown, 1);
>  }
>  
> +static enum drm_mode_status tfp410_mode_valid(struct drm_bridge *bridge,
> +					      const struct drm_display_mode *mode)
> +{
> +	if (mode->clock < 25000 || mode->clock > 165000)
> +		return MODE_BAD;
> +
> +	return MODE_OK;
> +}
> +
>  static const struct drm_bridge_funcs tfp410_bridge_funcs = {
>  	.attach		= tfp410_attach,
>  	.enable		= tfp410_enable,
>  	.disable	= tfp410_disable,
> +	.mode_valid	= tfp410_mode_valid,
>  };
>  
>  static void tfp410_hpd_work_func(struct work_struct *work)


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: tfp410: add pclk limits

[Laurent Pinchart]

Hi Tomi,

Thank you for the patch.

On Mon, Jan 13, 2020 at 03:45:28PM +0200, Tomi Valkeinen wrote:
> Add pixel clock limits to the driver as per TFP410 datasheet: min 25MHz,
> max 165MHz.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
>  drivers/gpu/drm/bridge/ti-tfp410.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
> index 6f6d6d1e60ae..f378a8f79bcb 100644
> --- a/drivers/gpu/drm/bridge/ti-tfp410.c
> +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
> @@ -167,10 +167,20 @@ static void tfp410_disable(struct drm_bridge *bridge)
>  	gpiod_set_value_cansleep(dvi->powerdown, 1);
>  }
>  
> +static enum drm_mode_status tfp410_mode_valid(struct drm_bridge *bridge,
> +					      const struct drm_display_mode *mode)
> +{
> +	if (mode->clock < 25000 || mode->clock > 165000)
> +		return MODE_BAD;

Shouldn't you return MODE_CLOCK_LOW AND MODE_CLOCK_HIGH respectively ?
Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +
> +	return MODE_OK;
> +}
> +
>  static const struct drm_bridge_funcs tfp410_bridge_funcs = {
>  	.attach		= tfp410_attach,
>  	.enable		= tfp410_enable,
>  	.disable	= tfp410_disable,
> +	.mode_valid	= tfp410_mode_valid,
>  };
>  
>  static void tfp410_hpd_work_func(struct work_struct *work)

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: tfp410: add pclk limits

[Tomi Valkeinen]

On 17/01/2020 14:53, Laurent Pinchart wrote:
> Hi Tomi,
> 
> Thank you for the patch.
> 
> On Mon, Jan 13, 2020 at 03:45:28PM +0200, Tomi Valkeinen wrote:
>> Add pixel clock limits to the driver as per TFP410 datasheet: min 25MHz,
>> max 165MHz.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> ---
>>   drivers/gpu/drm/bridge/ti-tfp410.c | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
>> index 6f6d6d1e60ae..f378a8f79bcb 100644
>> --- a/drivers/gpu/drm/bridge/ti-tfp410.c
>> +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
>> @@ -167,10 +167,20 @@ static void tfp410_disable(struct drm_bridge *bridge)
>>   	gpiod_set_value_cansleep(dvi->powerdown, 1);
>>   }
>>   
>> +static enum drm_mode_status tfp410_mode_valid(struct drm_bridge *bridge,
>> +					      const struct drm_display_mode *mode)
>> +{
>> +	if (mode->clock < 25000 || mode->clock > 165000)
>> +		return MODE_BAD;
> 
> Shouldn't you return MODE_CLOCK_LOW AND MODE_CLOCK_HIGH respectively ?
> Apart from that,
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Indeed. I'll send a v2. Thanks!

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2] drm/bridge: tfp410: add pclk limits

[Tomi Valkeinen]

Add pixel clock limits to the driver as per TFP410 datasheet: min 25MHz,
max 165MHz.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/gpu/drm/bridge/ti-tfp410.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
index 6f6d6d1e60ae..108e8cd7ab68 100644
--- a/drivers/gpu/drm/bridge/ti-tfp410.c
+++ b/drivers/gpu/drm/bridge/ti-tfp410.c
@@ -167,10 +167,23 @@ static void tfp410_disable(struct drm_bridge *bridge)
 	gpiod_set_value_cansleep(dvi->powerdown, 1);
 }
 
+static enum drm_mode_status tfp410_mode_valid(struct drm_bridge *bridge,
+					      const struct drm_display_mode *mode)
+{
+	if (mode->clock < 25000)
+		return MODE_CLOCK_LOW;
+
+	if (mode->clock > 165000)
+		return MODE_CLOCK_HIGH;
+
+	return MODE_OK;
+}
+
 static const struct drm_bridge_funcs tfp410_bridge_funcs = {
 	.attach		= tfp410_attach,
 	.enable		= tfp410_enable,
 	.disable	= tfp410_disable,
+	.mode_valid	= tfp410_mode_valid,
 };
 
 static void tfp410_hpd_work_func(struct work_struct *work)
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/bridge: tfp410: add pclk limits

[Tomi Valkeinen]

Hi Andrzej,

On 21/01/2020 11:46, Tomi Valkeinen wrote:
> Add pixel clock limits to the driver as per TFP410 datasheet: min 25MHz,
> max 165MHz.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>   drivers/gpu/drm/bridge/ti-tfp410.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
> index 6f6d6d1e60ae..108e8cd7ab68 100644
> --- a/drivers/gpu/drm/bridge/ti-tfp410.c
> +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
> @@ -167,10 +167,23 @@ static void tfp410_disable(struct drm_bridge *bridge)
>   	gpiod_set_value_cansleep(dvi->powerdown, 1);
>   }
>   
> +static enum drm_mode_status tfp410_mode_valid(struct drm_bridge *bridge,
> +					      const struct drm_display_mode *mode)
> +{
> +	if (mode->clock < 25000)
> +		return MODE_CLOCK_LOW;
> +
> +	if (mode->clock > 165000)
> +		return MODE_CLOCK_HIGH;
> +
> +	return MODE_OK;
> +}
> +
>   static const struct drm_bridge_funcs tfp410_bridge_funcs = {
>   	.attach		= tfp410_attach,
>   	.enable		= tfp410_enable,
>   	.disable	= tfp410_disable,
> +	.mode_valid	= tfp410_mode_valid,
>   };
>   
>   static void tfp410_hpd_work_func(struct work_struct *work)
> 

Is this ok to merge?

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/bridge: tfp410: add pclk limits

[Andrzej Hajda]

On 10.02.2020 09:21, Tomi Valkeinen wrote:
> Hi Andrzej,
>
> On 21/01/2020 11:46, Tomi Valkeinen wrote:
>> Add pixel clock limits to the driver as per TFP410 datasheet: min 25MHz,
>> max 165MHz.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> ---
>>   drivers/gpu/drm/bridge/ti-tfp410.c | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
>> index 6f6d6d1e60ae..108e8cd7ab68 100644
>> --- a/drivers/gpu/drm/bridge/ti-tfp410.c
>> +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
>> @@ -167,10 +167,23 @@ static void tfp410_disable(struct drm_bridge *bridge)
>>   	gpiod_set_value_cansleep(dvi->powerdown, 1);
>>   }
>>   
>> +static enum drm_mode_status tfp410_mode_valid(struct drm_bridge *bridge,
>> +					      const struct drm_display_mode *mode)
>> +{
>> +	if (mode->clock < 25000)
>> +		return MODE_CLOCK_LOW;
>> +
>> +	if (mode->clock > 165000)
>> +		return MODE_CLOCK_HIGH;
>> +
>> +	return MODE_OK;
>> +}
>> +
>>   static const struct drm_bridge_funcs tfp410_bridge_funcs = {
>>   	.attach		= tfp410_attach,
>>   	.enable		= tfp410_enable,
>>   	.disable	= tfp410_disable,
>> +	.mode_valid	= tfp410_mode_valid,
>>   };
>>   
>>   static void tfp410_hpd_work_func(struct work_struct *work)
>>
> Is this ok to merge?


Yes, If I remember you have merge rights. If not, let me know.


Andrzej


>
>   Tomi
>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/bridge: tfp410: add pclk limits

[Tomi Valkeinen]

On 10/02/2020 10:49, Andrzej Hajda wrote:

>> Is this ok to merge?
> 
> 
> Yes, If I remember you have merge rights. If not, let me know.

Yes, I have.

Generally speaking, how do you manage bridge patches? If you give reviewed-by/acked-by, does it mean 
it's good for the sender to push to drm-misc-next? Or do you usually merge bridge patches yourself?

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/bridge: tfp410: add pclk limits

[Neil Armstrong]

Hi,

On 10/02/2020 10:05, Tomi Valkeinen wrote:
> On 10/02/2020 10:49, Andrzej Hajda wrote:
> 
>>> Is this ok to merge?
>>
>>
>> Yes, If I remember you have merge rights. If not, let me know.
> 
> Yes, I have.
> 
> Generally speaking, how do you manage bridge patches? If you give reviewed-by/acked-by, does it mean it's good for the sender to push to drm-misc-next? Or do you usually merge bridge patches yourself?

If you have the merge rights and one of our r-b/a-b, you can push it yourself. Otherwise we can push them if you can't or unsure.

Neil

> 
>  Tomi
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/bridge: tfp410: add pclk limits

[Andrzej Hajda]

On 10.02.2020 10:05, Tomi Valkeinen wrote:
> On 10/02/2020 10:49, Andrzej Hajda wrote:
>
>>> Is this ok to merge?
>>
>> Yes, If I remember you have merge rights. If not, let me know.
> Yes, I have.
>
> Generally speaking, how do you manage bridge patches? If you give reviewed-by/acked-by, does it mean 
> it's good for the sender to push to drm-misc-next?


Yes, unless other reviewers found some issues :) it would be good then
to wait for their acceptance.

My bad, I did not write it in my r-b mail, I hope next it will be better :)


Regards

Andrzej


>  Or do you usually merge bridge patches yourself?
>
>   Tomi
>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel