* [PATCH V2] video: remove set but not used variable 'mach64RefFreq' @ 2020-01-20 6:33 ` yu kuai 2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: yu kuai @ 2020-01-20 6:33 UTC (permalink / raw) To: b.zolnierkie Cc: linux-fbdev, yi.zhang, linux-kernel, dri-devel, zhengbin13, yukuai3 Fixes gcc '-Wunused-but-set-variable' warning: drivers/video/fbdev/aty/mach64_gx.c: In function ‘aty_var_to_pll_8398’: drivers/video/fbdev/aty/mach64_gx.c:621:36: warning: variable ‘mach64RefFreq’ set but not used [-Wunused-but-set-variable] It is never used, and so can be removed. Signed-off-by: yu kuai <yukuai3@huawei.com> --- changes in V2: Fix the mistake that definition of 'mach64MinFreq' and 'mach64MaxFreq' was removed. drivers/video/fbdev/aty/mach64_gx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/aty/mach64_gx.c b/drivers/video/fbdev/aty/mach64_gx.c index 27cb65fa2ba2..9c37e28fb78b 100644 --- a/drivers/video/fbdev/aty/mach64_gx.c +++ b/drivers/video/fbdev/aty/mach64_gx.c @@ -618,14 +618,13 @@ static int aty_var_to_pll_8398(const struct fb_info *info, u32 vclk_per, u32 mhz100; /* in 0.01 MHz */ u32 program_bits; /* u32 post_divider; */ - u32 mach64MinFreq, mach64MaxFreq, mach64RefFreq; + u32 mach64MinFreq, mach64MaxFreq; u16 m, n, k = 0, save_m, save_n, twoToKth; /* Calculate the programming word */ mhz100 = 100000000 / vclk_per; mach64MinFreq = MIN_FREQ_2595; mach64MaxFreq = MAX_FREQ_2595; - mach64RefFreq = REF_FREQ_2595; /* 14.32 MHz */ save_m = 0; save_n = 0; -- 2.17.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] video: remove set but not used variable 'mach64RefFreq' 2020-01-20 6:33 ` [PATCH V2] video: remove set but not used variable 'mach64RefFreq' yu kuai @ 2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2020-03-02 15:42 UTC (permalink / raw) To: yu kuai; +Cc: zhengbin13, linux-fbdev, linux-kernel, dri-devel, yi.zhang On 1/20/20 7:33 AM, yu kuai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/aty/mach64_gx.c: In function ‘aty_var_to_pll_8398’: > drivers/video/fbdev/aty/mach64_gx.c:621:36: warning: variable > ‘mach64RefFreq’ set but not used [-Wunused-but-set-variable] > > It is never used, and so can be removed. > > Signed-off-by: yu kuai <yukuai3@huawei.com> Patch queued for v5.7, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > changes in V2: > Fix the mistake that definition of 'mach64MinFreq' and 'mach64MaxFreq' > was removed. > > drivers/video/fbdev/aty/mach64_gx.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/aty/mach64_gx.c b/drivers/video/fbdev/aty/mach64_gx.c > index 27cb65fa2ba2..9c37e28fb78b 100644 > --- a/drivers/video/fbdev/aty/mach64_gx.c > +++ b/drivers/video/fbdev/aty/mach64_gx.c > @@ -618,14 +618,13 @@ static int aty_var_to_pll_8398(const struct fb_info *info, u32 vclk_per, > u32 mhz100; /* in 0.01 MHz */ > u32 program_bits; > /* u32 post_divider; */ > - u32 mach64MinFreq, mach64MaxFreq, mach64RefFreq; > + u32 mach64MinFreq, mach64MaxFreq; > u16 m, n, k = 0, save_m, save_n, twoToKth; > > /* Calculate the programming word */ > mhz100 = 100000000 / vclk_per; > mach64MinFreq = MIN_FREQ_2595; > mach64MaxFreq = MAX_FREQ_2595; > - mach64RefFreq = REF_FREQ_2595; /* 14.32 MHz */ > > save_m = 0; > save_n = 0; > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-02 15:42 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <CGME20200120063426eucas1p278d9f947fad536a5af16356afddab0e4@eucas1p2.samsung.com> 2020-01-20 6:33 ` [PATCH V2] video: remove set but not used variable 'mach64RefFreq' yu kuai 2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).