* [PATCH] drm/sun4i: tcon: Support LVDS on the A33
@ 2020-02-14 12:09 Maxime Ripard
2020-02-21 3:10 ` Chen-Yu Tsai
0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2020-02-14 12:09 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard, dri-devel; +Cc: Maxime Ripard, linux-arm-kernel
The A33 TCON supports LVDS, so we can toggle the support switch.
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index fdf143042f83..14026b4fa7c7 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -1475,6 +1475,7 @@ static const struct sun4i_tcon_quirks sun8i_a33_quirks = {
.has_channel_0 = true,
.has_lvds_alt = true,
.dclk_min_div = 1,
+ .supports_lvds = true,
};
static const struct sun4i_tcon_quirks sun8i_a83t_lcd_quirks = {
--
2.24.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/sun4i: tcon: Support LVDS on the A33
2020-02-14 12:09 [PATCH] drm/sun4i: tcon: Support LVDS on the A33 Maxime Ripard
@ 2020-02-21 3:10 ` Chen-Yu Tsai
2020-02-21 13:26 ` Maxime Ripard
0 siblings, 1 reply; 5+ messages in thread
From: Chen-Yu Tsai @ 2020-02-21 3:10 UTC (permalink / raw)
To: Maxime Ripard; +Cc: linux-arm-kernel, dri-devel
On Fri, Feb 14, 2020 at 8:09 PM Maxime Ripard <maxime@cerno.tech> wrote:
>
> The A33 TCON supports LVDS, so we can toggle the support switch.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Chen-Yu Tsai <wens@csie.org>
The user manual doesn't list the bits for LVDS signal polarity though.
I assume this was verified with the BSP or actual testing? (or rather,
will be in the LVDS signal polarity patches.)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/sun4i: tcon: Support LVDS on the A33
2020-02-21 3:10 ` Chen-Yu Tsai
@ 2020-02-21 13:26 ` Maxime Ripard
0 siblings, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2020-02-21 13:26 UTC (permalink / raw)
To: Chen-Yu Tsai; +Cc: linux-arm-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 628 bytes --]
Hi
On Fri, Feb 21, 2020 at 11:10:47AM +0800, Chen-Yu Tsai wrote:
> On Fri, Feb 14, 2020 at 8:09 PM Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > The A33 TCON supports LVDS, so we can toggle the support switch.
> >
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
>
> The user manual doesn't list the bits for LVDS signal polarity though.
> I assume this was verified with the BSP or actual testing? (or rather,
> will be in the LVDS signal polarity patches.)
The polarity stuff is a separate series :)
But yeah, both were tested on hardware.
I've applied it, thanks!
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/sun4i: tcon: Support LVDS on the A33
2020-02-14 12:24 Maxime Ripard
@ 2020-02-14 12:31 ` Maxime Ripard
0 siblings, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2020-02-14 12:31 UTC (permalink / raw)
To: Chen-Yu Tsai, dri-devel
Cc: Mark Rutland, devicetree, David Airlie, Sam Ravnborg,
Rob Herring, Sean Paul, Thierry Reding, Daniel Vetter,
Frank Rowand, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 242 bytes --]
On Fri, Feb 14, 2020 at 01:24:27PM +0100, Maxime Ripard wrote:
> The A33 TCON supports LVDS, so we can toggle the support switch.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Sorry, that one was a spurious send-email run ...
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drm/sun4i: tcon: Support LVDS on the A33
@ 2020-02-14 12:24 Maxime Ripard
2020-02-14 12:31 ` Maxime Ripard
0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2020-02-14 12:24 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard, dri-devel
Cc: Mark Rutland, devicetree, David Airlie, Sam Ravnborg,
Rob Herring, Sean Paul, Maxime Ripard, Thierry Reding,
Daniel Vetter, Frank Rowand, linux-arm-kernel
The A33 TCON supports LVDS, so we can toggle the support switch.
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index fdf143042f83..14026b4fa7c7 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -1475,6 +1475,7 @@ static const struct sun4i_tcon_quirks sun8i_a33_quirks = {
.has_channel_0 = true,
.has_lvds_alt = true,
.dclk_min_div = 1,
+ .supports_lvds = true,
};
static const struct sun4i_tcon_quirks sun8i_a83t_lcd_quirks = {
--
2.24.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-21 16:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-14 12:09 [PATCH] drm/sun4i: tcon: Support LVDS on the A33 Maxime Ripard
2020-02-21 3:10 ` Chen-Yu Tsai
2020-02-21 13:26 ` Maxime Ripard
2020-02-14 12:24 Maxime Ripard
2020-02-14 12:31 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).