From: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
To: Melissa Wen <melissa.srw@gmail.com>
Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
Leo Li <sunpeng.li@amd.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
David Airlie <airlied@linux.ie>,
amd-gfx@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
Christian Konig <christian.koenig@amd.com>
Subject: Re: [PATCH 1/2] drm/amd/display: dc_link: code clean up on enable_link_dp function
Date: Thu, 27 Feb 2020 10:04:22 -0500 [thread overview]
Message-ID: <20200227150422.isialtxjvtru23xl@outlook.office365.com> (raw)
In-Reply-To: <990112183d2bc344bd921bb55eee2f8cc2cd8bd5.1582752490.git.melissa.srw@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 3598 bytes --]
Hi,
First of all, thank you for your patch.
I just have one tiny comment inline.
On 02/26, Melissa Wen wrote:
> Coding style clean up on enable_link_dp function as suggested by
> checkpatch.pl:
>
> CHECK: Lines should not end with a '('
> WARNING: line over 80 characters
> WARNING: suspect code indent for conditional statements (8, 24)
> CHECK: braces {} should be used on all arms of this statement
> ERROR: else should follow close brace '}'
> CHECK: Comparison to NULL could be written
> "link->preferred_training_settings.fec_enable"
>
> Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 32 +++++++++----------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index a09119c10d7c..0f28b5694144 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -1480,9 +1480,8 @@ static void enable_stream_features(struct pipe_ctx *pipe_ctx)
> }
> }
>
> -static enum dc_status enable_link_dp(
> - struct dc_state *state,
> - struct pipe_ctx *pipe_ctx)
> +static enum dc_status enable_link_dp(struct dc_state *state,
> + struct pipe_ctx *pipe_ctx)
> {
> struct dc_stream_state *stream = pipe_ctx->stream;
> enum dc_status status;
> @@ -1512,27 +1511,28 @@ static enum dc_status enable_link_dp(
>
> pipe_ctx->stream_res.pix_clk_params.requested_sym_clk =
> link_settings.link_rate * LINK_RATE_REF_FREQ_IN_KHZ;
> - if (state->clk_mgr && !apply_seamless_boot_optimization)
> - state->clk_mgr->funcs->update_clocks(state->clk_mgr, state, false);
> + if (state->clk_mgr && !apply_seamless_boot_optimization) {
> + state->clk_mgr->funcs->update_clocks(state->clk_mgr,
> + state, false);
> + }
This `if` condition only has one action, which means that you don't need
to add `{}` in the above statement. See:
https://www.kernel.org/doc/html/v4.10/process/coding-style.html#placing-braces-and-spaces
Thanks
>
> skip_video_pattern = true;
>
> if (link_settings.link_rate == LINK_RATE_LOW)
> - skip_video_pattern = false;
> -
> - if (perform_link_training_with_retries(
> - &link_settings,
> - skip_video_pattern,
> - LINK_TRAINING_ATTEMPTS,
> - pipe_ctx,
> - pipe_ctx->stream->signal)) {
> + skip_video_pattern = false;
> +
> + if (perform_link_training_with_retries(&link_settings,
> + skip_video_pattern,
> + LINK_TRAINING_ATTEMPTS,
> + pipe_ctx,
> + pipe_ctx->stream->signal)) {
> link->cur_link_settings = link_settings;
> status = DC_OK;
> - }
> - else
> + } else {
> status = DC_FAIL_DP_LINK_TRAINING;
> + }
>
> - if (link->preferred_training_settings.fec_enable != NULL)
> + if (link->preferred_training_settings.fec_enable)
> fec_enable = *link->preferred_training_settings.fec_enable;
> else
> fec_enable = true;
> --
> 2.25.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=02%7C01%7CRodrigo.Siqueira%40amd.com%7Ccbf2adb12548404e917208d7bb0842d2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637183516476617662&sdata=%2FyyxWqZVGvbVAnr1OWCKi0y5Sdl5j5Le6C3dmYoaNy4%3D&reserved=0
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-27 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 22:05 [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues Melissa Wen
2020-02-26 22:07 ` [PATCH 1/2] drm/amd/display: dc_link: code clean up on enable_link_dp function Melissa Wen
2020-02-27 15:04 ` Rodrigo Siqueira [this message]
2020-02-26 22:08 ` [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp function Melissa Wen
2020-02-27 18:39 ` Liu, Zhan
2020-02-27 18:48 ` Liu, Zhan
2020-02-27 15:05 ` [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues Rodrigo Siqueira
2020-02-27 18:38 ` Melissa Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227150422.isialtxjvtru23xl@outlook.office365.com \
--to=rodrigo.siqueira@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=melissa.srw@gmail.com \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).