From: "Liu, Zhan" <Zhan.Liu@amd.com>
To: Melissa Wen <melissa.srw@gmail.com>,
"Wentland, Harry" <Harry.Wentland@amd.com>,
"Li, Sun peng (Leo)" <Sunpeng.Li@amd.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>,
"Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp function
Date: Thu, 27 Feb 2020 18:39:51 +0000 [thread overview]
Message-ID: <DM5PR1201MB25540271F42D8034FB2611829EEB0@DM5PR1201MB2554.namprd12.prod.outlook.com> (raw)
In-Reply-To: <9961afca2cf831ac688025a63b7cd35dd0908fac.1582752490.git.melissa.srw@gmail.com>
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Melissa Wen
> Sent: 2020/February/26, Wednesday 5:08 PM
> To: Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo)
> <Sunpeng.Li@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; Zhou, David(ChunMing)
> <David1.Zhou@amd.com>; David Airlie <airlied@linux.ie>; Daniel Vetter
> <daniel@ffwll.ch>; Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
> Cc: dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp
> function
>
> Removes codestyle issues on detect_dp function as suggested by
> checkpatch.pl.
>
> CHECK: Lines should not end with a '('
> WARNING: Missing a blank line after declarations
> WARNING: line over 80 characters
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
Thank you Melissa for your contribution! Will apply it.
This patch is:
Reviewed-by: Zhan Liu <zhan.liu@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 35 +++++++++----------
> 1 file changed, 16 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index 0f28b5694144..adb717f02c9c 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -585,14 +585,14 @@ static void
> read_current_link_settings_on_detect(struct dc_link *link)
> LINK_SPREAD_05_DOWNSPREAD_30KHZ :
> LINK_SPREAD_DISABLED; }
>
> -static bool detect_dp(
> - struct dc_link *link,
> - struct display_sink_capability *sink_caps,
> - bool *converter_disable_audio,
> - struct audio_support *audio_support,
> - enum dc_detect_reason reason)
> +static bool detect_dp(struct dc_link *link,
> + struct display_sink_capability *sink_caps,
> + bool *converter_disable_audio,
> + struct audio_support *audio_support,
> + enum dc_detect_reason reason)
> {
> bool boot = false;
> +
> sink_caps->signal = link_detect_sink(link, reason);
> sink_caps->transaction_type =
> get_ddc_transaction_type(sink_caps->signal);
> @@ -606,9 +606,8 @@ static bool detect_dp(
> sink_caps->signal =
> SIGNAL_TYPE_DISPLAY_PORT_MST;
> link->type = dc_connection_mst_branch;
>
> - dal_ddc_service_set_transaction_type(
> - link->ddc,
> - sink_caps-
> >transaction_type);
> + dal_ddc_service_set_transaction_type(link->ddc,
> + sink_caps-
> >transaction_type);
>
> /*
> * This call will initiate MST topology discovery.
> Which @@ -637,13 +636,10 @@ static bool detect_dp(
> if (reason == DETECT_REASON_BOOT)
> boot = true;
>
> - dm_helpers_dp_update_branch_info(
> - link->ctx,
> - link);
> + dm_helpers_dp_update_branch_info(link->ctx, link);
>
> - if (!dm_helpers_dp_mst_start_top_mgr(
> - link->ctx,
> - link, boot)) {
> + if (!dm_helpers_dp_mst_start_top_mgr(link->ctx,
> + link, boot)) {
> /* MST not supported */
> link->type = dc_connection_single;
> sink_caps->signal =
> SIGNAL_TYPE_DISPLAY_PORT; @@ -651,7 +647,7 @@ static bool detect_dp(
> }
>
> if (link->type != dc_connection_mst_branch &&
> - is_dp_active_dongle(link)) {
> + is_dp_active_dongle(link)) {
> /* DP active dongles */
> link->type = dc_connection_active_dongle;
> if (!link->dpcd_caps.sink_count.bits.SINK_COUNT)
> { @@ -662,14 +658,15 @@ static bool detect_dp(
> return true;
> }
>
> - if (link->dpcd_caps.dongle_type !=
> DISPLAY_DONGLE_DP_HDMI_CONVERTER)
> + if (link->dpcd_caps.dongle_type !=
> + DISPLAY_DONGLE_DP_HDMI_CONVERTER)
> *converter_disable_audio = true;
> }
> } else {
> /* DP passive dongles */
> sink_caps->signal = dp_passive_dongle_detection(link->ddc,
> - sink_caps,
> - audio_support);
> + sink_caps,
> +
> audio_support);
> }
>
> return true;
> --
> 2.25.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-27 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 22:05 [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues Melissa Wen
2020-02-26 22:07 ` [PATCH 1/2] drm/amd/display: dc_link: code clean up on enable_link_dp function Melissa Wen
2020-02-27 15:04 ` Rodrigo Siqueira
2020-02-26 22:08 ` [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp function Melissa Wen
2020-02-27 18:39 ` Liu, Zhan [this message]
2020-02-27 18:48 ` Liu, Zhan
2020-02-27 15:05 ` [PATCH 0/2] drm/amd/display: dc_link: cleaning up some code style issues Rodrigo Siqueira
2020-02-27 18:38 ` Melissa Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR1201MB25540271F42D8034FB2611829EEB0@DM5PR1201MB2554.namprd12.prod.outlook.com \
--to=zhan.liu@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=David1.Zhou@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=Sunpeng.Li@amd.com \
--cc=airlied@linux.ie \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=melissa.srw@gmail.com \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).