dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: display: drop data-mapping from panel-dpi
Date: Tue, 17 Mar 2020 21:23:02 +0200	[thread overview]
Message-ID: <20200317192302.GB2527@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200314153047.2486-2-sam@ravnborg.org>

Hi Sam,

Thank you for the patch.

On Sat, Mar 14, 2020 at 04:30:45PM +0100, Sam Ravnborg wrote:
> data-mapping may not be the best way to describe the
> data format used between panels and display interface.
> 
> Drop it from the panel-dpi binding so we do not start to rely on it.
> We can then work out how to best describe this mapping and when
> we know it, we can add it to this binding.

I certainly welcome that, as we need to define how to express this
information in a more detailed way, taking into account all use cases.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I think this qualifies as a v5.7 fix.

> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/display/panel/panel-dpi.yaml   | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
> index f63870384c00..0cd74c8dab42 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
> @@ -21,15 +21,6 @@ properties:
>        - {}
>        - const: panel-dpi
>  
> -  data-mapping:
> -    enum:
> -      - rgb24
> -      - rgb565
> -      - bgr666
> -    description: |
> -      Describes the media format, how the display panel is connected
> -      to the display interface.
> -
>    backlight: true
>    enable-gpios: true
>    height-mm: true
> @@ -52,7 +43,6 @@ examples:
>          compatible = "osddisplays,osd057T0559-34ts", "panel-dpi";
>          label = "osddisplay";
>          power-supply = <&vcc_supply>;
> -        data-mapping = "rgb565";
>          backlight = <&backlight>;
>  
>          port {

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-03-17 19:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-14 15:30 [PATCH v1 0/3] drm: drop data-mapping property from panel-dpi Sam Ravnborg
2020-03-14 15:30 ` [PATCH v1 1/3] dt-bindings: display: drop data-mapping " Sam Ravnborg
2020-03-17  8:49   ` Maxime Ripard
2020-03-17 11:22     ` Sam Ravnborg
2020-03-19  9:55       ` Maxime Ripard
2020-03-17 19:23   ` Laurent Pinchart [this message]
2020-03-14 15:30 ` [PATCH v1 2/3] drm/panel-simple: drop use of data-mapping property Sam Ravnborg
2020-03-17 19:23   ` Laurent Pinchart
2020-03-14 15:30 ` [PATCH v1 3/3] dt-bindings: display: grammar fixes in panel/ Sam Ravnborg
2020-03-17 19:25   ` Laurent Pinchart
2020-03-21 21:04     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200317192302.GB2527@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).