From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 2/3] drm/panel-simple: drop use of data-mapping property
Date: Tue, 17 Mar 2020 21:23:40 +0200 [thread overview]
Message-ID: <20200317192340.GC2527@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200314153047.2486-3-sam@ravnborg.org>
Hi Sam,
Thank you for the patch.
On Sat, Mar 14, 2020 at 04:30:46PM +0100, Sam Ravnborg wrote:
> The "data-mapping" property may not be the best way to describe the
> interface between panels and display interfaces.
> Drop use of in the panel-simple driver, so we have time to find
> the right way to describe this interface.
For the same reason as for patch 1/3,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 0ce81b1f36af..3ad828eaefe1 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -361,7 +361,6 @@ static int panel_dpi_probe(struct device *dev,
> struct panel_desc *desc;
> unsigned int bus_flags;
> struct videomode vm;
> - const char *mapping;
> int ret;
>
> np = dev->of_node;
> @@ -386,16 +385,6 @@ static int panel_dpi_probe(struct device *dev,
> of_property_read_u32(np, "width-mm", &desc->size.width);
> of_property_read_u32(np, "height-mm", &desc->size.height);
>
> - of_property_read_string(np, "data-mapping", &mapping);
> - if (!strcmp(mapping, "rgb24"))
> - desc->bus_format = MEDIA_BUS_FMT_RGB888_1X24;
> - else if (!strcmp(mapping, "rgb565"))
> - desc->bus_format = MEDIA_BUS_FMT_RGB565_1X16;
> - else if (!strcmp(mapping, "bgr666"))
> - desc->bus_format = MEDIA_BUS_FMT_RGB666_1X18;
> - else if (!strcmp(mapping, "lvds666"))
> - desc->bus_format = MEDIA_BUS_FMT_RGB666_1X24_CPADHI;
> -
> /* Extract bus_flags from display_timing */
> bus_flags = 0;
> vm.flags = timing->flags;
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-17 19:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 15:30 [PATCH v1 0/3] drm: drop data-mapping property from panel-dpi Sam Ravnborg
2020-03-14 15:30 ` [PATCH v1 1/3] dt-bindings: display: drop data-mapping " Sam Ravnborg
2020-03-17 8:49 ` Maxime Ripard
2020-03-17 11:22 ` Sam Ravnborg
2020-03-19 9:55 ` Maxime Ripard
2020-03-17 19:23 ` Laurent Pinchart
2020-03-14 15:30 ` [PATCH v1 2/3] drm/panel-simple: drop use of data-mapping property Sam Ravnborg
2020-03-17 19:23 ` Laurent Pinchart [this message]
2020-03-14 15:30 ` [PATCH v1 3/3] dt-bindings: display: grammar fixes in panel/ Sam Ravnborg
2020-03-17 19:25 ` Laurent Pinchart
2020-03-21 21:04 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317192340.GC2527@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).