From: Mark Brown <broonie@kernel.org>
To: Steven Price <steven.price@arm.com>
Cc: "Nishanth Menon" <nm@ti.com>,
"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Viresh Kumar" <vireshk@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Clément Péron" <peron.clem@gmail.com>,
"Alyssa Rosenzweig" <alyssa.rosenzweig@collabora.com>
Subject: Re: Multiple regulators for one device [was drm/panfrost: add devfreq regulator support]
Date: Thu, 16 Apr 2020 15:04:34 +0100 [thread overview]
Message-ID: <20200416140434.GL5354@sirena.org.uk> (raw)
In-Reply-To: <5e15e7ac-1d9c-d614-8fd9-27525c88cafb@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 1048 bytes --]
On Thu, Apr 16, 2020 at 02:42:13PM +0100, Steven Price wrote:
> On 14/04/2020 20:16, Clément Péron wrote:
> > That's can be reworked and Panfrost can only probe regulator if there
> > is no opp-table.
> This is what I was thinking about looking at. But it may make sense instead
> to extend the regulator API to allow multiple regualtor_get() calls for a
> single device. I haven't had time to dig into how difficult this would be.
To repeat what I said before we don't actively stop this, it's just not
something that seems particularly tasteful and the warning does find
actual errors. I definitely don't think it's a good idea to extend the
API for this.
> Ideally calling regulator_get a second time for the same device would simply
> return the same struct regulator object (with a reference count increment).
One of the goals with the distinct struct regulator is to make sure that
we track all the user's activity together - if we mix multiple users in
there it becomes harder to tell if something is going wrong.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-16 14:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 20:06 [PATCH 1/2] drm/panfrost: missing remove opp table in case of failure Clément Péron
2020-04-11 20:06 ` [PATCH 2/2] drm/panfrost: add devfreq regulator support Clément Péron
2020-04-13 11:33 ` Clément Péron
2020-04-13 13:18 ` Steven Price
2020-04-13 14:18 ` Clément Péron
2020-04-13 14:31 ` Clément Péron
2020-04-13 15:55 ` Steven Price
2020-04-13 16:35 ` Clément Péron
2020-04-13 17:28 ` Clément Péron
2020-04-14 13:10 ` Steven Price
2020-04-14 18:20 ` Clément Péron
2020-04-14 18:55 ` Mark Brown
2020-04-14 19:16 ` Clément Péron
2020-04-16 13:42 ` Multiple regulators for one device [was drm/panfrost: add devfreq regulator support] Steven Price
2020-04-16 14:04 ` Mark Brown [this message]
2020-04-17 11:10 ` Robin Murphy
2020-04-17 12:33 ` Clément Péron
2020-04-19 9:25 ` Clément Péron
2020-04-20 12:32 ` Mark Brown
2020-04-16 13:44 ` [PATCH 2/2] drm/panfrost: add devfreq regulator support Mark Brown
2020-05-02 22:07 ` Clément Péron
2020-05-07 14:30 ` Steven Price
2020-05-09 16:28 ` Clément Péron
2020-05-09 19:40 ` Clément Péron
2020-04-14 13:09 ` Robin Murphy
2020-04-13 13:07 ` [PATCH 1/2] drm/panfrost: missing remove opp table in case of failure Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416140434.GL5354@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=peron.clem@gmail.com \
--cc=sboyd@kernel.org \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).