From: "Clément Péron" <peron.clem@gmail.com>
To: Steven Price <steven.price@arm.com>
Cc: Nishanth Menon <nm@ti.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Stephen Boyd <sboyd@kernel.org>,
Viresh Kumar <vireshk@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Subject: Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support
Date: Sat, 9 May 2020 21:40:07 +0200 [thread overview]
Message-ID: <CAJiuCcfeOZjaunQp3g+X8NQNQaKxO8QEHM6wjYpjgUWx376EJg@mail.gmail.com> (raw)
In-Reply-To: <CAJiuCcduOw1jZ60j+i8GnAda6HACUeCD-DyqoY1aYisSOcuiXQ@mail.gmail.com>
On Sat, 9 May 2020 at 18:28, Clément Péron <peron.clem@gmail.com> wrote:
>
> Hi Steven,
>
> On Thu, 7 May 2020 at 16:30, Steven Price <steven.price@arm.com> wrote:
> >
> > On 02/05/2020 23:07, Clément Péron wrote:
> > > Hi Steven,
> > >
> > > On Tue, 14 Apr 2020 at 15:10, Steven Price <steven.price@arm.com> wrote:
> > >>
> > >> Hi Clément,
> > >>
> > >> On 13/04/2020 18:28, Clément Péron wrote:
> > >>> Hi Steven,
> > >>>
> > >
> <snip>
> >
> > Since you've got a reproduction - can you get a backtrace where the
> > regulator is getting disabled?
>
> Regulator is disabled from regulator_late_cleanup()
>
> [ 33.757650] vdd-gpu: disabling
> [ 33.760718] CPU: 2 PID: 31 Comm: kworker/2:1 Not tainted
> 5.7.0-rc2-next-20200424 #8
> [ 33.768362] Hardware name: Beelink GS1 (DT)
> [ 33.772553] Workqueue: events regulator_init_complete_work_function
> [ 33.778813] Call trace:
> [ 33.781261] dump_backtrace+0x0/0x1a0
> [ 33.784922] show_stack+0x18/0x30
> [ 33.788238] dump_stack+0xc0/0x114
> [ 33.791638] regulator_late_cleanup+0x164/0x1f0
> [ 33.796165] class_for_each_device+0x64/0xe0
> [ 33.800431] regulator_init_complete_work_function+0x4c/0x60
> [ 33.806084] process_one_work+0x19c/0x330
> [ 33.810090] worker_thread+0x4c/0x430
> [ 33.813748] kthread+0x138/0x160
> [ 33.816973] ret_from_fork+0x10/0x24
>
> the use_count is at 0...
>
> I have check and the regulator_get is called and regulator_put is
> never called for vdd-gpu.
> Not sure what is happening here...
Looks like the OPP framework only get the regulator but never enable it...
I will send a question to OPP Maintainer about this.
Regards,
CLement
>
>
> >
> > > - The Cooling map is not probe correctly :
> > > [ 2.545756] panfrost 1800000.gpu: [drm:panfrost_devfreq_init
> > > [panfrost]] Failed to register cooling device
> > > Introduce in this commit :
> > > https://github.com/clementperon/linux/commit/0252c38fd55ad78366ac4b1714e285c88db34557
> > >
> > > Do you have an hint about what I'm missing ?
> >
> > Sorry, my knowledge of the cooling framework is very limited. What
> > you've got looks plausible, but I'm afraid I can't really help beyond
> > that! As before - can you try adding some printk()s in e.g.
> > of_devfreq_cooling_register_power() and find out where it is bailing out?
>
> Dumb issue, I was missing the CONFIG_DEVFREQ_THERMAL -_-, I will make
> a patch to enable it in arm64 defconfig.
>
> Regards,
> Clement
>
> >
> > Steve
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-11 7:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 20:06 [PATCH 1/2] drm/panfrost: missing remove opp table in case of failure Clément Péron
2020-04-11 20:06 ` [PATCH 2/2] drm/panfrost: add devfreq regulator support Clément Péron
2020-04-13 11:33 ` Clément Péron
2020-04-13 13:18 ` Steven Price
2020-04-13 14:18 ` Clément Péron
2020-04-13 14:31 ` Clément Péron
2020-04-13 15:55 ` Steven Price
2020-04-13 16:35 ` Clément Péron
2020-04-13 17:28 ` Clément Péron
2020-04-14 13:10 ` Steven Price
2020-04-14 18:20 ` Clément Péron
2020-04-14 18:55 ` Mark Brown
2020-04-14 19:16 ` Clément Péron
2020-04-16 13:42 ` Multiple regulators for one device [was drm/panfrost: add devfreq regulator support] Steven Price
2020-04-16 14:04 ` Mark Brown
2020-04-17 11:10 ` Robin Murphy
2020-04-17 12:33 ` Clément Péron
2020-04-19 9:25 ` Clément Péron
2020-04-20 12:32 ` Mark Brown
2020-04-16 13:44 ` [PATCH 2/2] drm/panfrost: add devfreq regulator support Mark Brown
2020-05-02 22:07 ` Clément Péron
2020-05-07 14:30 ` Steven Price
2020-05-09 16:28 ` Clément Péron
2020-05-09 19:40 ` Clément Péron [this message]
2020-04-14 13:09 ` Robin Murphy
2020-04-13 13:07 ` [PATCH 1/2] drm/panfrost: missing remove opp table in case of failure Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJiuCcfeOZjaunQp3g+X8NQNQaKxO8QEHM6wjYpjgUWx376EJg@mail.gmail.com \
--to=peron.clem@gmail.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).