dri-devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] [v2] drm/panfrost: Fix runtime PM imbalance on error
@ 2020-05-22 13:41 Dinghao Liu
  2020-05-27 15:52 ` Steven Price
  0 siblings, 1 reply; 2+ messages in thread
From: Dinghao Liu @ 2020-05-22 13:41 UTC (permalink / raw)
  To: dinghao.liu, kjlu
  Cc: Tomeu Vizoso, David Airlie, linux-kernel, dri-devel,
	Steven Price, Alyssa Rosenzweig

The caller expects panfrost_job_hw_submit() to increase
runtime PM usage counter. The refcount decrement on the
error branch of WARN_ON() will break the counter balance
and needs to be removed.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---

Changelog:

v2: - Remove refcount decrement on the error path of
      WARN_ON() rather than add refcount decrement
      on the error path of pm_runtime_get_sync().
---
 drivers/gpu/drm/panfrost/panfrost_job.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
index 7914b1570841..1092d9754f0f 100644
--- a/drivers/gpu/drm/panfrost/panfrost_job.c
+++ b/drivers/gpu/drm/panfrost/panfrost_job.c
@@ -150,7 +150,6 @@ static void panfrost_job_hw_submit(struct panfrost_job *job, int js)
 		return;
 
 	if (WARN_ON(job_read(pfdev, JS_COMMAND_NEXT(js)))) {
-		pm_runtime_put_sync_autosuspend(pfdev->dev);
 		return;
 	}
 
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [v2] drm/panfrost: Fix runtime PM imbalance on error
  2020-05-22 13:41 [PATCH] [v2] drm/panfrost: Fix runtime PM imbalance on error Dinghao Liu
@ 2020-05-27 15:52 ` Steven Price
  0 siblings, 0 replies; 2+ messages in thread
From: Steven Price @ 2020-05-27 15:52 UTC (permalink / raw)
  To: Dinghao Liu, kjlu
  Cc: Tomeu Vizoso, David Airlie, linux-kernel, dri-devel, Alyssa Rosenzweig

On 22/05/2020 14:41, Dinghao Liu wrote:
> The caller expects panfrost_job_hw_submit() to increase
> runtime PM usage counter. The refcount decrement on the
> error branch of WARN_ON() will break the counter balance
> and needs to be removed.
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>

Reviewed-by: Steven Price <steven.price@arm.com>

Thanks,

Steve

> ---
> 
> Changelog:
> 
> v2: - Remove refcount decrement on the error path of
>        WARN_ON() rather than add refcount decrement
>        on the error path of pm_runtime_get_sync().
> ---
>   drivers/gpu/drm/panfrost/panfrost_job.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 7914b1570841..1092d9754f0f 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -150,7 +150,6 @@ static void panfrost_job_hw_submit(struct panfrost_job *job, int js)
>   		return;
>   
>   	if (WARN_ON(job_read(pfdev, JS_COMMAND_NEXT(js)))) {
> -		pm_runtime_put_sync_autosuspend(pfdev->dev);
>   		return;
>   	}
>   
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22 13:41 [PATCH] [v2] drm/panfrost: Fix runtime PM imbalance on error Dinghao Liu
2020-05-27 15:52 ` Steven Price

dri-devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dri-devel/0 dri-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dri-devel dri-devel/ https://lore.kernel.org/dri-devel \
		dri-devel@lists.freedesktop.org
	public-inbox-index dri-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.dri-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git