* [v2] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep
@ 2020-06-04 10:34 Harigovindan P
2020-06-04 19:33 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Harigovindan P @ 2020-06-04 10:34 UTC (permalink / raw)
To: dri-devel, linux-arm-msm, freedreno, devicetree
Cc: Harigovindan P, linux-kernel, seanpaul, kalyan_t, hoegsberg, sam
ti-sn65dsi86 bridge is enumerated as a runtime device.
Adding sleep ops to force runtime_suspend when PM suspend is
requested on the device.
Signed-off-by: Harigovindan P <harigovi@codeaurora.org>
---
Changes in v2:
- Include bridge name in the commit message and
remove dependent patchwork link from the commit
text as bridge is independent of OEM(Stephen Boyd)
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index 6ad688b320ae..2eef755b2917 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -159,6 +159,8 @@ static int __maybe_unused ti_sn_bridge_suspend(struct device *dev)
static const struct dev_pm_ops ti_sn_bridge_pm_ops = {
SET_RUNTIME_PM_OPS(ti_sn_bridge_suspend, ti_sn_bridge_resume, NULL)
+ SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
+ pm_runtime_force_resume)
};
static int status_show(struct seq_file *s, void *data)
--
2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [v2] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep
2020-06-04 10:34 [v2] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep Harigovindan P
@ 2020-06-04 19:33 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2020-06-04 19:33 UTC (permalink / raw)
To: Harigovindan P
Cc: devicetree, linux-arm-msm, linux-kernel, dri-devel, seanpaul,
kalyan_t, hoegsberg, freedreno
Hi Harigovindan
On Thu, Jun 04, 2020 at 04:04:38PM +0530, Harigovindan P wrote:
> ti-sn65dsi86 bridge is enumerated as a runtime device.
>
> Adding sleep ops to force runtime_suspend when PM suspend is
> requested on the device.
Patch looks correct - but could you please explain why it is needed.
What is the gain compared to not having this patch.
I ask for two reasons:
1) I really do not know
2) this info should be in the changelog
Without a better changelog no ack from me - sorry.
Sam
>
> Signed-off-by: Harigovindan P <harigovi@codeaurora.org>
> ---
> Changes in v2:
> - Include bridge name in the commit message and
> remove dependent patchwork link from the commit
> text as bridge is independent of OEM(Stephen Boyd)
>
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index 6ad688b320ae..2eef755b2917 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -159,6 +159,8 @@ static int __maybe_unused ti_sn_bridge_suspend(struct device *dev)
>
> static const struct dev_pm_ops ti_sn_bridge_pm_ops = {
> SET_RUNTIME_PM_OPS(ti_sn_bridge_suspend, ti_sn_bridge_resume, NULL)
> + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> + pm_runtime_force_resume)
> };
>
> static int status_show(struct seq_file *s, void *data)
> --
> 2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-05 7:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-04 10:34 [v2] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep Harigovindan P
2020-06-04 19:33 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).