* Re: [PATCH] drm/msm: Fix memory leak in msm_submitqueue_create()
@ 2020-06-12 9:37 Markus Elfring
2020-06-12 10:02 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-06-12 9:37 UTC (permalink / raw)
To: Bernard Zhao, dri-devel, freedreno, linux-arm-msm, opensource.kernel
Cc: David Airlie, Sean Paul, linux-kernel
> In fucntin msm_submitqueue_create, the queue is a local
> variable, in return -EINVAL branch, queue didn`t add to ctx`s
> list yet, and also didn`t kfree, this maybe bring in potential
> memleak.
I suggest to improve also this change description.
How do you think about a wording variant like the following?
Release the GPU submission queue object after an input parameter validation failed.
Would you like to add the tag “Fixes” to the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=b791d1bdf9212d944d749a5c7ff6febdba241771#n183
How do you think about to reorder any statements for this function implementation?
Regards,
Markus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/msm: Fix memory leak in msm_submitqueue_create()
2020-06-12 9:37 [PATCH] drm/msm: Fix memory leak in msm_submitqueue_create() Markus Elfring
@ 2020-06-12 10:02 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-06-12 10:02 UTC (permalink / raw)
To: Markus Elfring
Cc: Sean Paul, opensource.kernel, David Airlie, Bernard Zhao,
linux-kernel, dri-devel, linux-arm-msm, freedreno
On Fri, Jun 12, 2020 at 11:37:33AM +0200, Markus Elfring wrote:
> > In fucntin msm_submitqueue_create, the queue is a local
> > variable, in return -EINVAL branch, queue didn`t add to ctx`s
> > list yet, and also didn`t kfree, this maybe bring in potential
> > memleak.
>
> I suggest to improve also this change description.
> How do you think about a wording variant like the following?
>
> Release the GPU submission queue object after an input parameter validation failed.
>
>
> Would you like to add the tag “Fixes” to the commit message?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=b791d1bdf9212d944d749a5c7ff6febdba241771#n183
>
>
> How do you think about to reorder any statements for this function implementation?
>
> Regards,
> Markus
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-13 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-12 9:37 [PATCH] drm/msm: Fix memory leak in msm_submitqueue_create() Markus Elfring
2020-06-12 10:02 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).