[linux-next:master 953/2089] drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:446:6: sparse: sparse: symbol 'vcn_v2_5_mc_resume_dpg_mode' was not declared. Should it be

[linux-next:master 953/2089] drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:446:6: sparse: sparse: symbol 'vcn_v2_5_mc_resume_dpg_mode' was not declared. Should it be

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2356 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   5fcb9628fd1227a5f11d87171cb1b8b5c414d9d9
commit: c422a628925d9733b0807d803133fb78a0a0f707 [953/2089] drm/amdgpu: rename macro for VCN2.0 2.5 and 3.0
config: i386-randconfig-s001-20200617 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.2-rc1-6-g78f577f8-dirty
        git checkout c422a628925d9733b0807d803133fb78a0a0f707
        # save the attached .config to linux build tree
        make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

   drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:152:25: sparse: sparse: cast to restricted __le32
   drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:152:25: sparse: sparse: cast to restricted __le32
   drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:152:25: sparse: sparse: cast to restricted __le32
   drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:158:33: sparse: sparse: cast to restricted __le32
   drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:158:33: sparse: sparse: cast to restricted __le32
   drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:158:33: sparse: sparse: cast to restricted __le32
   drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:217:43: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int volatile [usertype] present_flag_0 @@     got restricted __le32 [usertype] @@
   drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:217:43: sparse:     expected unsigned int volatile [usertype] present_flag_0
   drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:217:43: sparse:     got restricted __le32 [usertype]
>> drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:446:6: sparse: sparse: symbol 'vcn_v2_5_mc_resume_dpg_mode' was not declared. Should it be static?
>> drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:660:6: sparse: sparse: symbol 'vcn_v2_5_clock_gating_dpg_mode' was not declared. Should it be static?
>> drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:1303:5: sparse: sparse: symbol 'vcn_v2_5_stop_dpg_mode' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34657 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[RFC PATCH linux-next] drm/amdgpu: vcn_v2_5_mc_resume_dpg_mode() can be static

[kernel test robot]

Fixes: c422a628925d ("drm/amdgpu: rename macro for VCN2.0 2.5 and 3.0")
Signed-off-by: kernel test robot <lkp@intel.com>
---
 vcn_v2_5.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
index 261afbb504bd0..ba1c4fbc19dc5 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
@@ -443,7 +443,7 @@ static void vcn_v2_5_mc_resume(struct amdgpu_device *adev)
 	}
 }
 
-void vcn_v2_5_mc_resume_dpg_mode(struct amdgpu_device *adev, int inst_idx, bool indirect)
+static void vcn_v2_5_mc_resume_dpg_mode(struct amdgpu_device *adev, int inst_idx, bool indirect)
 {
 	uint32_t size = AMDGPU_GPU_PAGE_ALIGN(adev->vcn.fw->size + 4);
 	uint32_t offset;
@@ -657,7 +657,7 @@ static void vcn_v2_5_disable_clock_gating(struct amdgpu_device *adev)
 	}
 }
 
-void vcn_v2_5_clock_gating_dpg_mode(struct amdgpu_device *adev,
+static void vcn_v2_5_clock_gating_dpg_mode(struct amdgpu_device *adev,
 		uint8_t sram_sel, int inst_idx, uint8_t indirect)
 {
 	uint32_t reg_data = 0;
@@ -1300,7 +1300,7 @@ static int vcn_v2_5_sriov_start(struct amdgpu_device *adev)
 	return vcn_v2_5_mmsch_start(adev, &adev->virt.mm_table);
 }
 
-int vcn_v2_5_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)
+static int vcn_v2_5_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)
 {
 	int ret_code = 0;
 	uint32_t tmp;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel