* [PATCH] drm: panel: Fix bus format for OrtusTech COM43H4M85ULC panel
@ 2020-08-12 22:02 Laurent Pinchart
2020-08-13 19:18 ` Sam Ravnborg
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2020-08-12 22:02 UTC (permalink / raw)
To: dri-devel; +Cc: Thierry Reding, Sam Ravnborg
The OrtusTech COM43H4M85ULC panel is a 18-bit RGB panel, set the bus
format to MEDIA_BUS_FMT_RGB666_1X18.
Fixes: 725c9d40f3fe ("drm/panel: Add support for OrtusTech COM43H4M85ULC panel")
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/gpu/drm/panel/panel-simple.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index ef8df838fe14..ef04fd75babd 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -3018,7 +3018,7 @@ static const struct panel_desc ortustech_com43h4m85ulc = {
.width = 56,
.height = 93,
},
- .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+ .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
.connector_type = DRM_MODE_CONNECTOR_DPI,
};
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: panel: Fix bus format for OrtusTech COM43H4M85ULC panel
2020-08-12 22:02 [PATCH] drm: panel: Fix bus format for OrtusTech COM43H4M85ULC panel Laurent Pinchart
@ 2020-08-13 19:18 ` Sam Ravnborg
2020-08-17 0:30 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Sam Ravnborg @ 2020-08-13 19:18 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Thierry Reding, dri-devel
Hi Laurent.
On Thu, Aug 13, 2020 at 01:02:44AM +0300, Laurent Pinchart wrote:
> The OrtusTech COM43H4M85ULC panel is a 18-bit RGB panel, set the bus
> format to MEDIA_BUS_FMT_RGB666_1X18.
>
> Fixes: 725c9d40f3fe ("drm/panel: Add support for OrtusTech COM43H4M85ULC panel")
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index ef8df838fe14..ef04fd75babd 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3018,7 +3018,7 @@ static const struct panel_desc ortustech_com43h4m85ulc = {
> .width = 56,
> .height = 93,
> },
> - .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> .connector_type = DRM_MODE_CONNECTOR_DPI,
> };
So basically we say that this panel is bpc=8 but connected so we only
utilise 6 bits per color - seems like a waste but may be good enough.
There are other panels that is connected in the same way.
Applied.
Sam
> --
> Regards,
>
> Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: panel: Fix bus format for OrtusTech COM43H4M85ULC panel
2020-08-13 19:18 ` Sam Ravnborg
@ 2020-08-17 0:30 ` Laurent Pinchart
2020-08-17 4:28 ` Sam Ravnborg
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2020-08-17 0:30 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Thierry Reding, dri-devel
Hi Sam,
On Thu, Aug 13, 2020 at 09:18:44PM +0200, Sam Ravnborg wrote:
> On Thu, Aug 13, 2020 at 01:02:44AM +0300, Laurent Pinchart wrote:
> > The OrtusTech COM43H4M85ULC panel is a 18-bit RGB panel, set the bus
> > format to MEDIA_BUS_FMT_RGB666_1X18.
> >
> > Fixes: 725c9d40f3fe ("drm/panel: Add support for OrtusTech COM43H4M85ULC panel")
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > drivers/gpu/drm/panel/panel-simple.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index ef8df838fe14..ef04fd75babd 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -3018,7 +3018,7 @@ static const struct panel_desc ortustech_com43h4m85ulc = {
> > .width = 56,
> > .height = 93,
> > },
> > - .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> > .connector_type = DRM_MODE_CONNECTOR_DPI,
> > };
>
> So basically we say that this panel is bpc=8 but connected so we only
> utilise 6 bits per color - seems like a waste but may be good enough.
> There are other panels that is connected in the same way.
No, this is a 6 bpc panel, I just forgot to fix that :-S
> Applied.
Should I send a fix on top of drm-misc, or would you like to do so ?
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: panel: Fix bus format for OrtusTech COM43H4M85ULC panel
2020-08-17 0:30 ` Laurent Pinchart
@ 2020-08-17 4:28 ` Sam Ravnborg
0 siblings, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2020-08-17 4:28 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Thierry Reding, dri-devel
On Mon, Aug 17, 2020 at 03:30:45AM +0300, Laurent Pinchart wrote:
> Hi Sam,
>
> On Thu, Aug 13, 2020 at 09:18:44PM +0200, Sam Ravnborg wrote:
> > On Thu, Aug 13, 2020 at 01:02:44AM +0300, Laurent Pinchart wrote:
> > > The OrtusTech COM43H4M85ULC panel is a 18-bit RGB panel, set the bus
> > > format to MEDIA_BUS_FMT_RGB666_1X18.
> > >
> > > Fixes: 725c9d40f3fe ("drm/panel: Add support for OrtusTech COM43H4M85ULC panel")
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > > drivers/gpu/drm/panel/panel-simple.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > > index ef8df838fe14..ef04fd75babd 100644
> > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > @@ -3018,7 +3018,7 @@ static const struct panel_desc ortustech_com43h4m85ulc = {
> > > .width = 56,
> > > .height = 93,
> > > },
> > > - .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> > > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > > .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> > > .connector_type = DRM_MODE_CONNECTOR_DPI,
> > > };
> >
> > So basically we say that this panel is bpc=8 but connected so we only
> > utilise 6 bits per color - seems like a waste but may be good enough.
> > There are other panels that is connected in the same way.
>
> No, this is a 6 bpc panel, I just forgot to fix that :-S
>
> > Applied.
>
> Should I send a fix on top of drm-misc, or would you like to do so ?
Please send a fix.
Sam
>
> --
> Regards,
>
> Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-17 4:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-12 22:02 [PATCH] drm: panel: Fix bus format for OrtusTech COM43H4M85ULC panel Laurent Pinchart
2020-08-13 19:18 ` Sam Ravnborg
2020-08-17 0:30 ` Laurent Pinchart
2020-08-17 4:28 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).