From: Sam Ravnborg <sam@ravnborg.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: devicetree@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@linux.ie>,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
Daniel Palmer <daniel@0x0f.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Lubomir Rintel <lkundrak@v3.sk>, Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Mark Brown <broonie@kernel.org>, allen <allen.chen@ite.com.tw>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 2/3] dt-bindings: Add Mantix MLAF057WE51-X panel bindings
Date: Sat, 15 Aug 2020 23:08:02 +0200 [thread overview]
Message-ID: <20200815210802.GA1242831@ravnborg.org> (raw)
In-Reply-To: <20200815164737.GA3640@bogon.m.sigxcpu.org>
Hi Guido.
On Sat, Aug 15, 2020 at 06:47:37PM +0200, Guido Günther wrote:
> Hi Sam,
> On Sat, Aug 15, 2020 at 10:39:17AM +0200, Sam Ravnborg wrote:
> > Hi Guido.
> >
> > On Fri, Aug 14, 2020 at 03:36:22PM +0200, Guido Günther wrote:
> > > The panel uses a Focaltech FT8006p, the touch part is handled by the
> > > already existing edt-ft5x06.
> > >
> > > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> >
> > A few trivialities.
>
> Thanks for having a look. One remark inline:
>
> >
> > > ---
> > > .../display/panel/mantix,mlaf057we51-x.yaml | 73 +++++++++++++++++++
> > > 1 file changed, 73 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
> > > new file mode 100644
> > > index 0000000000000..349f3380ac940
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
> > > @@ -0,0 +1,73 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/display/panel/mantix,mlaf057we51-x.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Mantix MLAF057WE51-X 5.7" 720x1440 TFT LCD panel
> > > +
> > > +maintainers:
> > > + - Guido Günther <agx@sigxcpu.org>
> > > +
> > > +description: |
> > > + Mantix MLAF057WE51 X is a 720x1440 TFT LCD panel
> > > + connected using a MIPI-DSI video interface.
> > Indent text with two spaces only.
> > And I have learned that '|' is only needed to preserve formatting - so
> > it can be dropped.
> >
> > > +
> > > +allOf:
> > > + - $ref: panel-common.yaml#
> > > +
> > > +properties:
> > > + compatible:
> > > + enum:
> > > + - mantix,mlaf057we51-x
> > This is a list - so needs an extra 2 spaces indent.
> > See https://lore.kernel.org/linux-devicetree/f1963eb9-283f-e903-2a3a-4f324d71d418@lucaceresoli.net/T/#m65900317fb948f6c40e8fb521f2201fba3c301a7
> > for examples where Rob fixes this.
>
> Doesn't this only apply if the 'outer element' is a list too so e.g.:
>
> - enum
> - foo
>
> trips up yamllint but
>
> enum
> - foo
>
> doesn't. Since yamllint was happy i kept it as is (looking at your
> reference suggests that too).
You are right, I missed that this was not a list (no '-' in front of
enum).
I would not be able to do this right without tool assistance.
Sam
>
> All the rest made sense and i fixed that for the upcoming v2.
> Thanks for having a look!
> -- Guido
>
> >
> > > +
> > > + port: true
> > > + reg:
> > > + maxItems: 1
> > > + description: DSI virtual channel
> > > +
> > > + avdd-supply:
> > > + description: Positive analog power supply
> > > +
> > > + avee-supply:
> > > + description: Negative analog power supply
> > > +
> > > + vddi-supply:
> > > + description: 1.8V I/O voltage supply
> > > +
> > > + reset-gpios:
> > > + description: GPIO used for the reset pin
> > > + maxItems: 1
> > Use reset-gpios: true as we already have it in panel-common.yaml
> >
> > > +
> > > + backlight:
> > > + description: Backlight used by the panel
> > > + $ref: "/schemas/types.yaml#/definitions/phandle"
> > Use backlight from panel-common.yaml.
> >
> > > +
> > > +required:
> > > + - compatible
> > > + - reg
> > > + - avdd-supply
> > > + - avee-supply
> > > + - vddi-supply
> > > + - reset-gpios
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > + - |
> > > + #include <dt-bindings/gpio/gpio.h>
> > > +
> > > + dsi {
> > My personal preference is indent with 4 spaces in examples but there are
> > no rules so feel free to ignore.
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > + panel@0 {
> > > + compatible = "mantix,mlaf057we51-x";
> > > + reg = <0>;
> > > + avdd-supply = <®_avdd>;
> > > + avee-supply = <®_avee>;
> > > + vddi-supply = <®_1v8_p>;
> > > + reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>;
> > > + backlight = <&backlight>;
> > > + };
> > > + };
> > I think we need an ampty line here.
> > > +...
> > > --
> > > 2.26.2
> > >
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-15 21:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 13:36 [PATCH 0/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel Guido Günther
2020-08-14 13:36 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add mantix vendor prefix Guido Günther
2020-08-14 13:36 ` [PATCH 2/3] dt-bindings: Add Mantix MLAF057WE51-X panel bindings Guido Günther
2020-08-15 8:39 ` Sam Ravnborg
2020-08-15 16:47 ` Guido Günther
2020-08-15 21:08 ` Sam Ravnborg [this message]
2020-08-14 13:36 ` [PATCH 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel Guido Günther
2020-08-15 9:32 ` Sam Ravnborg
2020-08-15 21:28 ` Guido Günther
2020-08-15 10:02 ` Sam Ravnborg
2020-08-15 10:40 ` Guido Günther
2020-08-15 10:46 ` Sam Ravnborg
2020-08-15 12:55 ` Sam Ravnborg
2020-08-15 16:25 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200815210802.GA1242831@ravnborg.org \
--to=sam@ravnborg.org \
--cc=agx@sigxcpu.org \
--cc=airlied@linux.ie \
--cc=allen.chen@ite.com.tw \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=daniel@0x0f.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mchehab+huawei@kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).