Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

[Markus Elfring]

> When of_property_read_u32_array() returns an error code,
> a pairing refcount decrement is needed to keep np's refcount balanced.

Can another imperative wording be helpful for the change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151

Would an other commit message be a bit nicer?


…
> +++ b/drivers/video/backlight/sky81452-backlight.c
> @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
>  					num_entry);
>  		if (ret < 0) {
>  			dev_err(dev, "led-sources node is invalid.\n");
> +			of_node_put(np);
>  			return ERR_PTR(-EINVAL);
>  		}

I propose to add the jump target “put_node” so that a bit of common exception
handling code can be better reused at the end of this function implementation.

Regards,
Markus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

[Lee Jones]

On Wed, 19 Aug 2020, Markus Elfring wrote:

> > When of_property_read_u32_array() returns an error code,
> > a pairing refcount decrement is needed to keep np's refcount balanced.
> 
> Can another imperative wording be helpful for the change description?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151
> 
> Would an other commit message be a bit nicer?
> 
> 
> …
> > +++ b/drivers/video/backlight/sky81452-backlight.c
> > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
> >  					num_entry);
> >  		if (ret < 0) {
> >  			dev_err(dev, "led-sources node is invalid.\n");
> > +			of_node_put(np);
> >  			return ERR_PTR(-EINVAL);
> >  		}
> 
> I propose to add the jump target “put_node” so that a bit of common exception
> handling code can be better reused at the end of this function implementation.
> 
> Regards,
> Markus

You can safely ignore any review comments from Markus!

However, this patch doesn't appear to be in my inbox.

Any ideas as to why?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

[Markus Elfring]

>>> +++ b/drivers/video/backlight/sky81452-backlight.c
>>> @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
>>>  					num_entry);
>>>  		if (ret < 0) {
>>>  			dev_err(dev, "led-sources node is invalid.\n");
>>> +			of_node_put(np);
>>>  			return ERR_PTR(-EINVAL);
>>>  		}
>>
>> I propose to add the jump target “put_node” so that a bit of common exception
>> handling code can be better reused at the end of this function implementation.
…
> You can safely ignore any review comments from Markus!

How does this feedback fit to the Linux coding style?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n475

Regards,
Markus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

[dinghao.liu]

> On Wed, 19 Aug 2020, Markus Elfring wrote:
> 
> > > When of_property_read_u32_array() returns an error code,
> > > a pairing refcount decrement is needed to keep np's refcount balanced.
> > 
> > Can another imperative wording be helpful for the change description?
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151
> > 
> > Would an other commit message be a bit nicer?
> > 
> > 
> > …
> > > +++ b/drivers/video/backlight/sky81452-backlight.c
> > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
> > >  					num_entry);
> > >  		if (ret < 0) {
> > >  			dev_err(dev, "led-sources node is invalid.\n");
> > > +			of_node_put(np);
> > >  			return ERR_PTR(-EINVAL);
> > >  		}
> > 
> > I propose to add the jump target “put_node” so that a bit of common exception
> > handling code can be better reused at the end of this function implementation.
> > 
> > Regards,
> > Markus
> 
> You can safely ignore any review comments from Markus!
> 
> However, this patch doesn't appear to be in my inbox.
> 
> Any ideas as to why?
> 
> -- 
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog

Thank you for your advice. My outbox shows that this patch
has reached your email server successfully. Maybe this
ended up in your junk mail file?

Regards,
Dinghao
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

[Lee Jones]

On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote:

> > On Wed, 19 Aug 2020, Markus Elfring wrote:
> > 
> > > > When of_property_read_u32_array() returns an error code,
> > > > a pairing refcount decrement is needed to keep np's refcount balanced.
> > > 
> > > Can another imperative wording be helpful for the change description?
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151
> > > 
> > > Would an other commit message be a bit nicer?
> > > 
> > > 
> > > …
> > > > +++ b/drivers/video/backlight/sky81452-backlight.c
> > > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
> > > >  					num_entry);
> > > >  		if (ret < 0) {
> > > >  			dev_err(dev, "led-sources node is invalid.\n");
> > > > +			of_node_put(np);
> > > >  			return ERR_PTR(-EINVAL);
> > > >  		}
> > > 
> > > I propose to add the jump target “put_node” so that a bit of common exception
> > > handling code can be better reused at the end of this function implementation.
> > > 
> > > Regards,
> > > Markus
> > 
> > You can safely ignore any review comments from Markus!
> > 
> > However, this patch doesn't appear to be in my inbox.
> > 
> > Any ideas as to why?
> > 
> 
> Thank you for your advice. My outbox shows that this patch
> has reached your email server successfully. Maybe this
> ended up in your junk mail file?

This has happened recently, so I was sure to check.

Not there either unfortunately.

Would you be kind enough to bounce/resend please?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

[dinghao.liu]

> On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote:
> 
> > > On Wed, 19 Aug 2020, Markus Elfring wrote:
> > > 
> > > > > When of_property_read_u32_array() returns an error code,
> > > > > a pairing refcount decrement is needed to keep np's refcount balanced.
> > > > 
> > > > Can another imperative wording be helpful for the change description?
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151
> > > > 
> > > > Would an other commit message be a bit nicer?
> > > > 
> > > > 
> > > > …
> > > > > +++ b/drivers/video/backlight/sky81452-backlight.c
> > > > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
> > > > >  					num_entry);
> > > > >  		if (ret < 0) {
> > > > >  			dev_err(dev, "led-sources node is invalid.\n");
> > > > > +			of_node_put(np);
> > > > >  			return ERR_PTR(-EINVAL);
> > > > >  		}
> > > > 
> > > > I propose to add the jump target “put_node” so that a bit of common exception
> > > > handling code can be better reused at the end of this function implementation.
> > > > 
> > > > Regards,
> > > > Markus
> > > 
> > > You can safely ignore any review comments from Markus!
> > > 
> > > However, this patch doesn't appear to be in my inbox.
> > > 
> > > Any ideas as to why?
> > > 
> > 
> > Thank you for your advice. My outbox shows that this patch
> > has reached your email server successfully. Maybe this
> > ended up in your junk mail file?
> 
> This has happened recently, so I was sure to check.
> 
> Not there either unfortunately.
> 
> Would you be kind enough to bounce/resend please?
> 

Sure.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

[Lee Jones]

On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote:

> > On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote:
> > 
> > > > On Wed, 19 Aug 2020, Markus Elfring wrote:
> > > > 
> > > > > > When of_property_read_u32_array() returns an error code,
> > > > > > a pairing refcount decrement is needed to keep np's refcount balanced.
> > > > > 
> > > > > Can another imperative wording be helpful for the change description?
> > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151
> > > > > 
> > > > > Would an other commit message be a bit nicer?
> > > > > 
> > > > > 
> > > > > …
> > > > > > +++ b/drivers/video/backlight/sky81452-backlight.c
> > > > > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
> > > > > >  					num_entry);
> > > > > >  		if (ret < 0) {
> > > > > >  			dev_err(dev, "led-sources node is invalid.\n");
> > > > > > +			of_node_put(np);
> > > > > >  			return ERR_PTR(-EINVAL);
> > > > > >  		}
> > > > > 
> > > > > I propose to add the jump target “put_node” so that a bit of common exception
> > > > > handling code can be better reused at the end of this function implementation.
> > > > > 
> > > > > Regards,
> > > > > Markus
> > > > 
> > > > You can safely ignore any review comments from Markus!
> > > > 
> > > > However, this patch doesn't appear to be in my inbox.
> > > > 
> > > > Any ideas as to why?
> > > > 
> > > 
> > > Thank you for your advice. My outbox shows that this patch
> > > has reached your email server successfully. Maybe this
> > > ended up in your junk mail file?
> > 
> > This has happened recently, so I was sure to check.
> > 
> > Not there either unfortunately.
> > 
> > Would you be kind enough to bounce/resend please?
> 
> Sure.

Looks like you sent it *only* to me.  Please keep everyone else in Cc
when doing that, or I can't respond to everyone.

Anyway, besides the subject line (which I can fix easily), the patch
looks good to me, but Daniel T must review.

Reviewed-by: Lee Jones <lee.jones@linaro.org>

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

[Daniel Thompson]

On Thu, Aug 20, 2020 at 08:49:16AM +0100, Lee Jones wrote:
> On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote:
> 
> > > On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote:
> > > 
> > > > > On Wed, 19 Aug 2020, Markus Elfring wrote:
> > > > > 
> > > > > > > When of_property_read_u32_array() returns an error code,
> > > > > > > a pairing refcount decrement is needed to keep np's refcount balanced.
> > > > > > 
> > > > > > Can another imperative wording be helpful for the change description?
> > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151
> > > > > > 
> > > > > > Would an other commit message be a bit nicer?
> > > > > > 
> > > > > > 
> > > > > > …
> > > > > > > +++ b/drivers/video/backlight/sky81452-backlight.c
> > > > > > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
> > > > > > >  					num_entry);
> > > > > > >  		if (ret < 0) {
> > > > > > >  			dev_err(dev, "led-sources node is invalid.\n");
> > > > > > > +			of_node_put(np);
> > > > > > >  			return ERR_PTR(-EINVAL);
> > > > > > >  		}
> > > > > > 
> > > > > > I propose to add the jump target “put_node” so that a bit of common exception
> > > > > > handling code can be better reused at the end of this function implementation.
> > > > > > 
> > > > > > Regards,
> > > > > > Markus
> > > > > 
> > > > > You can safely ignore any review comments from Markus!
> > > > > 
> > > > > However, this patch doesn't appear to be in my inbox.
> > > > > 
> > > > > Any ideas as to why?
> > > > > 
> > > > 
> > > > Thank you for your advice. My outbox shows that this patch
> > > > has reached your email server successfully. Maybe this
> > > > ended up in your junk mail file?
> > > 
> > > This has happened recently, so I was sure to check.
> > > 
> > > Not there either unfortunately.
> > > 
> > > Would you be kind enough to bounce/resend please?
> > 
> > Sure.
> 
> Looks like you sent it *only* to me.  Please keep everyone else in Cc
> when doing that, or I can't respond to everyone.
> 
> Anyway, besides the subject line (which I can fix easily), the patch
> looks good to me, but Daniel T must review.

I've already offered a Reviewed-by for this patch. Perhaps it landed in
the same place as the original patch...


Daniel.

> 
> Reviewed-by: Lee Jones <lee.jones@linaro.org>

> 
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

[Lee Jones]

On Thu, 20 Aug 2020, Daniel Thompson wrote:

> On Thu, Aug 20, 2020 at 08:49:16AM +0100, Lee Jones wrote:
> > On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote:
> > 
> > > > On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote:
> > > > 
> > > > > > On Wed, 19 Aug 2020, Markus Elfring wrote:
> > > > > > 
> > > > > > > > When of_property_read_u32_array() returns an error code,
> > > > > > > > a pairing refcount decrement is needed to keep np's refcount balanced.
> > > > > > > 
> > > > > > > Can another imperative wording be helpful for the change description?
> > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151
> > > > > > > 
> > > > > > > Would an other commit message be a bit nicer?
> > > > > > > 
> > > > > > > 
> > > > > > > …
> > > > > > > > +++ b/drivers/video/backlight/sky81452-backlight.c
> > > > > > > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
> > > > > > > >  					num_entry);
> > > > > > > >  		if (ret < 0) {
> > > > > > > >  			dev_err(dev, "led-sources node is invalid.\n");
> > > > > > > > +			of_node_put(np);
> > > > > > > >  			return ERR_PTR(-EINVAL);
> > > > > > > >  		}
> > > > > > > 
> > > > > > > I propose to add the jump target “put_node” so that a bit of common exception
> > > > > > > handling code can be better reused at the end of this function implementation.
> > > > > > > 
> > > > > > > Regards,
> > > > > > > Markus
> > > > > > 
> > > > > > You can safely ignore any review comments from Markus!
> > > > > > 
> > > > > > However, this patch doesn't appear to be in my inbox.
> > > > > > 
> > > > > > Any ideas as to why?
> > > > > > 
> > > > > 
> > > > > Thank you for your advice. My outbox shows that this patch
> > > > > has reached your email server successfully. Maybe this
> > > > > ended up in your junk mail file?
> > > > 
> > > > This has happened recently, so I was sure to check.
> > > > 
> > > > Not there either unfortunately.
> > > > 
> > > > Would you be kind enough to bounce/resend please?
> > > 
> > > Sure.
> > 
> > Looks like you sent it *only* to me.  Please keep everyone else in Cc
> > when doing that, or I can't respond to everyone.
> > 
> > Anyway, besides the subject line (which I can fix easily), the patch
> > looks good to me, but Daniel T must review.
> 
> I've already offered a Reviewed-by for this patch. Perhaps it landed in
> the same place as the original patch...

Patch applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel