[PATCH] virtio-gpu api: fix 64/32 compat issue with blob implementation

[PATCH] virtio-gpu api: fix 64/32 compat issue with blob implementation

[Gurchetan Singh]

From: Alistair Delva <adelva@google.com>

We encountered this issue when booting blob with a 32-bit kernel.
The implementation doesn't match v6 of the virtio-spec change, so fix
this.

Fixes: ff886cbdcc44 ("virtio-gpu api: blob resources")
Signed-off-by: Alistair Delva <adelva@google.com>
---
 include/uapi/linux/virtio_gpu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_gpu.h
index fa2ae4a1da5f9..0ec6b610402cb 100644
--- a/include/uapi/linux/virtio_gpu.h
+++ b/include/uapi/linux/virtio_gpu.h
@@ -388,9 +388,9 @@ struct virtio_gpu_resource_create_blob {
 	/* zero is invalid blob mem */
 	__le32 blob_mem;
 	__le32 blob_flags;
+	__le32 nr_entries;
 	__le64 blob_id;
 	__le64 size;
-	__le32 nr_entries;
 	/*
 	 * sizeof(nr_entries * virtio_gpu_mem_entry) bytes follow
 	 */
-- 
2.26.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] virtio-gpu api: fix 64/32 compat issue with blob implementation

[Gerd Hoffmann]

On Tue, Sep 29, 2020 at 02:53:33PM -0700, Gurchetan Singh wrote:
> From: Alistair Delva <adelva@google.com>
> 
> We encountered this issue when booting blob with a 32-bit kernel.
> The implementation doesn't match v6 of the virtio-spec change, so fix
> this.
> 
> Fixes: ff886cbdcc44 ("virtio-gpu api: blob resources")
> Signed-off-by: Alistair Delva <adelva@google.com>

Pushed to drm-misc-next.

thanks,
  Gerd

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel