From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: "Marek Vasut" <marex@denx.de>,
devicetree@vger.kernel.org, "Guido Günther" <agx@sigxcpu.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/7] drm: mxsfb: Add support for the bus-width DT property
Date: Wed, 7 Oct 2020 04:24:38 +0300 [thread overview]
Message-ID: <20201007012438.27970-8-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20201007012438.27970-1-laurent.pinchart@ideasonboard.com>
A new bus-width DT property has been introduced in the bindings to allow
overriding the bus width. Support it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 26 ++++++++++++++++++++++++++
drivers/gpu/drm/mxsfb/mxsfb_drv.h | 2 ++
drivers/gpu/drm/mxsfb/mxsfb_kms.c | 8 ++++++--
3 files changed, 34 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 35122aef037b..d52cf8a506a5 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -114,10 +114,36 @@ static int mxsfb_attach_bridge(struct mxsfb_drm_private *mxsfb)
{
struct drm_device *drm = mxsfb->drm;
struct drm_connector_list_iter iter;
+ struct device_node *ep;
struct drm_panel *panel;
struct drm_bridge *bridge;
+ u32 bus_width = 0;
int ret;
+ ep = of_graph_get_endpoint_by_regs(drm->dev->of_node, 0, 0);
+ if (!ep)
+ return -ENODEV;
+
+ of_property_read_u32(ep, "bus-width", &bus_width);
+ of_node_put(ep);
+
+ switch (bus_width) {
+ case 16:
+ mxsfb->bus_format = MEDIA_BUS_FMT_RGB565_1X16;
+ break;
+ case 18:
+ mxsfb->bus_format = MEDIA_BUS_FMT_RGB666_1X18;
+ break;
+ case 24:
+ mxsfb->bus_format = MEDIA_BUS_FMT_RGB888_1X24;
+ break;
+ case 0:
+ break;
+ default:
+ DRM_DEV_ERROR(drm->dev, "Invalid bus-width %u", bus_width);
+ return -ENODEV;
+ }
+
ret = drm_of_find_panel_or_bridge(drm->dev->of_node, 0, 0, &panel,
&bridge);
if (ret)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.h b/drivers/gpu/drm/mxsfb/mxsfb_drv.h
index 399d23e91ed1..c4f7a8a0c891 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.h
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.h
@@ -32,6 +32,8 @@ struct mxsfb_drm_private {
struct clk *clk_axi;
struct clk *clk_disp_axi;
+ u32 bus_format;
+
struct drm_device *drm;
struct {
struct drm_plane primary;
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
index b721b8b262ce..6d512f346918 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
@@ -50,11 +50,15 @@ static void mxsfb_set_formats(struct mxsfb_drm_private *mxsfb)
{
struct drm_device *drm = mxsfb->drm;
const u32 format = mxsfb->crtc.primary->state->fb->format->format;
- u32 bus_format = MEDIA_BUS_FMT_RGB888_1X24;
+ u32 bus_format;
u32 ctrl, ctrl1;
- if (mxsfb->connector->display_info.num_bus_formats)
+ if (mxsfb->bus_format)
+ bus_format = mxsfb->bus_format;
+ else if (mxsfb->connector->display_info.num_bus_formats)
bus_format = mxsfb->connector->display_info.bus_formats[0];
+ else
+ bus_format = MEDIA_BUS_FMT_RGB888_1X24;
DRM_DEV_DEBUG_DRIVER(drm->dev, "Using bus_format: 0x%08X\n",
bus_format);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-07 1:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 1:24 [PATCH v2 0/7] drm: mxsfb: Allow overriding bus width Laurent Pinchart
2020-10-07 1:24 ` [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML Laurent Pinchart
2020-10-07 8:32 ` Marek Vasut
2020-10-07 8:43 ` Lucas Stach
2020-10-07 8:55 ` Marek Vasut
2020-10-07 13:33 ` Laurent Pinchart
2020-10-07 14:20 ` Marek Vasut
2020-10-07 16:00 ` Rob Herring
2020-10-07 16:02 ` Rob Herring
2020-10-09 23:52 ` Laurent Pinchart
2021-01-15 7:59 ` Martin Kepplinger
2021-01-15 22:25 ` Laurent Pinchart
2021-01-16 6:41 ` Martin Kepplinger
2020-10-07 1:24 ` [PATCH v2 2/7] dt-bindings: display: mxsfb: Add and fix compatible strings Laurent Pinchart
2020-10-07 8:35 ` Marek Vasut
2020-10-07 16:01 ` Rob Herring
2020-10-07 1:24 ` [PATCH v2 3/7] dt-bindings: display: mxsfb: Add a bus-width endpoint property Laurent Pinchart
2020-10-07 8:40 ` Marek Vasut
2020-10-09 23:58 ` Laurent Pinchart
2020-10-10 8:47 ` Marek Vasut
2020-10-13 2:06 ` Laurent Pinchart
2020-10-13 11:03 ` Marek Vasut
2020-10-07 16:03 ` Rob Herring
2020-10-07 1:24 ` [PATCH v2 4/7] ARM: dts: imx: Fix LCDIF compatible strings Laurent Pinchart
2020-10-07 1:24 ` [PATCH v2 5/7] arm64: dts: imx8mq: " Laurent Pinchart
2020-10-07 1:24 ` [PATCH v2 6/7] ARM: dts: imx: Remove unneeded LCDIF disp_axi clock Laurent Pinchart
2020-10-07 1:24 ` Laurent Pinchart [this message]
2020-10-10 0:01 ` [PATCH v2 8/7] dt-bindings: display: mxsfb: Add compatible for i.MX8MM Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007012438.27970-8-laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).