* [PATCH] drm/panel: st7703: Make jh057n00900_panel_desc static
@ 2020-09-12 3:38 Jason Yan
2020-09-13 12:00 ` Guido Günther
2020-10-17 6:16 ` Sam Ravnborg
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-09-12 3:38 UTC (permalink / raw)
To: thierry.reding, sam, airlied, daniel, linus.walleij, agx, megous,
dri-devel
Cc: Hulk Robot, Jason Yan
This eliminates the following sparse warning:
drivers/gpu/drm/panel/panel-sitronix-st7703.c:156:26: warning: symbol
'jh057n00900_panel_desc' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
index c22e7c49e077..7c07a8fc8506 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
@@ -153,7 +153,7 @@ static const struct drm_display_mode jh057n00900_mode = {
.height_mm = 130,
};
-struct st7703_panel_desc jh057n00900_panel_desc = {
+static struct st7703_panel_desc jh057n00900_panel_desc = {
.mode = &jh057n00900_mode,
.lanes = 4,
.mode_flags = MIPI_DSI_MODE_VIDEO |
--
2.25.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: st7703: Make jh057n00900_panel_desc static
2020-09-12 3:38 [PATCH] drm/panel: st7703: Make jh057n00900_panel_desc static Jason Yan
@ 2020-09-13 12:00 ` Guido Günther
2020-10-17 6:16 ` Sam Ravnborg
1 sibling, 0 replies; 3+ messages in thread
From: Guido Günther @ 2020-09-13 12:00 UTC (permalink / raw)
To: Jason Yan; +Cc: megous, airlied, dri-devel, Hulk Robot, thierry.reding, sam
Hi,
On Sat, Sep 12, 2020 at 11:38:09AM +0800, Jason Yan wrote:
> This eliminates the following sparse warning:
>
> drivers/gpu/drm/panel/panel-sitronix-st7703.c:156:26: warning: symbol
> 'jh057n00900_panel_desc' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/gpu/drm/panel/panel-sitronix-st7703.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> index c22e7c49e077..7c07a8fc8506 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> @@ -153,7 +153,7 @@ static const struct drm_display_mode jh057n00900_mode = {
> .height_mm = 130,
> };
>
> -struct st7703_panel_desc jh057n00900_panel_desc = {
> +static struct st7703_panel_desc jh057n00900_panel_desc = {
Can we even make it `static const`? With that
Reviewed-by: Guido Günther <agx@sigxcpu.org>
Cheers,
-- Guido
> .mode = &jh057n00900_mode,
> .lanes = 4,
> .mode_flags = MIPI_DSI_MODE_VIDEO |
> --
> 2.25.4
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: st7703: Make jh057n00900_panel_desc static
2020-09-12 3:38 [PATCH] drm/panel: st7703: Make jh057n00900_panel_desc static Jason Yan
2020-09-13 12:00 ` Guido Günther
@ 2020-10-17 6:16 ` Sam Ravnborg
1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2020-10-17 6:16 UTC (permalink / raw)
To: Jason Yan; +Cc: megous, airlied, dri-devel, Hulk Robot, thierry.reding, agx
Hi Jason,
On Sat, Sep 12, 2020 at 11:38:09AM +0800, Jason Yan wrote:
> This eliminates the following sparse warning:
>
> drivers/gpu/drm/panel/panel-sitronix-st7703.c:156:26: warning: symbol
> 'jh057n00900_panel_desc' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Thanks, applied to drm-misc-next with Guidos suggestions.
The patch will appear in -next in a few weeks.
Sam
> ---
> drivers/gpu/drm/panel/panel-sitronix-st7703.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> index c22e7c49e077..7c07a8fc8506 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> @@ -153,7 +153,7 @@ static const struct drm_display_mode jh057n00900_mode = {
> .height_mm = 130,
> };
>
> -struct st7703_panel_desc jh057n00900_panel_desc = {
> +static struct st7703_panel_desc jh057n00900_panel_desc = {
> .mode = &jh057n00900_mode,
> .lanes = 4,
> .mode_flags = MIPI_DSI_MODE_VIDEO |
> --
> 2.25.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-17 6:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-12 3:38 [PATCH] drm/panel: st7703: Make jh057n00900_panel_desc static Jason Yan
2020-09-13 12:00 ` Guido Günther
2020-10-17 6:16 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).