* [PATCH] drm: bridge: adv7511: make adv7511_hdmi_hw_params() static
@ 2020-09-12 3:38 Jason Yan
2020-09-28 14:07 ` Jason Yan
2020-10-17 6:17 ` Sam Ravnborg
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-09-12 3:38 UTC (permalink / raw)
To: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel, bogdan.togorean, dri-devel
Cc: Hulk Robot, Jason Yan
This eliminates the following sparse warning:
drivers/gpu/drm/bridge/adv7511/adv7511_audio.c:58:5: warning: symbol
'adv7511_hdmi_hw_params' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
index f101dd2819b5..45838bd08d37 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
@@ -55,9 +55,9 @@ static int adv7511_update_cts_n(struct adv7511 *adv7511)
return 0;
}
-int adv7511_hdmi_hw_params(struct device *dev, void *data,
- struct hdmi_codec_daifmt *fmt,
- struct hdmi_codec_params *hparms)
+static int adv7511_hdmi_hw_params(struct device *dev, void *data,
+ struct hdmi_codec_daifmt *fmt,
+ struct hdmi_codec_params *hparms)
{
struct adv7511 *adv7511 = dev_get_drvdata(dev);
unsigned int audio_source, i2s_format = 0;
--
2.25.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: bridge: adv7511: make adv7511_hdmi_hw_params() static
2020-09-12 3:38 [PATCH] drm: bridge: adv7511: make adv7511_hdmi_hw_params() static Jason Yan
@ 2020-09-28 14:07 ` Jason Yan
2020-10-17 6:17 ` Sam Ravnborg
1 sibling, 0 replies; 3+ messages in thread
From: Jason Yan @ 2020-09-28 14:07 UTC (permalink / raw)
To: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel, bogdan.togorean, dri-devel
Cc: Hulk Robot
ping...
在 2020/9/12 11:38, Jason Yan 写道:
> This eliminates the following sparse warning:
>
> drivers/gpu/drm/bridge/adv7511/adv7511_audio.c:58:5: warning: symbol
> 'adv7511_hdmi_hw_params' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> index f101dd2819b5..45838bd08d37 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> @@ -55,9 +55,9 @@ static int adv7511_update_cts_n(struct adv7511 *adv7511)
> return 0;
> }
>
> -int adv7511_hdmi_hw_params(struct device *dev, void *data,
> - struct hdmi_codec_daifmt *fmt,
> - struct hdmi_codec_params *hparms)
> +static int adv7511_hdmi_hw_params(struct device *dev, void *data,
> + struct hdmi_codec_daifmt *fmt,
> + struct hdmi_codec_params *hparms)
> {
> struct adv7511 *adv7511 = dev_get_drvdata(dev);
> unsigned int audio_source, i2s_format = 0;
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: bridge: adv7511: make adv7511_hdmi_hw_params() static
2020-09-12 3:38 [PATCH] drm: bridge: adv7511: make adv7511_hdmi_hw_params() static Jason Yan
2020-09-28 14:07 ` Jason Yan
@ 2020-10-17 6:17 ` Sam Ravnborg
1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2020-10-17 6:17 UTC (permalink / raw)
To: Jason Yan
Cc: jernej.skrabec, jonas, airlied, Hulk Robot, narmstrong,
dri-devel, a.hajda, Laurent.pinchart, bogdan.togorean
Hi Jason,
Thanks, applied to drm-misc-next.
As for the other patch this will appear in -next in a few weeks.
Sam
On Sat, Sep 12, 2020 at 11:38:26AM +0800, Jason Yan wrote:
> This eliminates the following sparse warning:
>
> drivers/gpu/drm/bridge/adv7511/adv7511_audio.c:58:5: warning: symbol
> 'adv7511_hdmi_hw_params' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> index f101dd2819b5..45838bd08d37 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> @@ -55,9 +55,9 @@ static int adv7511_update_cts_n(struct adv7511 *adv7511)
> return 0;
> }
>
> -int adv7511_hdmi_hw_params(struct device *dev, void *data,
> - struct hdmi_codec_daifmt *fmt,
> - struct hdmi_codec_params *hparms)
> +static int adv7511_hdmi_hw_params(struct device *dev, void *data,
> + struct hdmi_codec_daifmt *fmt,
> + struct hdmi_codec_params *hparms)
> {
> struct adv7511 *adv7511 = dev_get_drvdata(dev);
> unsigned int audio_source, i2s_format = 0;
> --
> 2.25.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-17 6:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-12 3:38 [PATCH] drm: bridge: adv7511: make adv7511_hdmi_hw_params() static Jason Yan
2020-09-28 14:07 ` Jason Yan
2020-10-17 6:17 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).