* [PATCH] drm/bridge: lvds-codec: Use dev_err_probe for error handling
@ 2020-10-20 9:36 Biju Das
2020-10-20 9:43 ` Geert Uytterhoeven
2020-11-08 14:46 ` Sam Ravnborg
0 siblings, 2 replies; 3+ messages in thread
From: Biju Das @ 2020-10-20 9:36 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, David Airlie, Sam Ravnborg, Daniel Vetter
Cc: Jernej Skrabec, Geert Uytterhoeven, Jonas Karlman,
Prabhakar Mahadev Lad, Chris Paterson, dri-devel, Biju Das,
linux-renesas-soc, Laurent Pinchart, Biju Das
dev_err_probe function simplifies error handling. So use the same in probe
function wherever possible.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
drivers/gpu/drm/bridge/lvds-codec.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c
index f52ccffc1bd1..dcf579a4cf83 100644
--- a/drivers/gpu/drm/bridge/lvds-codec.c
+++ b/drivers/gpu/drm/bridge/lvds-codec.c
@@ -80,7 +80,6 @@ static int lvds_codec_probe(struct platform_device *pdev)
struct device_node *panel_node;
struct drm_panel *panel;
struct lvds_codec *lvds_codec;
- int ret;
lvds_codec = devm_kzalloc(dev, sizeof(*lvds_codec), GFP_KERNEL);
if (!lvds_codec)
@@ -90,13 +89,9 @@ static int lvds_codec_probe(struct platform_device *pdev)
lvds_codec->connector_type = (uintptr_t)of_device_get_match_data(dev);
lvds_codec->vcc = devm_regulator_get(lvds_codec->dev, "power");
- if (IS_ERR(lvds_codec->vcc)) {
- ret = PTR_ERR(lvds_codec->vcc);
- if (ret != -EPROBE_DEFER)
- dev_err(lvds_codec->dev,
- "Unable to get \"vcc\" supply: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(lvds_codec->vcc))
+ return dev_err_probe(dev, PTR_ERR(lvds_codec->vcc),
+ "Unable to get \"vcc\" supply\n");
lvds_codec->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown",
GPIOD_OUT_HIGH);
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: lvds-codec: Use dev_err_probe for error handling
2020-10-20 9:36 [PATCH] drm/bridge: lvds-codec: Use dev_err_probe for error handling Biju Das
@ 2020-10-20 9:43 ` Geert Uytterhoeven
2020-11-08 14:46 ` Sam Ravnborg
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-10-20 9:43 UTC (permalink / raw)
To: Biju Das
Cc: Jernej Skrabec, Geert Uytterhoeven, Neil Armstrong, David Airlie,
Prabhakar Mahadev Lad, Jonas Karlman, Chris Paterson,
DRI Development, Biju Das, Linux-Renesas, Andrzej Hajda,
Laurent Pinchart, Sam Ravnborg
On Tue, Oct 20, 2020 at 11:37 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> dev_err_probe function simplifies error handling. So use the same in probe
> function wherever possible.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: lvds-codec: Use dev_err_probe for error handling
2020-10-20 9:36 [PATCH] drm/bridge: lvds-codec: Use dev_err_probe for error handling Biju Das
2020-10-20 9:43 ` Geert Uytterhoeven
@ 2020-11-08 14:46 ` Sam Ravnborg
1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2020-11-08 14:46 UTC (permalink / raw)
To: Biju Das
Cc: Jernej Skrabec, Geert Uytterhoeven, Neil Armstrong, David Airlie,
Jonas Karlman, Prabhakar Mahadev Lad, dri-devel, Biju Das,
linux-renesas-soc, Andrzej Hajda, Chris Paterson,
Laurent Pinchart
Hi Biju
On Tue, Oct 20, 2020 at 10:36:55AM +0100, Biju Das wrote:
> dev_err_probe function simplifies error handling. So use the same in probe
> function wherever possible.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Thanks, applied to drm-misc-next
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-08 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20 9:36 [PATCH] drm/bridge: lvds-codec: Use dev_err_probe for error handling Biju Das
2020-10-20 9:43 ` Geert Uytterhoeven
2020-11-08 14:46 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).