From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@intel.com>,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH 2/2] drm/atomic: Pass the full state to CRTC atomic begin and flush
Date: Thu, 29 Oct 2020 15:55:37 +0200 [thread overview]
Message-ID: <20201029135537.GB6112@intel.com> (raw)
In-Reply-To: <20201028123222.1732139-2-maxime@cerno.tech>
On Wed, Oct 28, 2020 at 01:32:22PM +0100, Maxime Ripard wrote:
> The current atomic helpers have either their object state being passed as
> an argument or the full atomic state.
>
> The former is the pattern that was done at first, before switching to the
> latter for new hooks or when it was needed.
>
> Let's start convert all the remaining helpers to provide a consistent
> interface, starting with the CRTC's atomic_begin and atomic_flush.
>
> The conversion was done using the coccinelle script below, built tested on
> all the drivers and actually tested on vc4.
>
<snip>
> @@ -323,26 +323,27 @@ static void ingenic_drm_crtc_atomic_begin(struct drm_crtc *crtc,
> }
>
> static void ingenic_drm_crtc_atomic_flush(struct drm_crtc *crtc,
> - struct drm_crtc_state *oldstate)
> + struct drm_atomic_state *state)
> {
> struct ingenic_drm *priv = drm_crtc_get_priv(crtc);
> - struct drm_crtc_state *state = crtc->state;
> - struct drm_pending_vblank_event *event = state->event;
> + struct drm_crtc_state *crtc_state = crtc->state;
Looks like quite a few places could use a followup to
switch to get_{old,new}_crtc_state().
Patch lgtm
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-29 13:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 12:32 [PATCH 1/2] drm/atomic: Pass the full state to CRTC atomic_check Maxime Ripard
2020-10-28 12:32 ` [PATCH 2/2] drm/atomic: Pass the full state to CRTC atomic begin and flush Maxime Ripard
2020-10-29 8:27 ` Daniel Vetter
2020-10-29 13:55 ` Ville Syrjälä [this message]
2020-10-31 9:59 ` Maxime Ripard
2020-10-31 12:35 ` Ville Syrjälä
2020-10-31 14:08 ` Daniel Vetter
2020-11-02 8:17 ` Thomas Zimmermann
2020-11-02 9:57 ` Daniel Vetter
2020-11-02 11:53 ` Maxime Ripard
2020-10-29 13:50 ` [PATCH 1/2] drm/atomic: Pass the full state to CRTC atomic_check Ville Syrjälä
2020-10-31 9:57 ` Maxime Ripard
2020-11-02 8:09 ` Thomas Zimmermann
2020-11-02 11:39 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029135537.GB6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=maxime@cerno.tech \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).