From: Maxime Ripard <maxime@cerno.tech>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@intel.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/atomic: Pass the full state to CRTC atomic_check
Date: Mon, 2 Nov 2020 12:39:51 +0100 [thread overview]
Message-ID: <20201102113951.6o4nv4rifwkchipd@gilmour.lan> (raw)
In-Reply-To: <7b292ba6-c16f-efd8-d71a-5ae4d07a6b7a@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 447 bytes --]
Hi,
On Mon, Nov 02, 2020 at 09:09:44AM +0100, Thomas Zimmermann wrote:
> I read through the patch and it looks correct to me. The naming is a bit
> off at times. For example, ast_state should now probably be called
> ast_crtc_state. But that's not a blocker IMHO.
Yeah, a few places have odd names, but to be fair I didn't change them :)
The ast_crtc_state struct you're mentioning used to be called ast_state
before the patch as well.
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-11-02 13:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 12:32 [PATCH 1/2] drm/atomic: Pass the full state to CRTC atomic_check Maxime Ripard
2020-10-28 12:32 ` [PATCH 2/2] drm/atomic: Pass the full state to CRTC atomic begin and flush Maxime Ripard
2020-10-29 8:27 ` Daniel Vetter
2020-10-29 13:55 ` Ville Syrjälä
2020-10-31 9:59 ` Maxime Ripard
2020-10-31 12:35 ` Ville Syrjälä
2020-10-31 14:08 ` Daniel Vetter
2020-11-02 8:17 ` Thomas Zimmermann
2020-11-02 9:57 ` Daniel Vetter
2020-11-02 11:53 ` Maxime Ripard
2020-10-29 13:50 ` [PATCH 1/2] drm/atomic: Pass the full state to CRTC atomic_check Ville Syrjälä
2020-10-31 9:57 ` Maxime Ripard
2020-11-02 8:09 ` Thomas Zimmermann
2020-11-02 11:39 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102113951.6o4nv4rifwkchipd@gilmour.lan \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).