* [PATCH] drm/kmb: Remove an unnecessary NULL check
@ 2020-11-17 7:21 Dan Carpenter
2020-11-20 1:19 ` Chrisanthus, Anitha
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2020-11-17 7:21 UTC (permalink / raw)
To: Anitha Chrisanthus; +Cc: David Airlie, kernel-janitors, Edmund Dea, dri-devel
The NULL checking isn't done consistently in this function and it leads
to a static checker warning:
drivers/gpu/drm/kmb/kmb_drv.c:561 kmb_pm_suspend()
error: we previously assumed 'drm' could be null (see line 559)
Fortunately "drm" cannot be NULL at this point so the check can just be
removed.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/kmb/kmb_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c
index 8c43b136765c..5ff392644603 100644
--- a/drivers/gpu/drm/kmb/kmb_drv.c
+++ b/drivers/gpu/drm/kmb/kmb_drv.c
@@ -557,7 +557,7 @@ MODULE_DEVICE_TABLE(of, kmb_of_match);
static int __maybe_unused kmb_pm_suspend(struct device *dev)
{
struct drm_device *drm = dev_get_drvdata(dev);
- struct kmb_drm_private *kmb = drm ? to_kmb(drm) : NULL;
+ struct kmb_drm_private *kmb = to_kmb(drm);
drm_kms_helper_poll_disable(drm);
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH] drm/kmb: Remove an unnecessary NULL check
2020-11-17 7:21 [PATCH] drm/kmb: Remove an unnecessary NULL check Dan Carpenter
@ 2020-11-20 1:19 ` Chrisanthus, Anitha
2020-11-20 8:21 ` Sam Ravnborg
0 siblings, 1 reply; 6+ messages in thread
From: Chrisanthus, Anitha @ 2020-11-20 1:19 UTC (permalink / raw)
To: Dan Carpenter; +Cc: David Airlie, kernel-janitors, Dea, Edmund J, dri-devel
Looks good to me.
Anitha
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Sent: Monday, November 16, 2020 11:22 PM
> To: Chrisanthus, Anitha <anitha.chrisanthus@intel.com>
> Cc: Dea, Edmund J <edmund.j.dea@intel.com>; David Airlie <airlied@linux.ie>;
> Daniel Vetter <daniel@ffwll.ch>; dri-devel@lists.freedesktop.org; kernel-
> janitors@vger.kernel.org
> Subject: [PATCH] drm/kmb: Remove an unnecessary NULL check
>
> The NULL checking isn't done consistently in this function and it leads
> to a static checker warning:
>
> drivers/gpu/drm/kmb/kmb_drv.c:561 kmb_pm_suspend()
> error: we previously assumed 'drm' could be null (see line 559)
>
> Fortunately "drm" cannot be NULL at this point so the check can just be
> removed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/kmb/kmb_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/kmb/kmb_drv.c
> b/drivers/gpu/drm/kmb/kmb_drv.c
> index 8c43b136765c..5ff392644603 100644
> --- a/drivers/gpu/drm/kmb/kmb_drv.c
> +++ b/drivers/gpu/drm/kmb/kmb_drv.c
> @@ -557,7 +557,7 @@ MODULE_DEVICE_TABLE(of, kmb_of_match);
> static int __maybe_unused kmb_pm_suspend(struct device *dev)
> {
> struct drm_device *drm = dev_get_drvdata(dev);
> - struct kmb_drm_private *kmb = drm ? to_kmb(drm) : NULL;
> + struct kmb_drm_private *kmb = to_kmb(drm);
>
> drm_kms_helper_poll_disable(drm);
>
> --
> 2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/kmb: Remove an unnecessary NULL check
2020-11-20 1:19 ` Chrisanthus, Anitha
@ 2020-11-20 8:21 ` Sam Ravnborg
2020-11-20 8:34 ` Thomas Zimmermann
0 siblings, 1 reply; 6+ messages in thread
From: Sam Ravnborg @ 2020-11-20 8:21 UTC (permalink / raw)
To: Chrisanthus, Anitha
Cc: David Airlie, Dea, Edmund J, kernel-janitors, dri-devel, Dan Carpenter
Hi Anitha.
On Fri, Nov 20, 2020 at 01:19:06AM +0000, Chrisanthus, Anitha wrote:
> Looks good to me.
Can we get either an "Acked-by:" or "Reviewed-by:"?
Then we can use this while applying.
Any news on gettting commit access yourself?
If not, then try to ping on the open ticket.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/kmb: Remove an unnecessary NULL check
2020-11-20 8:21 ` Sam Ravnborg
@ 2020-11-20 8:34 ` Thomas Zimmermann
2020-11-20 17:28 ` Chrisanthus, Anitha
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Zimmermann @ 2020-11-20 8:34 UTC (permalink / raw)
To: Sam Ravnborg, Chrisanthus, Anitha
Cc: David Airlie, kernel-janitors, Dea, Edmund J, Dan Carpenter, dri-devel
[-- Attachment #1.1.1.1: Type: text/plain, Size: 848 bytes --]
Hi
Am 20.11.20 um 09:21 schrieb Sam Ravnborg:
> Hi Anitha.
>
> On Fri, Nov 20, 2020 at 01:19:06AM +0000, Chrisanthus, Anitha wrote:
>> Looks good to me.
>
> Can we get either an "Acked-by:" or "Reviewed-by:"?
> Then we can use this while applying.
>
> Any news on gettting commit access yourself?
> If not, then try to ping on the open ticket.
It's been acked a while ago. I sent out a reminder to Daniel Stone.
Best regards
Thomas
>
>
> Sam
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.1.1.2: OpenPGP_0x680DC11D530B7A23.asc --]
[-- Type: application/pgp-keys, Size: 7535 bytes --]
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] drm/kmb: Remove an unnecessary NULL check
2020-11-20 8:34 ` Thomas Zimmermann
@ 2020-11-20 17:28 ` Chrisanthus, Anitha
2020-11-29 22:04 ` Sam Ravnborg
0 siblings, 1 reply; 6+ messages in thread
From: Chrisanthus, Anitha @ 2020-11-20 17:28 UTC (permalink / raw)
To: Thomas Zimmermann, Sam Ravnborg
Cc: David Airlie, kernel-janitors, Dea, Edmund J, Dan Carpenter, dri-devel
> -----Original Message-----
> From: Thomas Zimmermann <tzimmermann@suse.de>
> Sent: Friday, November 20, 2020 12:34 AM
> To: Sam Ravnborg <sam@ravnborg.org>; Chrisanthus, Anitha
> <anitha.chrisanthus@intel.com>
> Cc: David Airlie <airlied@linux.ie>; Dea, Edmund J <edmund.j.dea@intel.com>;
> kernel-janitors@vger.kernel.org; dri-devel@lists.freedesktop.org; Dan
> Carpenter <dan.carpenter@oracle.com>
> Subject: Re: [PATCH] drm/kmb: Remove an unnecessary NULL check
>
> Hi
>
> Am 20.11.20 um 09:21 schrieb Sam Ravnborg:
> > Hi Anitha.
> >
> > On Fri, Nov 20, 2020 at 01:19:06AM +0000, Chrisanthus, Anitha wrote:
> >> Looks good to me.
> >
> > Can we get either an "Acked-by:" or "Reviewed-by:"?
> > Then we can use this while applying.
Sorry, forgot that.
Reviewed-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
> >
> > Any news on gettting commit access yourself?
> > If not, then try to ping on the open ticket.
>
> It's been acked a while ago. I sent out a reminder to Daniel Stone.
I did get access today, thank you! I will have to get familiar with dim and the whole process before I start pushing patches.
>
> Best regards
> Thomas
>
> >
> >
> > Sam
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/kmb: Remove an unnecessary NULL check
2020-11-20 17:28 ` Chrisanthus, Anitha
@ 2020-11-29 22:04 ` Sam Ravnborg
0 siblings, 0 replies; 6+ messages in thread
From: Sam Ravnborg @ 2020-11-29 22:04 UTC (permalink / raw)
To: Chrisanthus, Anitha
Cc: David Airlie, kernel-janitors, Dea, Edmund J, dri-devel,
Thomas Zimmermann, Dan Carpenter
Hi Anitha,
On Fri, Nov 20, 2020 at 05:28:59PM +0000, Chrisanthus, Anitha wrote:
>
>
> > -----Original Message-----
> > From: Thomas Zimmermann <tzimmermann@suse.de>
> > Sent: Friday, November 20, 2020 12:34 AM
> > To: Sam Ravnborg <sam@ravnborg.org>; Chrisanthus, Anitha
> > <anitha.chrisanthus@intel.com>
> > Cc: David Airlie <airlied@linux.ie>; Dea, Edmund J <edmund.j.dea@intel.com>;
> > kernel-janitors@vger.kernel.org; dri-devel@lists.freedesktop.org; Dan
> > Carpenter <dan.carpenter@oracle.com>
> > Subject: Re: [PATCH] drm/kmb: Remove an unnecessary NULL check
> >
> > Hi
> >
> > Am 20.11.20 um 09:21 schrieb Sam Ravnborg:
> > > Hi Anitha.
> > >
> > > On Fri, Nov 20, 2020 at 01:19:06AM +0000, Chrisanthus, Anitha wrote:
> > >> Looks good to me.
> > >
> > > Can we get either an "Acked-by:" or "Reviewed-by:"?
> > > Then we can use this while applying.
> Sorry, forgot that.
> Reviewed-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
Thanks, patch is now pushed to drm-misc-next.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-29 22:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17 7:21 [PATCH] drm/kmb: Remove an unnecessary NULL check Dan Carpenter
2020-11-20 1:19 ` Chrisanthus, Anitha
2020-11-20 8:21 ` Sam Ravnborg
2020-11-20 8:34 ` Thomas Zimmermann
2020-11-20 17:28 ` Chrisanthus, Anitha
2020-11-29 22:04 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).