* [PATCH][next] drm/vkms: Fix missing kmalloc allocation failure check
@ 2021-01-15 13:09 Colin King
2021-01-15 14:10 ` Sumera Priyadarsini
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2021-01-15 13:09 UTC (permalink / raw)
To: Rodrigo Siqueira, Melissa Wen, Haneen Mohammed, Daniel Vetter,
David Airlie, Sumera Priyadarsini, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently the kmalloc allocation for config is not being null
checked and could potentially lead to a null pointer dereference.
Fix this by adding the missing null check.
Addresses-Coverity: ("Dereference null return value")
Fixes: 2df7af93fdad ("drm/vkms: Add vkms_config type")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/vkms/vkms_drv.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 708f7f54001d..2173b82606f6 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -188,7 +188,11 @@ static int vkms_create(struct vkms_config *config)
static int __init vkms_init(void)
{
- struct vkms_config *config = kmalloc(sizeof(*config), GFP_KERNEL);
+ struct vkms_config *config;
+
+ config = kmalloc(sizeof(*config), GFP_KERNEL);
+ if (!config)
+ return -ENOMEM;
default_config = config;
--
2.29.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] drm/vkms: Fix missing kmalloc allocation failure check
2021-01-15 13:09 [PATCH][next] drm/vkms: Fix missing kmalloc allocation failure check Colin King
@ 2021-01-15 14:10 ` Sumera Priyadarsini
2021-01-15 20:58 ` Melissa Wen
0 siblings, 1 reply; 3+ messages in thread
From: Sumera Priyadarsini @ 2021-01-15 14:10 UTC (permalink / raw)
To: Colin King
Cc: Haneen Mohammed, Rodrigo Siqueira, David Airlie, kernel-janitors,
linux-kernel, dri-devel, Melissa Wen
On Fri, Jan 15, 2021 at 6:39 PM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the kmalloc allocation for config is not being null
> checked and could potentially lead to a null pointer dereference.
> Fix this by adding the missing null check.
>
> Addresses-Coverity: ("Dereference null return value")
> Fixes: 2df7af93fdad ("drm/vkms: Add vkms_config type")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Good catch, thank you!
Reviewed-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
> ---
> drivers/gpu/drm/vkms/vkms_drv.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 708f7f54001d..2173b82606f6 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -188,7 +188,11 @@ static int vkms_create(struct vkms_config *config)
>
> static int __init vkms_init(void)
> {
> - struct vkms_config *config = kmalloc(sizeof(*config), GFP_KERNEL);
> + struct vkms_config *config;
> +
> + config = kmalloc(sizeof(*config), GFP_KERNEL);
> + if (!config)
> + return -ENOMEM;
>
> default_config = config;
>
> --
> 2.29.2
>
regards,
Sumera
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] drm/vkms: Fix missing kmalloc allocation failure check
2021-01-15 14:10 ` Sumera Priyadarsini
@ 2021-01-15 20:58 ` Melissa Wen
0 siblings, 0 replies; 3+ messages in thread
From: Melissa Wen @ 2021-01-15 20:58 UTC (permalink / raw)
To: Sumera Priyadarsini
Cc: Haneen Mohammed, Rodrigo Siqueira, David Airlie, kernel-janitors,
linux-kernel, dri-devel, Colin King
On 01/15, Sumera Priyadarsini wrote:
> On Fri, Jan 15, 2021 at 6:39 PM Colin King <colin.king@canonical.com> wrote:
> >
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently the kmalloc allocation for config is not being null
> > checked and could potentially lead to a null pointer dereference.
> > Fix this by adding the missing null check.
> >
> > Addresses-Coverity: ("Dereference null return value")
> > Fixes: 2df7af93fdad ("drm/vkms: Add vkms_config type")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Good catch, thank you!
>
> Reviewed-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Applied to drm-misc-next.
Thanks,
Melissa Wen
> > ---
> > drivers/gpu/drm/vkms/vkms_drv.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> > index 708f7f54001d..2173b82606f6 100644
> > --- a/drivers/gpu/drm/vkms/vkms_drv.c
> > +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> > @@ -188,7 +188,11 @@ static int vkms_create(struct vkms_config *config)
> >
> > static int __init vkms_init(void)
> > {
> > - struct vkms_config *config = kmalloc(sizeof(*config), GFP_KERNEL);
> > + struct vkms_config *config;
> > +
> > + config = kmalloc(sizeof(*config), GFP_KERNEL);
> > + if (!config)
> > + return -ENOMEM;
> >
> > default_config = config;
> >
> > --
> > 2.29.2
> >
> regards,
> Sumera
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-15 20:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 13:09 [PATCH][next] drm/vkms: Fix missing kmalloc allocation failure check Colin King
2021-01-15 14:10 ` Sumera Priyadarsini
2021-01-15 20:58 ` Melissa Wen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).