From: Maxime Ripard <maxime@cerno.tech>
To: Lucas Nussbaum <lucas@debian.org>,
Ryutaroh Matsumoto <ryutaroh@ict.e.titech.ac.jp>
Cc: Dom Cobley <popcornmix@gmail.com>,
dri-devel@lists.freedesktop.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH 1/2] drm/vc4: Correct lbm size and calculation
Date: Thu, 21 Jan 2021 12:04:06 +0100 [thread overview]
Message-ID: <20210121110406.yeb4zoqwwgilyrhq@gilmour> (raw)
In-Reply-To: <20210121105759.1262699-1-maxime@cerno.tech>
[-- Attachment #1.1: Type: text/plain, Size: 1042 bytes --]
Hi Lucas, Ryutaroh,
On Thu, Jan 21, 2021 at 11:57:58AM +0100, Maxime Ripard wrote:
> From: Dom Cobley <popcornmix@gmail.com>
>
> LBM base address is measured in units of pixels per cycle.
> That is 4 for 2711 (hvs5) and 2 for 2708.
>
> We are wasting 75% of lbm by indexing without the scaling.
> But we were also using too high a size for the lbm resulting
> in partial corruption (right hand side) of vertically
> scaled images, usually at 4K or lower resolutions with more layers.
>
> The physical RAM of LBM on 2711 is 8 * 1920 * 16 * 12-bit
> (pixels are stored 12-bits per component regardless of format).
>
> The LBM adress indexes work in units of pixels per clock,
> so for 4 pixels per clock that means we have 32 * 1920 = 60K
>
> Fixes: c54619b0bfb3 ("drm/vc4: Add support for the BCM2711 HVS5")
> Signed-off-by: Dom Cobley <popcornmix@gmail.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
This one should fix your issue
Feel free to test it and let me know if it's not the case
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-22 8:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 10:57 [PATCH 1/2] drm/vc4: Correct lbm size and calculation Maxime Ripard
2021-01-21 10:57 ` [PATCH 2/2] drm/vc4: Correct POS1_SCL for hvs5 Maxime Ripard
2021-01-22 10:14 ` Dave Stevenson
2021-01-23 8:05 ` Lucas Nussbaum
2021-01-23 11:14 ` Ryutaroh Matsumoto
2021-01-25 10:54 ` Maxime Ripard
2021-01-21 11:04 ` Maxime Ripard [this message]
2021-01-21 16:26 ` [PATCH 1/2] drm/vc4: Correct lbm size and calculation Lucas Nussbaum
2021-01-22 5:11 ` Ryutaroh Matsumoto
2021-01-22 10:54 ` Maxime Ripard
2021-01-22 10:12 ` Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121110406.yeb4zoqwwgilyrhq@gilmour \
--to=maxime@cerno.tech \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lucas@debian.org \
--cc=popcornmix@gmail.com \
--cc=ryutaroh@ict.e.titech.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).