* [PATCH] drm/nouveau: remove set but not used variable ‘pdev’ in nouveau_bios_init
@ 2021-01-23 1:30 Ye Bin
2021-02-03 8:20 ` Thomas Zimmermann
0 siblings, 1 reply; 2+ messages in thread
From: Ye Bin @ 2021-01-23 1:30 UTC (permalink / raw)
To: bskeggs, airlied, daniel, dri-devel, nouveau, linux-kernel
Cc: Hulk Robot, Ye Bin
Fix follow warning:
drivers/gpu/drm/nouveau/nouveau_bios.c:2086:18: warning: variable ‘pdev’ set but not used [-Wunused-but-set-variable]
struct pci_dev *pdev;
^~~~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
drivers/gpu/drm/nouveau/nouveau_bios.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
index 7cc683b8dc7a..e8c445eb1100 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bios.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
@@ -2083,13 +2083,11 @@ nouveau_bios_init(struct drm_device *dev)
{
struct nouveau_drm *drm = nouveau_drm(dev);
struct nvbios *bios = &drm->vbios;
- struct pci_dev *pdev;
int ret;
/* only relevant for PCI devices */
if (!dev_is_pci(dev->dev))
return 0;
- pdev = to_pci_dev(dev->dev);
if (!NVInitVBIOS(dev))
return -ENODEV;
--
2.25.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/nouveau: remove set but not used variable ‘pdev’ in nouveau_bios_init
2021-01-23 1:30 [PATCH] drm/nouveau: remove set but not used variable ‘pdev’ in nouveau_bios_init Ye Bin
@ 2021-02-03 8:20 ` Thomas Zimmermann
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Zimmermann @ 2021-02-03 8:20 UTC (permalink / raw)
To: Ye Bin, bskeggs, airlied, daniel, dri-devel, nouveau, linux-kernel
Cc: Hulk Robot
[-- Attachment #1.1.1: Type: text/plain, Size: 1325 bytes --]
Applied to drm-misc-next. Thanks for the patch!
Am 23.01.21 um 02:30 schrieb Ye Bin:
> Fix follow warning:
> drivers/gpu/drm/nouveau/nouveau_bios.c:2086:18: warning: variable ‘pdev’ set but not used [-Wunused-but-set-variable]
> struct pci_dev *pdev;
> ^~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_bios.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 7cc683b8dc7a..e8c445eb1100 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -2083,13 +2083,11 @@ nouveau_bios_init(struct drm_device *dev)
> {
> struct nouveau_drm *drm = nouveau_drm(dev);
> struct nvbios *bios = &drm->vbios;
> - struct pci_dev *pdev;
> int ret;
>
> /* only relevant for PCI devices */
> if (!dev_is_pci(dev->dev))
> return 0;
> - pdev = to_pci_dev(dev->dev);
>
> if (!NVInitVBIOS(dev))
> return -ENODEV;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-03 8:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-23 1:30 [PATCH] drm/nouveau: remove set but not used variable ‘pdev’ in nouveau_bios_init Ye Bin
2021-02-03 8:20 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).