From: Emil Velikov <emil.l.velikov@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: Pekka Paalanen <pekka.paalanen@collabora.com>,
emil.l.velikov@gmail.com,
James Park <james.park@lagfreegames.com>
Subject: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard
Date: Tue, 2 Feb 2021 22:47:04 +0000 [thread overview]
Message-ID: <20210202224704.2794318-1-emil.l.velikov@gmail.com> (raw)
Currently, the drm_fourcc.h header depends on drm.h for __u32 and __u64.
At the same time drm.h pulls a lot of unneeded symbols.
Add new guard DRM_FOURCC_STANDALONE, which when set will use local
declaration of said symbols.
When used on linux - this is a trivial but only when building in strict c99
mode. One is welcome to ignore the warning, silence it or use c11. If neither
of the three is an option, then do _not_ set the new guard.
Cc: James Park <james.park@lagfreegames.com>
Cc: Pekka Paalanen <pekka.paalanen@collabora.com>
Cc: Simon Ser <contact@emersion.fr>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
---
As mentioned before - there's little point in having yet another header
since keeping those in sync has been a PITA in the past.
---
include/uapi/drm/drm_fourcc.h | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index 6f0628eb13a6..c1522902f6c9 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
@@ -24,7 +24,26 @@
#ifndef DRM_FOURCC_H
#define DRM_FOURCC_H
+/*
+ * Define DRM_FOURCC_STANDALONE you're interested only FOURCC and do not want
+ * to pull drm.h into your application.
+ */
+#ifdef DRM_FOURCC_STANDALONE
+#if defined(__linux__)
+
+#include <linux/types.h>
+
+#else /* One of the BSDs */
+
+#include <stdint.h>
+typedef uint32_t __u32;
+typedef uint64_t __u64;
+
+#endif /* __linux __ */
+
+#else
#include "drm.h"
+#endif /* DRM_FOURCC_STANDALONE */
#if defined(__cplusplus)
extern "C" {
--
2.30.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2021-02-02 22:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 22:47 Emil Velikov [this message]
2021-02-02 23:24 ` [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard James Park
2021-02-03 0:56 ` Emil Velikov
2021-02-03 1:20 ` James Park
2021-02-03 9:24 ` Simon Ser
2021-02-03 9:27 ` Simon Ser
2021-02-03 10:08 ` Emil Velikov
2021-02-03 10:15 ` Simon Ser
2021-02-03 11:03 ` Emil Velikov
2021-02-03 13:47 ` Simon Ser
2021-02-03 14:13 ` Emil Velikov
2021-02-03 14:20 ` Simon Ser
2021-02-04 4:24 ` James Park
2021-02-04 4:25 ` James Park
2021-02-04 11:52 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202224704.2794318-1-emil.l.velikov@gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=james.park@lagfreegames.com \
--cc=pekka.paalanen@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).