From: Emil Velikov <emil.l.velikov@gmail.com>
To: Simon Ser <contact@emersion.fr>
Cc: Pekka Paalanen <pekka.paalanen@collabora.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
James Park <james.park@lagfreegames.com>
Subject: Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard
Date: Thu, 4 Feb 2021 11:52:57 +0000 [thread overview]
Message-ID: <CACvgo51ZY+tL6h5OnV5ERWieLRR-zNws33iFFTCz082sKswe8Q@mail.gmail.com> (raw)
In-Reply-To: <3YZGYeCokyp-fEABJS4acHkPKfFBiHtsL3lM8fRBI-ma8q--4afeisOnhmHURa5iF8AVHpUdw2E7fKCe5bug9PX4j8HJ4btFWDdWepXftBY=@emersion.fr>
On Wed, 3 Feb 2021 at 14:21, Simon Ser <contact@emersion.fr> wrote:
>
> On Wednesday, February 3rd, 2021 at 3:13 PM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>
> > As said before, there are multiple ways to handle this without
> > introducing yet another UAPI header. I don't see why you're dismissing
> > all of them, can you elaborate?
>
> Because I hate it when I have to adjust my compiler flags because of
> some third-party header.
>
Mentioned it over IRC, but adding here for posterity:
I think it's perfectly normal to be unhappy, angry, etc but please
mention that upfront so that we know what we're working with.
In this case, one gets to deal with the warning, if they _explicitly_ opts-in.
That said, v2 should be warnings free in virtually any permutation.
> Can you explain what were the past issues with introducing a new
> header?
Few that come to mind:
- distros shipping partial header set
- mixing headers, be that any of:
- distros shipping kernel headers, as well as libdrm
- system libdrm and local - be that imported or installed to /usr/local/
A bigger annoyance that just came to mind - having the same header
name/guard within your project as the one introduced.
So while it may seem like bikeshed, there are many subtle ways where
things can go bad :-\
HTH
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2021-02-04 11:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 22:47 [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard Emil Velikov
2021-02-02 23:24 ` James Park
2021-02-03 0:56 ` Emil Velikov
2021-02-03 1:20 ` James Park
2021-02-03 9:24 ` Simon Ser
2021-02-03 9:27 ` Simon Ser
2021-02-03 10:08 ` Emil Velikov
2021-02-03 10:15 ` Simon Ser
2021-02-03 11:03 ` Emil Velikov
2021-02-03 13:47 ` Simon Ser
2021-02-03 14:13 ` Emil Velikov
2021-02-03 14:20 ` Simon Ser
2021-02-04 4:24 ` James Park
2021-02-04 4:25 ` James Park
2021-02-04 11:52 ` Emil Velikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACvgo51ZY+tL6h5OnV5ERWieLRR-zNws33iFFTCz082sKswe8Q@mail.gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=contact@emersion.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=james.park@lagfreegames.com \
--cc=pekka.paalanen@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).