From: James Qian Wang <james.qian.wang@arm.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: nd@arm.com, airlied@linux.ie, liviu.dudau@arm.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
mihail.atanassov@arm.com
Subject: Re: [PATCH] drm/komeda: convert sysfs sprintf/snprintf family to sysfs_emit
Date: Fri, 5 Feb 2021 16:56:09 +0800 [thread overview]
Message-ID: <20210205085609.GA1531584@jamwan02-TSP300> (raw)
In-Reply-To: <1612420708-25297-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Thu, Feb 04, 2021 at 02:38:28PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warning:
>
> ./drivers/gpu/drm/arm/display/komeda/komeda_dev.c:97:8-16: WARNING: use
> scnprintf or sprintf.
>
> ./drivers/gpu/drm/arm/display/komeda/komeda_dev.c:88:8-16: WARNING: use
> scnprintf or sprintf.
>
> ./drivers/gpu/drm/arm/display/komeda/komeda_dev.c:65:8-16: WARNING: use
> scnprintf or sprintf.
>
> Reported-by: Abaci Robot<abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
Looks good to me, thank you for the patch.
Reviewed-by: James Qian Wang <james.qian.wang@arm.com>
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index ca891ae..cc7664c 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -62,7 +62,7 @@ static void komeda_debugfs_init(struct komeda_dev *mdev)
> {
> struct komeda_dev *mdev = dev_to_mdev(dev);
>
> - return snprintf(buf, PAGE_SIZE, "0x%08x\n", mdev->chip.core_id);
> + return sysfs_emit(buf, "0x%08x\n", mdev->chip.core_id);
> }
> static DEVICE_ATTR_RO(core_id);
>
> @@ -85,7 +85,7 @@ static void komeda_debugfs_init(struct komeda_dev *mdev)
> if (pipe->layers[i]->layer_type == KOMEDA_FMT_RICH_LAYER)
> config_id.n_richs++;
> }
> - return snprintf(buf, PAGE_SIZE, "0x%08x\n", config_id.value);
> + return sysfs_emit(buf, "0x%08x\n", config_id.value);
> }
> static DEVICE_ATTR_RO(config_id);
>
> @@ -94,7 +94,7 @@ static void komeda_debugfs_init(struct komeda_dev *mdev)
> {
> struct komeda_dev *mdev = dev_to_mdev(dev);
>
> - return snprintf(buf, PAGE_SIZE, "%lu\n", clk_get_rate(mdev->aclk));
> + return sysfs_emit(buf, "%lu\n", clk_get_rate(mdev->aclk));
> }
> static DEVICE_ATTR_RO(aclk_hz);
>
> --
> 1.8.3.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-02-05 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 6:38 [PATCH] drm/komeda: convert sysfs sprintf/snprintf family to sysfs_emit Jiapeng Chong
2021-02-05 8:56 ` James Qian Wang [this message]
2021-03-30 1:25 [PATCH] drm/komeda: Convert " Tian Tao
2021-04-07 8:59 ` Carsten Haitzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205085609.GA1531584@jamwan02-TSP300 \
--to=james.qian.wang@arm.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=mihail.atanassov@arm.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).