From: Carsten Haitzler <carsten.haitzler@foss.arm.com>
To: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/komeda: Convert sysfs sprintf/snprintf family to sysfs_emit
Date: Wed, 7 Apr 2021 09:59:05 +0100 [thread overview]
Message-ID: <4868a149-fefe-469b-2054-3e4e52d15450@foss.arm.com> (raw)
In-Reply-To: <1617067518-31091-1-git-send-email-tiantao6@hisilicon.com>
On 3/30/21 2:25 AM, Tian Tao wrote:
> Fix the following coccicheck warning:
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c:97:8-16: WARNING:
> use scnprintf or sprintf
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c:88:8-16: WARNING:
> use scnprintf or sprintf
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c:65:8-16: WARNING:
> use scnprintf or sprintf
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index ca891ae..cc7664c 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -62,7 +62,7 @@ core_id_show(struct device *dev, struct device_attribute *attr, char *buf)
> {
> struct komeda_dev *mdev = dev_to_mdev(dev);
>
> - return snprintf(buf, PAGE_SIZE, "0x%08x\n", mdev->chip.core_id);
> + return sysfs_emit(buf, "0x%08x\n", mdev->chip.core_id);
> }
> static DEVICE_ATTR_RO(core_id);
>
> @@ -85,7 +85,7 @@ config_id_show(struct device *dev, struct device_attribute *attr, char *buf)
> if (pipe->layers[i]->layer_type == KOMEDA_FMT_RICH_LAYER)
> config_id.n_richs++;
> }
> - return snprintf(buf, PAGE_SIZE, "0x%08x\n", config_id.value);
> + return sysfs_emit(buf, "0x%08x\n", config_id.value);
> }
> static DEVICE_ATTR_RO(config_id);
>
> @@ -94,7 +94,7 @@ aclk_hz_show(struct device *dev, struct device_attribute *attr, char *buf)
> {
> struct komeda_dev *mdev = dev_to_mdev(dev);
>
> - return snprintf(buf, PAGE_SIZE, "%lu\n", clk_get_rate(mdev->aclk));
> + return sysfs_emit(buf, "%lu\n", clk_get_rate(mdev->aclk));
> }
> static DEVICE_ATTR_RO(aclk_hz);
>
>
Looks OK to me.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-07 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 1:25 [PATCH] drm/komeda: Convert sysfs sprintf/snprintf family to sysfs_emit Tian Tao
2021-04-07 8:59 ` Carsten Haitzler [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-04 6:38 [PATCH] drm/komeda: convert " Jiapeng Chong
2021-02-05 8:56 ` James Qian Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4868a149-fefe-469b-2054-3e4e52d15450@foss.arm.com \
--to=carsten.haitzler@foss.arm.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).