* [PATCH 16/30] scsi: aacraid: commsup: Repair formatting issue in aac_handle_sa_aif()'s header
2021-03-03 14:46 [PATCH 00/30] [Set 1] Rid W=1 warnings in SCSI Lee Jones
@ 2021-03-03 14:46 ` Lee Jones
2021-03-03 14:46 ` [PATCH 17/30] scsi: lpfc: lpfc_sli: Fix a bunch of kernel-doc issues Lee Jones
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2021-03-03 14:46 UTC (permalink / raw)
To: lee.jones
Cc: linux-scsi, Martin K. Petersen, James E.J. Bottomley,
linux-kernel, dri-devel, linaro-mm-sig, PMC-Sierra, Inc,
Adaptec OEM Raid Solutions, Christian König, linux-media
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/commsup.c:334: warning: expecting prototype for fib_deallocate(). Prototype was for fib_dealloc() instead
drivers/scsi/aacraid/commsup.c:1961: warning: expecting prototype for aac_handle_sa_aif Handle a message from the firmware(). Prototype was for aac_handle_sa_aif() instead
Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "PMC-Sierra, Inc" <aacraid@pmc-sierra.com>
Cc: linux-scsi@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/aacraid/commsup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index 0ae0d1fa2b507..54eb4d41bc2c2 100644
--- a/drivers/scsi/aacraid/commsup.c
+++ b/drivers/scsi/aacraid/commsup.c
@@ -323,7 +323,7 @@ void aac_fib_init(struct fib *fibptr)
}
/**
- * fib_deallocate - deallocate a fib
+ * fib_dealloc - deallocate a fib
* @fibptr: fib to deallocate
*
* Will deallocate and return to the free pool the FIB pointed to by the
@@ -1950,7 +1950,7 @@ void aac_src_reinit_aif_worker(struct work_struct *work)
}
/**
- * aac_handle_sa_aif Handle a message from the firmware
+ * aac_handle_sa_aif - Handle a message from the firmware
* @dev: Which adapter this fib is from
* @fibptr: Pointer to fibptr from adapter
*
--
2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 17/30] scsi: lpfc: lpfc_sli: Fix a bunch of kernel-doc issues
2021-03-03 14:46 [PATCH 00/30] [Set 1] Rid W=1 warnings in SCSI Lee Jones
2021-03-03 14:46 ` [PATCH 16/30] scsi: aacraid: commsup: Repair formatting issue in aac_handle_sa_aif()'s header Lee Jones
@ 2021-03-03 14:46 ` Lee Jones
2021-03-16 2:15 ` [PATCH 00/30] [Set 1] Rid W=1 warnings in SCSI Martin K. Petersen
2021-03-19 3:46 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2021-03-03 14:46 UTC (permalink / raw)
To: lee.jones
Cc: Dick Kennedy, linux-scsi, Martin K. Petersen,
Christian König, James E.J. Bottomley, linux-kernel,
dri-devel, James Smart, linaro-mm-sig, linux-media
Fixes the following W=1 kernel build warning(s):
drivers/scsi/lpfc/lpfc_sli.c:9654: warning: expecting prototype for lpfc_sli_iocb2wqe(). Prototype was for lpfc_sli4_iocb2wqe() instead
drivers/scsi/lpfc/lpfc_sli.c:10439: warning: Function parameter or member 'phba' not described in 'lpfc_sli_issue_fcp_io'
drivers/scsi/lpfc/lpfc_sli.c:10439: warning: Function parameter or member 'ring_number' not described in 'lpfc_sli_issue_fcp_io'
drivers/scsi/lpfc/lpfc_sli.c:10439: warning: Function parameter or member 'piocb' not described in 'lpfc_sli_issue_fcp_io'
drivers/scsi/lpfc/lpfc_sli.c:10439: warning: Function parameter or member 'flag' not described in 'lpfc_sli_issue_fcp_io'
drivers/scsi/lpfc/lpfc_sli.c:14189: warning: expecting prototype for lpfc_sli4_sp_process_cq(). Prototype was for __lpfc_sli4_sp_process_cq() instead
drivers/scsi/lpfc/lpfc_sli.c:14754: warning: expecting prototype for lpfc_sli4_hba_process_cq(). Prototype was for lpfc_sli4_dly_hba_process_cq() instead
drivers/scsi/lpfc/lpfc_sli.c:17230: warning: expecting prototype for lpfc_sli4_free_xri(). Prototype was for __lpfc_sli4_free_xri() instead
drivers/scsi/lpfc/lpfc_sli.c:18950: warning: expecting prototype for lpfc_sli4_free_rpi(). Prototype was for __lpfc_sli4_free_rpi() instead
Cc: James Smart <james.smart@broadcom.com>
Cc: Dick Kennedy <dick.kennedy@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: linux-scsi@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/lpfc/lpfc_sli.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index fa1a714a78f09..9801193983ff0 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -9635,7 +9635,7 @@ lpfc_sli4_bpl2sgl(struct lpfc_hba *phba, struct lpfc_iocbq *piocbq,
}
/**
- * lpfc_sli_iocb2wqe - Convert the IOCB to a work queue entry.
+ * lpfc_sli4_iocb2wqe - Convert the IOCB to a work queue entry.
* @phba: Pointer to HBA context object.
* @iocbq: Pointer to command iocb.
* @wqe: Pointer to the work queue entry.
@@ -10421,7 +10421,7 @@ __lpfc_sli_issue_iocb_s4(struct lpfc_hba *phba, uint32_t ring_number,
return 0;
}
-/**
+/*
* lpfc_sli_issue_fcp_io - Wrapper func for issuing fcp i/o
*
* This routine wraps the actual fcp i/o function for issusing WQE for sli-4
@@ -14170,7 +14170,7 @@ __lpfc_sli4_process_cq(struct lpfc_hba *phba, struct lpfc_queue *cq,
}
/**
- * lpfc_sli4_sp_process_cq - Process a slow-path event queue entry
+ * __lpfc_sli4_sp_process_cq - Process a slow-path event queue entry
* @cq: pointer to CQ to process
*
* This routine calls the cq processing routine with a handler specific
@@ -14744,7 +14744,7 @@ lpfc_sli4_hba_process_cq(struct work_struct *work)
}
/**
- * lpfc_sli4_hba_process_cq - fast-path work handler when started by timer
+ * lpfc_sli4_dly_hba_process_cq - fast-path work handler when started by timer
* @work: pointer to work element
*
* translates from the work handler and calls the fast-path handler.
@@ -17218,7 +17218,7 @@ lpfc_sli4_alloc_xri(struct lpfc_hba *phba)
}
/**
- * lpfc_sli4_free_xri - Release an xri for reuse.
+ * __lpfc_sli4_free_xri - Release an xri for reuse.
* @phba: pointer to lpfc hba data structure.
* @xri: xri to release.
*
@@ -18938,7 +18938,7 @@ lpfc_sli4_alloc_rpi(struct lpfc_hba *phba)
}
/**
- * lpfc_sli4_free_rpi - Release an rpi for reuse.
+ * __lpfc_sli4_free_rpi - Release an rpi for reuse.
* @phba: pointer to lpfc hba data structure.
* @rpi: rpi to free
*
--
2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 00/30] [Set 1] Rid W=1 warnings in SCSI
2021-03-03 14:46 [PATCH 00/30] [Set 1] Rid W=1 warnings in SCSI Lee Jones
2021-03-03 14:46 ` [PATCH 16/30] scsi: aacraid: commsup: Repair formatting issue in aac_handle_sa_aif()'s header Lee Jones
2021-03-03 14:46 ` [PATCH 17/30] scsi: lpfc: lpfc_sli: Fix a bunch of kernel-doc issues Lee Jones
@ 2021-03-16 2:15 ` Martin K. Petersen
2021-03-19 3:46 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2021-03-16 2:15 UTC (permalink / raw)
To: Lee Jones
Cc: Atul Mukker, Javed Hasan, dri-devel, Gustavo A. R. Silva,
linux-scsi, Sangeetha Gnanasekaran, Sathya Prakash, James Smart,
Kashyap Desai, Nilesh Javali, PMC-Sierra, Inc,
MPT-FusionLinux.pdl, Jack Wang, MPT-FusionLinux.pdl, linux-media,
Dick Kennedy, Suganath Prabu Subramani, James E.J. Bottomley,
John Garry, Luben Tuikov, Prakash Gollapudi, linaro-mm-sig,
Hannes Reinecke, Nikith Ganigarakoppal, David Chaw,
Kumar Santhanam, Adaptec OEM Raid Solutions, Sreenivas Bagalkote,
megaraidlinux.pdl, megaraidlinux, Sreekanth Reddy,
Saurav Kashyap, Martin K. Petersen, Jason Yan, Shivasharan S,
linux-kernel, GR-QLogic-Storage-Upstream, Sumit Saxena,
Manish Rangankar, Christian König, Manoj Jose
Lee,
> This set is part of a larger effort attempting to clean-up W=1 kernel
> builds, which are currently overwhelmingly riddled with niggly little
> warnings.
Applied everything but patch 29 to 5.13/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 00/30] [Set 1] Rid W=1 warnings in SCSI
2021-03-03 14:46 [PATCH 00/30] [Set 1] Rid W=1 warnings in SCSI Lee Jones
` (2 preceding siblings ...)
2021-03-16 2:15 ` [PATCH 00/30] [Set 1] Rid W=1 warnings in SCSI Martin K. Petersen
@ 2021-03-19 3:46 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2021-03-19 3:46 UTC (permalink / raw)
To: Lee Jones
Cc: Atul Mukker, Javed Hasan, dri-devel, linux-kernel, linux-scsi,
Sangeetha Gnanasekaran, Sathya Prakash, James Smart,
Kashyap Desai, Nilesh Javali, PMC-Sierra, Inc,
GR-QLogic-Storage-Upstream, MPT-FusionLinux.pdl, Jack Wang,
MPT-FusionLinux.pdl, linux-media, Dick Kennedy,
Suganath Prabu Subramani, James E.J. Bottomley, John Garry,
Luben Tuikov, Prakash Gollapudi, linaro-mm-sig, Manoj Jose,
Nikith Ganigarakoppal, David Chaw, Kumar Santhanam,
Adaptec OEM Raid Solutions, Sreenivas Bagalkote,
megaraidlinux.pdl, megaraidlinux, Sreekanth Reddy,
Saurav Kashyap, Martin K . Petersen, Jason Yan, Shivasharan S,
Gustavo A. R. Silva, Sumit Saxena, Manish Rangankar,
Christian König, Hannes Reinecke
On Wed, 3 Mar 2021 14:46:01 +0000, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (30):
> scsi: megaraid: megaraid_mm: Fix incorrect function name in header
> scsi: megaraid: megaraid_sas_base: Fix a bunch of misnamed functions
> in their headers
> scsi: fcoe: Fix function name fcoe_set_vport_symbolic_name() in
> description
> scsi: megaraid: megaraid_mbox: Fix function name
> megaraid_queue_command_lck() in description
> scsi: fcoe: fcoe_ctlr: Fix a couple of incorrectly named functions
> scsi: aic94xx: aic94xx_hwi: Fix a couple of misnamed function names
> scsi: aacraid: aachba: Fix a few incorrectly named functions
> scsi: pm8001: pm8001_init: Provide function name and fix a misspelling
> scsi: aacraid: commctrl: Fix incorrect spelling of aac_send_raw_srb()
> scsi: bnx2fc: bnx2fc_hwi: Fix typo in bnx2fc_indicate_kcqe()
> scsi: pm8001: pm8001_sas: Provide function name
> 'pm8001_I_T_nexus_reset()' in header
> scsi: qla4xxx: ql4_os: Fix formatting issues - missing '-' and '_'
> scsi: pm8001: pm8001_ctl: Fix incorrectly named functions in headers
> scsi: aic94xx: aic94xx_sds: Fix asd_erase_nv_sector()'s header
> scsi: qla2xxx: qla_iocb: Replace __qla2x00_marker()'s missing
> underscores
> scsi: aacraid: commsup: Repair formatting issue in
> aac_handle_sa_aif()'s header
> scsi: lpfc: lpfc_sli: Fix a bunch of kernel-doc issues
> scsi: pm8001: pm8001_hwi: Fix some misnamed function descriptions
> scsi: qla4xxx: ql4_mbx: Fix kernel-doc formatting and misnaming issue
> scsi: bnx2fc: bnx2fc_tgt: Fix misnaming of bnx2fc_free_session_resc()
> scsi: aic94xx: aic94xx_dump: Remove code that has been unused for at
> least 13 years
> scsi: pm8001: pm80xx_hwi: Fix a bunch of doc-rotted function headers
> scsi: qla2xxx: qla_gs: Fix some incorrect formatting/spelling issues
> scsi: aacraid: rx: Fix misspelling of _aac_rx_init()
> scsi: lpfc: lpfc_ct: Fix formatting and misspelling issues
> scsi: libfc: fc_lport: Fix some possible copy/paste issues
> scsi: lpfc: lpfc_hbadisc: Fix incorrect naming of
> __lpfc_update_fcf_record()
> scsi: mpt3sas: mpt3sas_base: Fix misspelling of
> _base_put_smid_default_atomic()
> scsi: lpfc: lpfc_nportdisc: Fix misspelling of lpfc_defer_acc_rsp()
> scsi: mpt3sas: mpt3sas_scs: Move a little data from the stack onto the
> heap
>
> [...]
Applied to 5.13/scsi-queue, thanks!
[01/30] scsi: megaraid: megaraid_mm: Fix incorrect function name in header
https://git.kernel.org/mkp/scsi/c/bbb2c0374552
[02/30] scsi: megaraid: megaraid_sas_base: Fix a bunch of misnamed functions in their headers
https://git.kernel.org/mkp/scsi/c/616f6d8d9e16
[03/30] scsi: fcoe: Fix function name fcoe_set_vport_symbolic_name() in description
https://git.kernel.org/mkp/scsi/c/276f9aa2530a
[04/30] scsi: megaraid: megaraid_mbox: Fix function name megaraid_queue_command_lck() in description
https://git.kernel.org/mkp/scsi/c/d4f5ae21597b
[05/30] scsi: fcoe: fcoe_ctlr: Fix a couple of incorrectly named functions
https://git.kernel.org/mkp/scsi/c/dc173575097f
[06/30] scsi: aic94xx: aic94xx_hwi: Fix a couple of misnamed function names
https://git.kernel.org/mkp/scsi/c/577c65b07a55
[07/30] scsi: aacraid: aachba: Fix a few incorrectly named functions
https://git.kernel.org/mkp/scsi/c/a80218c7c565
[08/30] scsi: pm8001: pm8001_init: Provide function name and fix a misspelling
https://git.kernel.org/mkp/scsi/c/bd1050e13889
[09/30] scsi: aacraid: commctrl: Fix incorrect spelling of aac_send_raw_srb()
https://git.kernel.org/mkp/scsi/c/4c4b8cf5a109
[10/30] scsi: bnx2fc: bnx2fc_hwi: Fix typo in bnx2fc_indicate_kcqe()
https://git.kernel.org/mkp/scsi/c/52ffc08d9454
[11/30] scsi: pm8001: pm8001_sas: Provide function name 'pm8001_I_T_nexus_reset()' in header
https://git.kernel.org/mkp/scsi/c/62690c056ac0
[12/30] scsi: qla4xxx: ql4_os: Fix formatting issues - missing '-' and '_'
https://git.kernel.org/mkp/scsi/c/ecef0c9e6407
[13/30] scsi: pm8001: pm8001_ctl: Fix incorrectly named functions in headers
https://git.kernel.org/mkp/scsi/c/3978e59b6d6c
[14/30] scsi: aic94xx: aic94xx_sds: Fix asd_erase_nv_sector()'s header
https://git.kernel.org/mkp/scsi/c/3528b9abbd06
[15/30] scsi: qla2xxx: qla_iocb: Replace __qla2x00_marker()'s missing underscores
https://git.kernel.org/mkp/scsi/c/52bb80f18def
[16/30] scsi: aacraid: commsup: Repair formatting issue in aac_handle_sa_aif()'s header
https://git.kernel.org/mkp/scsi/c/53616df28199
[17/30] scsi: lpfc: lpfc_sli: Fix a bunch of kernel-doc issues
https://git.kernel.org/mkp/scsi/c/8514e2f1e2c6
[18/30] scsi: pm8001: pm8001_hwi: Fix some misnamed function descriptions
https://git.kernel.org/mkp/scsi/c/6b87e435e4bc
[19/30] scsi: qla4xxx: ql4_mbx: Fix kernel-doc formatting and misnaming issue
https://git.kernel.org/mkp/scsi/c/e39c31a7435a
[20/30] scsi: bnx2fc: bnx2fc_tgt: Fix misnaming of bnx2fc_free_session_resc()
https://git.kernel.org/mkp/scsi/c/a7f4242d1207
[21/30] scsi: aic94xx: aic94xx_dump: Remove code that has been unused for at least 13 years
https://git.kernel.org/mkp/scsi/c/241b37ac5859
[22/30] scsi: pm8001: pm80xx_hwi: Fix a bunch of doc-rotted function headers
https://git.kernel.org/mkp/scsi/c/7cdaf12ea50a
[23/30] scsi: qla2xxx: qla_gs: Fix some incorrect formatting/spelling issues
https://git.kernel.org/mkp/scsi/c/f11c8b42423f
[24/30] scsi: aacraid: rx: Fix misspelling of _aac_rx_init()
https://git.kernel.org/mkp/scsi/c/7df1daed3330
[25/30] scsi: lpfc: lpfc_ct: Fix formatting and misspelling issues
https://git.kernel.org/mkp/scsi/c/964bc8c4adb3
[26/30] scsi: libfc: fc_lport: Fix some possible copy/paste issues
https://git.kernel.org/mkp/scsi/c/4a4db603d0b7
[27/30] scsi: lpfc: lpfc_hbadisc: Fix incorrect naming of __lpfc_update_fcf_record()
https://git.kernel.org/mkp/scsi/c/3884ce1539b0
[28/30] scsi: mpt3sas: mpt3sas_base: Fix misspelling of _base_put_smid_default_atomic()
https://git.kernel.org/mkp/scsi/c/e015e0ded135
[29/30] scsi: lpfc: lpfc_nportdisc: Fix misspelling of lpfc_defer_acc_rsp()
(no commit info)
[30/30] scsi: mpt3sas: mpt3sas_scs: Move a little data from the stack onto the heap
https://git.kernel.org/mkp/scsi/c/2111ba8781da
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread