* [PATCH 1/2] dt-bindings: backlight: Add Kinetic KTD259 bindings
@ 2021-03-21 11:43 Linus Walleij
2021-03-21 11:43 ` [PATCH 2/2] backlight: ktd253: Support KTD259 Linus Walleij
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Linus Walleij @ 2021-03-21 11:43 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, dri-devel
The KTD259 is just a newer version of the KTD253 and works
all the same.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
.../bindings/leds/backlight/kinetic,ktd253.yaml | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml
index 7a6ec1f8c0f3..73fa59e62181 100644
--- a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml
+++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml
@@ -4,13 +4,13 @@
$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktd253.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: Kinetic Technologies KTD253 one-wire backlight
+title: Kinetic Technologies KTD253 and KTD259 one-wire backlight
maintainers:
- Linus Walleij <linus.walleij@linaro.org>
description: |
- The Kinetic Technologies KTD253 is a white LED backlight that is
+ The Kinetic Technologies KTD253 and KTD259 are white LED backlights
controlled by a single GPIO line. If you just turn on the backlight
it goes to maximum backlight then you can set the level of backlight
using pulses on the enable wire. This is sometimes referred to as
@@ -21,7 +21,10 @@ allOf:
properties:
compatible:
- const: kinetic,ktd253
+ items:
+ - enum:
+ - kinetic,ktd253
+ - kinetic,ktd259
enable-gpios:
description: GPIO to use to enable/disable and dim the backlight.
--
2.29.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] backlight: ktd253: Support KTD259
2021-03-21 11:43 [PATCH 1/2] dt-bindings: backlight: Add Kinetic KTD259 bindings Linus Walleij
@ 2021-03-21 11:43 ` Linus Walleij
2021-03-22 14:06 ` Daniel Thompson
2021-03-22 14:32 ` Lee Jones
2021-03-22 14:08 ` [PATCH 1/2] dt-bindings: backlight: Add Kinetic KTD259 bindings Daniel Thompson
2021-03-22 14:32 ` Lee Jones
2 siblings, 2 replies; 6+ messages in thread
From: Linus Walleij @ 2021-03-21 11:43 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, dri-devel
The KTD259 works just like KTD253 so add this compatible
to the driver.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/video/backlight/ktd253-backlight.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/ktd253-backlight.c b/drivers/video/backlight/ktd253-backlight.c
index d7b287cffd5c..a7df5bcca9da 100644
--- a/drivers/video/backlight/ktd253-backlight.c
+++ b/drivers/video/backlight/ktd253-backlight.c
@@ -173,6 +173,7 @@ static int ktd253_backlight_probe(struct platform_device *pdev)
static const struct of_device_id ktd253_backlight_of_match[] = {
{ .compatible = "kinetic,ktd253" },
+ { .compatible = "kinetic,ktd259" },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, ktd253_backlight_of_match);
--
2.29.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] backlight: ktd253: Support KTD259
2021-03-21 11:43 ` [PATCH 2/2] backlight: ktd253: Support KTD259 Linus Walleij
@ 2021-03-22 14:06 ` Daniel Thompson
2021-03-22 14:32 ` Lee Jones
1 sibling, 0 replies; 6+ messages in thread
From: Daniel Thompson @ 2021-03-22 14:06 UTC (permalink / raw)
To: Linus Walleij; +Cc: Jingoo Han, Lee Jones, dri-devel
On Sun, Mar 21, 2021 at 12:43:41PM +0100, Linus Walleij wrote:
> The KTD259 works just like KTD253 so add this compatible
> to the driver.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Oh no... there's more of them ;-) .
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
> ---
> drivers/video/backlight/ktd253-backlight.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/backlight/ktd253-backlight.c b/drivers/video/backlight/ktd253-backlight.c
> index d7b287cffd5c..a7df5bcca9da 100644
> --- a/drivers/video/backlight/ktd253-backlight.c
> +++ b/drivers/video/backlight/ktd253-backlight.c
> @@ -173,6 +173,7 @@ static int ktd253_backlight_probe(struct platform_device *pdev)
>
> static const struct of_device_id ktd253_backlight_of_match[] = {
> { .compatible = "kinetic,ktd253" },
> + { .compatible = "kinetic,ktd259" },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, ktd253_backlight_of_match);
> --
> 2.29.2
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: backlight: Add Kinetic KTD259 bindings
2021-03-21 11:43 [PATCH 1/2] dt-bindings: backlight: Add Kinetic KTD259 bindings Linus Walleij
2021-03-21 11:43 ` [PATCH 2/2] backlight: ktd253: Support KTD259 Linus Walleij
@ 2021-03-22 14:08 ` Daniel Thompson
2021-03-22 14:32 ` Lee Jones
2 siblings, 0 replies; 6+ messages in thread
From: Daniel Thompson @ 2021-03-22 14:08 UTC (permalink / raw)
To: Linus Walleij; +Cc: Jingoo Han, Lee Jones, dri-devel
On Sun, Mar 21, 2021 at 12:43:40PM +0100, Linus Walleij wrote:
> The KTD259 is just a newer version of the KTD253 and works
> all the same.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
(For Lee) Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
> ---
> .../bindings/leds/backlight/kinetic,ktd253.yaml | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml
> index 7a6ec1f8c0f3..73fa59e62181 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml
> +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml
> @@ -4,13 +4,13 @@
> $id: http://devicetree.org/schemas/leds/backlight/kinetic,ktd253.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Kinetic Technologies KTD253 one-wire backlight
> +title: Kinetic Technologies KTD253 and KTD259 one-wire backlight
>
> maintainers:
> - Linus Walleij <linus.walleij@linaro.org>
>
> description: |
> - The Kinetic Technologies KTD253 is a white LED backlight that is
> + The Kinetic Technologies KTD253 and KTD259 are white LED backlights
> controlled by a single GPIO line. If you just turn on the backlight
> it goes to maximum backlight then you can set the level of backlight
> using pulses on the enable wire. This is sometimes referred to as
> @@ -21,7 +21,10 @@ allOf:
>
> properties:
> compatible:
> - const: kinetic,ktd253
> + items:
> + - enum:
> + - kinetic,ktd253
> + - kinetic,ktd259
>
> enable-gpios:
> description: GPIO to use to enable/disable and dim the backlight.
> --
> 2.29.2
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: backlight: Add Kinetic KTD259 bindings
2021-03-21 11:43 [PATCH 1/2] dt-bindings: backlight: Add Kinetic KTD259 bindings Linus Walleij
2021-03-21 11:43 ` [PATCH 2/2] backlight: ktd253: Support KTD259 Linus Walleij
2021-03-22 14:08 ` [PATCH 1/2] dt-bindings: backlight: Add Kinetic KTD259 bindings Daniel Thompson
@ 2021-03-22 14:32 ` Lee Jones
2 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2021-03-22 14:32 UTC (permalink / raw)
To: Linus Walleij; +Cc: Jingoo Han, Daniel Thompson, dri-devel
On Sun, 21 Mar 2021, Linus Walleij wrote:
> The KTD259 is just a newer version of the KTD253 and works
> all the same.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> .../bindings/leds/backlight/kinetic,ktd253.yaml | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] backlight: ktd253: Support KTD259
2021-03-21 11:43 ` [PATCH 2/2] backlight: ktd253: Support KTD259 Linus Walleij
2021-03-22 14:06 ` Daniel Thompson
@ 2021-03-22 14:32 ` Lee Jones
1 sibling, 0 replies; 6+ messages in thread
From: Lee Jones @ 2021-03-22 14:32 UTC (permalink / raw)
To: Linus Walleij; +Cc: Jingoo Han, Daniel Thompson, dri-devel
On Sun, 21 Mar 2021, Linus Walleij wrote:
> The KTD259 works just like KTD253 so add this compatible
> to the driver.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/video/backlight/ktd253-backlight.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-22 14:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-21 11:43 [PATCH 1/2] dt-bindings: backlight: Add Kinetic KTD259 bindings Linus Walleij
2021-03-21 11:43 ` [PATCH 2/2] backlight: ktd253: Support KTD259 Linus Walleij
2021-03-22 14:06 ` Daniel Thompson
2021-03-22 14:32 ` Lee Jones
2021-03-22 14:08 ` [PATCH 1/2] dt-bindings: backlight: Add Kinetic KTD259 bindings Daniel Thompson
2021-03-22 14:32 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).