Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h

From: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
To: Jiabing Wan <wanjiabing@vivo.com>
Cc: "Anson Jacob" <Anson.Jacob@amd.com>,
	"Eric Yang" <Eric.Yang2@amd.com>,
	"Wesley Chalmers" <Wesley.Chalmers@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
	dri-devel@lists.freedesktop.org,
	"Chiawen Huang" <chiawen.huang@amd.com>,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	"Nicholas Kazlauskas" <nicholas.kazlauskas@amd.com>,
	"Meenakshikumar Somasundaram"
	<meenakshikumar.somasundaram@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
	"Alvin Lee" <alvin.lee2@amd.com>, "Wayne Lin" <Wayne.Lin@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	kael_w@yeah.net, "Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h
Date: Thu, 29 Apr 2021 10:41:21 -0400	[thread overview]
Message-ID: <20210429144121.v6ycsvwkk64s7grp@outlook.office365.com> (raw)
In-Reply-To: <AN*ARACWDmq3kx33Z4tCR4oU.3.1619698995121.Hmail.wanjiabing@vivo.com>

[-- Attachment #1.1: Type: text/plain, Size: 1751 bytes --]

Is your robot public available?

btw, applied to amd-staging-drm-next.

Thanks

On 04/29, Jiabing Wan wrote:
>  
> >Nice catch!
> >
> >Are you using any tool to identify this problem?
> 
> Yes, I have a robot including many detecting scripts :)
> 
> >Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> >
> >On 04/29, Wan Jiabing wrote:
> >> In commit 482812d56698e ("drm/amd/display: Set max TTU on
> >> DPG enable"), "hubp.h" was added which caused the duplicate include.
> >> To be on the safe side, remove the later duplicate include.
> >> 
> >> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> >> ---
> >>  drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
> >>  1 file changed, 1 deletion(-)
> >> 
> >> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> index 8f0a13807d05..dcaa6b1e16af 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> @@ -58,7 +58,6 @@
> >>  #include "dc_link_ddc.h"
> >>  #include "dm_helpers.h"
> >>  #include "mem_input.h"
> >> -#include "hubp.h"
> >>  
> >>  #include "dc_link_dp.h"
> >>  #include "dc_dmub_srv.h"
> >> -- 
> >> 2.25.1
> >> 
> >
> >-- 
> >Rodrigo Siqueira
> >https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsiqueira.tech%2F&amp;data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Cb8ff161b3a904a49e59808d90b0991d9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637552958013669698%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=I7AtEiOlzUuRQag7uAuArUvfd64l1b3gstq7ZTeucik%3D&amp;reserved=0
> 
> Yours,
> Wan Jiabing
> 

-- 
Rodrigo Siqueira
https://siqueira.tech

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel