From: Jiabing Wan <wanjiabing@vivo.com>
To: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: "Anson Jacob" <Anson.Jacob@amd.com>,
"Eric Yang" <Eric.Yang2@amd.com>,
"Wesley Chalmers" <Wesley.Chalmers@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
dri-devel@lists.freedesktop.org,
"Chiawen Huang" <chiawen.huang@amd.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
"Nicholas Kazlauskas" <nicholas.kazlauskas@amd.com>,
"Meenakshikumar Somasundaram"
<meenakshikumar.somasundaram@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
"Alvin Lee" <alvin.lee2@amd.com>, "Wayne Lin" <Wayne.Lin@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
kael_w@yeah.net, "Christian König" <christian.koenig@amd.com>
Subject: Re:Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h
Date: Thu, 29 Apr 2021 20:23:15 +0800 (GMT+08:00) [thread overview]
Message-ID: <AN*ARACWDmq3kx33Z4tCR4oU.3.1619698995121.Hmail.wanjiabing@vivo.com> (raw)
In-Reply-To: <20210429120504.sjruq5a3w2hdtusy@outlook.office365.com>
>Nice catch!
>
>Are you using any tool to identify this problem?
Yes, I have a robot including many detecting scripts :)
>Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>
>On 04/29, Wan Jiabing wrote:
>> In commit 482812d56698e ("drm/amd/display: Set max TTU on
>> DPG enable"), "hubp.h" was added which caused the duplicate include.
>> To be on the safe side, remove the later duplicate include.
>>
>> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>> ---
>> drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> index 8f0a13807d05..dcaa6b1e16af 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> @@ -58,7 +58,6 @@
>> #include "dc_link_ddc.h"
>> #include "dm_helpers.h"
>> #include "mem_input.h"
>> -#include "hubp.h"
>>
>> #include "dc_link_dp.h"
>> #include "dc_dmub_srv.h"
>> --
>> 2.25.1
>>
>
>--
>Rodrigo Siqueira
>https://siqueira.tech
Yours,
Wan Jiabing
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-29 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 3:04 [PATCH] drm/amd/display: Remove duplicate include of hubp.h Wan Jiabing
2021-04-29 12:05 ` Rodrigo Siqueira
2021-04-29 12:23 ` Jiabing Wan [this message]
2021-04-29 14:41 ` Rodrigo Siqueira
2021-04-29 15:18 ` Jiabing Wan
2021-04-29 15:21 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AN*ARACWDmq3kx33Z4tCR4oU.3.1619698995121.Hmail.wanjiabing@vivo.com' \
--to=wanjiabing@vivo.com \
--cc=Anson.Jacob@amd.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=Eric.Yang2@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Wayne.Lin@amd.com \
--cc=Wesley.Chalmers@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alvin.lee2@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=chiawen.huang@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=meenakshikumar.somasundaram@amd.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).