* [PATCH] drm: Remove unused branch in legacy PCI initialization
@ 2021-05-16 19:19 Thomas Zimmermann
2021-05-17 14:49 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Zimmermann @ 2021-05-16 19:19 UTC (permalink / raw)
To: daniel, airlied, mripard, maarten.lankhorst; +Cc: Thomas Zimmermann, dri-devel
The legacy PCI init code sets the drvdata for drivers with MODESET
flag, but none of the old UMS drivers sets the flag. Remove the branch.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/drm_pci.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c
index 38c3cb72e7e6..f508f70e7a3f 100644
--- a/drivers/gpu/drm/drm_pci.c
+++ b/drivers/gpu/drm/drm_pci.c
@@ -165,9 +165,6 @@ static int drm_legacy_get_pci_dev(struct pci_dev *pdev,
dev->hose = pdev->sysdata;
#endif
- if (drm_core_check_feature(dev, DRIVER_MODESET))
- pci_set_drvdata(pdev, dev);
-
drm_legacy_pci_agp_init(dev);
ret = drm_dev_register(dev, ent->driver_data);
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: Remove unused branch in legacy PCI initialization
2021-05-16 19:19 [PATCH] drm: Remove unused branch in legacy PCI initialization Thomas Zimmermann
@ 2021-05-17 14:49 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2021-05-17 14:49 UTC (permalink / raw)
To: Thomas Zimmermann; +Cc: airlied, dri-devel
On Sun, May 16, 2021 at 09:19:18PM +0200, Thomas Zimmermann wrote:
> The legacy PCI init code sets the drvdata for drivers with MODESET
> flag, but none of the old UMS drivers sets the flag. Remove the branch.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Yeah now that this is legacy-only it really doesn't make sense anymore.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/drm_pci.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c
> index 38c3cb72e7e6..f508f70e7a3f 100644
> --- a/drivers/gpu/drm/drm_pci.c
> +++ b/drivers/gpu/drm/drm_pci.c
> @@ -165,9 +165,6 @@ static int drm_legacy_get_pci_dev(struct pci_dev *pdev,
> dev->hose = pdev->sysdata;
> #endif
>
> - if (drm_core_check_feature(dev, DRIVER_MODESET))
> - pci_set_drvdata(pdev, dev);
> -
> drm_legacy_pci_agp_init(dev);
>
> ret = drm_dev_register(dev, ent->driver_data);
> --
> 2.31.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-17 14:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-16 19:19 [PATCH] drm: Remove unused branch in legacy PCI initialization Thomas Zimmermann
2021-05-17 14:49 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).