* [RESEND PATCH] drm/panel: ld9040: reference spi_device_id table
@ 2021-05-26 12:30 Krzysztof Kozlowski
2021-06-19 20:34 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-26 12:30 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
dri-devel, linux-kernel
Cc: Krzysztof Kozlowski
Reference the spi_device_id table to silence W=1 warning:
drivers/gpu/drm/panel/panel-samsung-ld9040.c:377:35:
warning: ‘ld9040_ids’ defined but not used [-Wunused-const-variable=]
This also would be needed for matching the driver if booted without
CONFIG_OF (although it's not necessarily real case).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/gpu/drm/panel/panel-samsung-ld9040.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-samsung-ld9040.c b/drivers/gpu/drm/panel/panel-samsung-ld9040.c
index f484147fc3a6..c4b388850a13 100644
--- a/drivers/gpu/drm/panel/panel-samsung-ld9040.c
+++ b/drivers/gpu/drm/panel/panel-samsung-ld9040.c
@@ -383,6 +383,7 @@ MODULE_DEVICE_TABLE(spi, ld9040_ids);
static struct spi_driver ld9040_driver = {
.probe = ld9040_probe,
.remove = ld9040_remove,
+ .id_table = ld9040_ids,
.driver = {
.name = "panel-samsung-ld9040",
.of_match_table = ld9040_of_match,
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] drm/panel: ld9040: reference spi_device_id table
2021-05-26 12:30 [RESEND PATCH] drm/panel: ld9040: reference spi_device_id table Krzysztof Kozlowski
@ 2021-06-19 20:34 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2021-06-19 20:34 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: David Airlie, Thierry Reding, dri-devel, linux-kernel
Hi Krzysztof
On Wed, May 26, 2021 at 08:30:02AM -0400, Krzysztof Kozlowski wrote:
> Reference the spi_device_id table to silence W=1 warning:
>
> drivers/gpu/drm/panel/panel-samsung-ld9040.c:377:35:
> warning: ‘ld9040_ids’ defined but not used [-Wunused-const-variable=]
>
> This also would be needed for matching the driver if booted without
> CONFIG_OF (although it's not necessarily real case).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Thanks, I noticed this warnings in my build and stumbled on this patch
in my inbox.
Applied to drm-misc-fixes,
Sam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-19 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-26 12:30 [RESEND PATCH] drm/panel: ld9040: reference spi_device_id table Krzysztof Kozlowski
2021-06-19 20:34 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).