* [PATCH] drm/amdgpu: remove unneeded variable
@ 2021-11-10 5:53 cgel.zte
2021-11-10 16:38 ` Alex Deucher
0 siblings, 1 reply; 4+ messages in thread
From: cgel.zte @ 2021-11-10 5:53 UTC (permalink / raw)
To: evan.quan
Cc: lijo.lazar, Jack.Gui, airlied, Zeal Robot, Xinhui.Pan,
linux-kernel, amd-gfx, luben.tuikov, dri-devel,
alexander.deucher, ran jianping, kenneth.feng, christian.koenig
From: ran jianping <ran.jianping@zte.com.cn>
Fix the following coccicheck review:
./drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c:1174:14-18
:Unneeded variable
Remove unneeded variable used to store return value.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
---
drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
index a4108025fe29..b0bb389185d5 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
@@ -1171,7 +1171,7 @@ static int sienna_cichlid_force_clk_levels(struct smu_context *smu,
enum smu_clk_type clk_type, uint32_t mask)
{
struct amdgpu_device *adev = smu->adev;
- int ret = 0, size = 0;
+ int ret = 0;
uint32_t soft_min_level = 0, soft_max_level = 0, min_freq = 0, max_freq = 0;
soft_min_level = mask ? (ffs(mask) - 1) : 0;
@@ -1216,7 +1216,7 @@ static int sienna_cichlid_force_clk_levels(struct smu_context *smu,
if ((clk_type == SMU_GFXCLK) || (clk_type == SMU_SCLK))
amdgpu_gfx_off_ctrl(adev, true);
- return size;
+ return 0;
}
static int sienna_cichlid_populate_umd_state_clk(struct smu_context *smu)
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amdgpu: remove unneeded variable
2021-11-10 5:53 [PATCH] drm/amdgpu: remove unneeded variable cgel.zte
@ 2021-11-10 16:38 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2021-11-10 16:38 UTC (permalink / raw)
To: CGEL
Cc: xinhui pan, Chengming Gui, Dave Airlie, Zeal Robot, Lazar, Lijo,
LKML, amd-gfx list, Tuikov, Luben, Maling list - DRI developers,
Deucher, Alexander, ran jianping, Quan, Evan, Kenneth Feng,
Christian Koenig
Applied. Thanks!
Alex
On Wed, Nov 10, 2021 at 12:53 AM <cgel.zte@gmail.com> wrote:
>
> From: ran jianping <ran.jianping@zte.com.cn>
>
> Fix the following coccicheck review:
> ./drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c:1174:14-18
> :Unneeded variable
>
> Remove unneeded variable used to store return value.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
> index a4108025fe29..b0bb389185d5 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
> @@ -1171,7 +1171,7 @@ static int sienna_cichlid_force_clk_levels(struct smu_context *smu,
> enum smu_clk_type clk_type, uint32_t mask)
> {
> struct amdgpu_device *adev = smu->adev;
> - int ret = 0, size = 0;
> + int ret = 0;
> uint32_t soft_min_level = 0, soft_max_level = 0, min_freq = 0, max_freq = 0;
>
> soft_min_level = mask ? (ffs(mask) - 1) : 0;
> @@ -1216,7 +1216,7 @@ static int sienna_cichlid_force_clk_levels(struct smu_context *smu,
> if ((clk_type == SMU_GFXCLK) || (clk_type == SMU_SCLK))
> amdgpu_gfx_off_ctrl(adev, true);
>
> - return size;
> + return 0;
> }
>
> static int sienna_cichlid_populate_umd_state_clk(struct smu_context *smu)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20230614022440.33828-1-luojianhong@cdjrlc.com>]
* [PATCH] drm/amdgpu: remove unneeded variable
[not found] <20230614022440.33828-1-luojianhong@cdjrlc.com>
@ 2023-06-14 2:26 ` baomingtong001
2023-06-15 17:16 ` Alex Deucher
0 siblings, 1 reply; 4+ messages in thread
From: baomingtong001 @ 2023-06-14 2:26 UTC (permalink / raw)
To: daniel, airlied; +Cc: dri-devel, amd-gfx
fix the following coccicheck warning:
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c:1156:5-11:
Unneeded variable: "result".
Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
---
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c
b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c
index 21be23ec3c79..36aa7657c66d 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c
@@ -1153,7 +1153,6 @@ int smu7_enable_power_containment(struct pp_hwmgr
*hwmgr)
struct phm_ppt_v1_information *table_info =
(struct phm_ppt_v1_information *)(hwmgr->pptable);
int smc_result;
- int result = 0;
struct phm_cac_tdp_table *cac_table;
data->power_containment_features = 0;
@@ -1191,7 +1190,7 @@ int smu7_enable_power_containment(struct pp_hwmgr
*hwmgr)
}
}
}
- return result;
+ return 0;
}
int smu7_disable_power_containment(struct pp_hwmgr *hwmgr)
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amdgpu: remove unneeded variable
2023-06-14 2:26 ` baomingtong001
@ 2023-06-15 17:16 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2023-06-15 17:16 UTC (permalink / raw)
To: baomingtong001; +Cc: amd-gfx, dri-devel
On Wed, Jun 14, 2023 at 3:20 AM <baomingtong001@208suo.com> wrote:
>
> fix the following coccicheck warning:
>
> drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c:1156:5-11:
> Unneeded variable: "result".
>
This variable is used and the code fails to compile with it removed.
Alex
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> ---
> drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c
> b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c
> index 21be23ec3c79..36aa7657c66d 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c
> @@ -1153,7 +1153,6 @@ int smu7_enable_power_containment(struct pp_hwmgr
> *hwmgr)
> struct phm_ppt_v1_information *table_info =
> (struct phm_ppt_v1_information *)(hwmgr->pptable);
> int smc_result;
> - int result = 0;
> struct phm_cac_tdp_table *cac_table;
>
> data->power_containment_features = 0;
> @@ -1191,7 +1190,7 @@ int smu7_enable_power_containment(struct pp_hwmgr
> *hwmgr)
> }
> }
> }
> - return result;
> + return 0;
> }
>
> int smu7_disable_power_containment(struct pp_hwmgr *hwmgr)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-15 17:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 5:53 [PATCH] drm/amdgpu: remove unneeded variable cgel.zte
2021-11-10 16:38 ` Alex Deucher
[not found] <20230614022440.33828-1-luojianhong@cdjrlc.com>
2023-06-14 2:26 ` baomingtong001
2023-06-15 17:16 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).