* [PATCH] drm: msm: fix possible memory leak in mdp5_crtc_cursor_set()
@ 2022-05-09 6:11 Hangyu Hua
2022-05-23 1:58 ` Hangyu Hua
0 siblings, 1 reply; 2+ messages in thread
From: Hangyu Hua @ 2022-05-09 6:11 UTC (permalink / raw)
To: robdclark, sean, quic_abhinavk, airlied, daniel,
dmitry.baryshkov, gbeeresh, sviau, wentaox
Cc: linux-arm-msm, freedreno, linux-kernel, dri-devel, Hangyu Hua
drm_gem_object_lookup will call drm_gem_object_get inside. So cursor_bo
needs to be put when msm_gem_get_and_pin_iova fails.
Fixes: e172d10a9c4a ("drm/msm/mdp5: Add hardware cursor support")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
---
drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
index b966cd69f99d..6a5f73f6a23b 100644
--- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
+++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
@@ -991,8 +991,10 @@ static int mdp5_crtc_cursor_set(struct drm_crtc *crtc,
ret = msm_gem_get_and_pin_iova(cursor_bo, kms->aspace,
&mdp5_crtc->cursor.iova);
- if (ret)
+ if (ret) {
+ drm_gem_object_put(cursor_bo);
return -EINVAL;
+ }
pm_runtime_get_sync(&pdev->dev);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: msm: fix possible memory leak in mdp5_crtc_cursor_set()
2022-05-09 6:11 [PATCH] drm: msm: fix possible memory leak in mdp5_crtc_cursor_set() Hangyu Hua
@ 2022-05-23 1:58 ` Hangyu Hua
0 siblings, 0 replies; 2+ messages in thread
From: Hangyu Hua @ 2022-05-23 1:58 UTC (permalink / raw)
To: robdclark, sean, quic_abhinavk, airlied, daniel,
dmitry.baryshkov, gbeeresh, sviau, wentaox
Cc: linux-arm-msm, freedreno, linux-kernel, dri-devel
On 2022/5/9 14:11, Hangyu Hua wrote:
> drm_gem_object_lookup will call drm_gem_object_get inside. So cursor_bo
> needs to be put when msm_gem_get_and_pin_iova fails.
>
> Fixes: e172d10a9c4a ("drm/msm/mdp5: Add hardware cursor support")
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> ---
> drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
> index b966cd69f99d..6a5f73f6a23b 100644
> --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
> +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
> @@ -991,8 +991,10 @@ static int mdp5_crtc_cursor_set(struct drm_crtc *crtc,
>
> ret = msm_gem_get_and_pin_iova(cursor_bo, kms->aspace,
> &mdp5_crtc->cursor.iova);
> - if (ret)
> + if (ret) {
> + drm_gem_object_put(cursor_bo);
> return -EINVAL;
> + }
>
> pm_runtime_get_sync(&pdev->dev);
>
Gentel ping.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-23 1:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-09 6:11 [PATCH] drm: msm: fix possible memory leak in mdp5_crtc_cursor_set() Hangyu Hua
2022-05-23 1:58 ` Hangyu Hua
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).