* [PATCH] gpu: lontium-lt9611: Fix NULL pointer dereference in lt9611_connector_init()
@ 2022-07-27 7:31 Zeng Jingxiang
2022-08-08 9:33 ` Robert Foss
0 siblings, 1 reply; 2+ messages in thread
From: Zeng Jingxiang @ 2022-07-27 7:31 UTC (permalink / raw)
To: andrzej.hajda, narmstrong, robert.foss, Laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel
Cc: Zeng Jingxiang, linux-kernel, dri-devel
From: Zeng Jingxiang <linuszeng@tencent.com>
A NULL check for bridge->encoder shows that it may be NULL, but it
already been dereferenced on all paths leading to the check.
812 if (!bridge->encoder) {
Dereference the pointer bridge->encoder.
810 drm_connector_attach_encoder(<9611->connector, bridge->encoder);
Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>
---
drivers/gpu/drm/bridge/lontium-lt9611.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index 7ef8fe5abc12..81a4751573fa 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -807,13 +807,14 @@ static int lt9611_connector_init(struct drm_bridge *bridge, struct lt9611 *lt961
drm_connector_helper_add(<9611->connector,
<9611_bridge_connector_helper_funcs);
- drm_connector_attach_encoder(<9611->connector, bridge->encoder);
if (!bridge->encoder) {
DRM_ERROR("Parent encoder object not found");
return -ENODEV;
}
+ drm_connector_attach_encoder(<9611->connector, bridge->encoder);
+
return 0;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpu: lontium-lt9611: Fix NULL pointer dereference in lt9611_connector_init()
2022-07-27 7:31 [PATCH] gpu: lontium-lt9611: Fix NULL pointer dereference in lt9611_connector_init() Zeng Jingxiang
@ 2022-08-08 9:33 ` Robert Foss
0 siblings, 0 replies; 2+ messages in thread
From: Robert Foss @ 2022-08-08 9:33 UTC (permalink / raw)
To: Zeng Jingxiang
Cc: Zeng Jingxiang, jonas, airlied, dri-devel, narmstrong,
linux-kernel, jernej.skrabec, Laurent.pinchart, andrzej.hajda
On Wed, 27 Jul 2022 at 09:31, Zeng Jingxiang <zengjx95@gmail.com> wrote:
>
> From: Zeng Jingxiang <linuszeng@tencent.com>
>
> A NULL check for bridge->encoder shows that it may be NULL, but it
> already been dereferenced on all paths leading to the check.
> 812 if (!bridge->encoder) {
>
> Dereference the pointer bridge->encoder.
> 810 drm_connector_attach_encoder(<9611->connector, bridge->encoder);
>
> Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index 7ef8fe5abc12..81a4751573fa 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -807,13 +807,14 @@ static int lt9611_connector_init(struct drm_bridge *bridge, struct lt9611 *lt961
>
> drm_connector_helper_add(<9611->connector,
> <9611_bridge_connector_helper_funcs);
> - drm_connector_attach_encoder(<9611->connector, bridge->encoder);
>
> if (!bridge->encoder) {
> DRM_ERROR("Parent encoder object not found");
> return -ENODEV;
> }
>
> + drm_connector_attach_encoder(<9611->connector, bridge->encoder);
> +
> return 0;
> }
>
> --
> 2.27.0
>
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-08 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-27 7:31 [PATCH] gpu: lontium-lt9611: Fix NULL pointer dereference in lt9611_connector_init() Zeng Jingxiang
2022-08-08 9:33 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).